X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=filter.c;h=b8a7c5c19231d415f0e2488a6275f619901e2d65;hp=09b644151a3cf4b8f081bf42743224b28a6829dd;hb=672e27768e31a6eaa6854d4fc75ee6885db9abd8;hpb=cec9a9348c155e285eb94f024b263d52e1735301

diff --git a/filter.c b/filter.c
index 09b64415..b8a7c5c1 100644
--- a/filter.c
+++ b/filter.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2008 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2009 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -11,6 +11,7 @@
 #include "filter.cmdline.h"
 #include "list.h"
 #include "sched.h"
+#include "ggo.h"
 #include "filter.h"
 #include "string.h"
 #include "stdin.h"
@@ -43,7 +44,8 @@ static struct stdout_task *sot = &stdout_task_struct;
 /** Gengetopt struct that holds the command line args. */
 static struct filter_args_info conf;
 
-INIT_STDERR_LOGGING(conf.loglevel_arg);
+static int loglevel;
+INIT_STDERR_LOGGING(loglevel);
 
 static void open_filters(void)
 {
@@ -54,7 +56,7 @@ static void open_filters(void)
 		struct filter *f = filters + fn->filter_num;
 		f->open(fn);
 		PARA_INFO_LOG("opened %s filter\n", f->name);
-		fc->outbuf = fn->buf;
+		fc->outbufp = &fn->buf;
 		fc->out_loaded = &fn->loaded;
 	}
 }
@@ -68,7 +70,7 @@ static int init_filter_chain(void)
 		return -E_NO_FILTERS;
 	fc->num_filters = conf.filter_given;
 	fc->filter_nodes = para_malloc(fc->num_filters * sizeof(struct filter_node));
-	fc->inbuf = sit->buf;
+	fc->inbufp = &sit->buf;
 	fc->in_loaded = &sit->loaded;
 	fc->input_error = &sit->task.error;
 	fc->task.error = 0;
@@ -94,15 +96,31 @@ err:
 	return ret;
 }
 
+__noreturn static void print_help_and_die(void)
+{
+	int d = conf.detailed_help_given;
+	const char **p = d? filter_args_info_detailed_help
+		: filter_args_info_help;
+
+	printf_or_die("%s\n\n", FILTER_CMDLINE_PARSER_PACKAGE "-"
+		FILTER_CMDLINE_PARSER_VERSION);
+	printf_or_die("%s\n\n", filter_args_info_usage);
+	for (; *p; p++)
+		printf_or_die("%s\n", *p);
+	print_filter_helps(d);
+	exit(0);
+}
+
 static int parse_config(int argc, char *argv[])
 {
 	static char *cf; /* config file */
 	struct stat statbuf;
-	int i;
 
 	if (filter_cmdline_parser(argc, argv, &conf))
 		return -E_FILTER_SYNTAX;
 	HANDLE_VERSION_FLAG("filter", conf);
+	if (conf.help_given || conf.detailed_help_given)
+		print_help_and_die();
 	if (!cf) {
 		char *home = para_homedir();
 		cf = make_message("%s/.paraslash/filter.conf", home);
@@ -118,15 +136,7 @@ static int parse_config(int argc, char *argv[])
 		if (filter_cmdline_parser_config_file(cf, &conf, &params))
 			return -E_FILTER_SYNTAX;
 	}
-	if (!conf.list_filters_given)
-		return 1;
-	printf("available filters: ");
-	for (i = 0; filters[i].name; i++)
-		printf("%s%s%s", i? " " : "", filters[i].name,
-			filters[i].parse_config? "*": "");
-	printf("\nFilters marked with \"*\" have further command line options. Try\n"
-		"\tpara_filter -f '<filtername> -h'\nfor more information.\n");
-	exit(EXIT_SUCCESS);
+	return 1;
 }
 
 /**
@@ -149,16 +159,18 @@ int main(int argc, char *argv[])
 	stdin_set_defaults(sit);
 	sit->buf = para_malloc(sit->bufsize),
 
-	filter_init(filters);
+	filter_init();
 	ret = parse_config(argc, argv);
 	if (ret < 0)
 		goto out;
+	loglevel = get_loglevel_by_name(conf.loglevel_arg);
 	ret = init_filter_chain();
 	if (ret < 0)
 		goto out;
+	sit->output_error = &fc->task.error;
 
 	stdout_set_defaults(sot);
-	sot->buf = fc->outbuf;
+	sot->bufp = fc->outbufp;
 	sot->loaded = fc->out_loaded;
 	sot->input_error = &fc->task.error;