X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=filter_chain.c;h=ee94e8ff13fff3c2fdd505e369f1bb88f2ee6e9d;hp=5b87b087f6075770ab3a84a8bdbdac814afb99a4;hb=5430c77f1fdf97d92796f44623d257b8124bde24;hpb=b0cad48a864fe3f621138e717ff025060c396fad

diff --git a/filter_chain.c b/filter_chain.c
index 5b87b087..ee94e8ff 100644
--- a/filter_chain.c
+++ b/filter_chain.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2006 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2007 Andre Noll <maan@systemlinux.org>
  *
  *     This program is free software; you can redistribute it and/or modify
  *     it under the terms of the GNU General Public License as published by
@@ -69,8 +69,11 @@ static void close_callbacks(struct filter_node *fn)
 {
 	struct filter_callback *fcb, *tmp;
 
-	list_for_each_entry_safe(fcb, tmp, &fn->callbacks, node)
+	list_for_each_entry_safe(fcb, tmp, &fn->callbacks, node) {
+		PARA_INFO_LOG("closing %s filter callback\n",
+			fn->filter->name);
 		close_filter_callback(fcb);
+	}
 }
 
 static void call_callbacks(struct filter_node *fn, char *inbuf, size_t inlen,
@@ -97,6 +100,9 @@ static void call_callbacks(struct filter_node *fn, char *inbuf, size_t inlen,
 /**
  * call the convert function of each filter
  *
+ * \param s unused
+ * \param t the task containing the filter chain
+ *
  * This is the core function of the filter subsystem. It loops over the list of
  * filter nodes determined by \a t and calls the filter's convert function if
  * there is input available for the filter node in question. If the convert
@@ -119,7 +125,7 @@ void filter_pre_select(__a_unused struct sched *s, struct task *t)
 	int conv, conv_total = 0;
 
 	t->ret = -E_FC_EOF;
-	if (*fc->output_eof)
+	if (fc->output_eof && *fc->output_eof)
 		goto err_out;
 again:
 	ib = fc->inbuf;
@@ -128,8 +134,8 @@ again:
 	list_for_each_entry(fn, &fc->filters, node) {
 		if (*loaded && fn->loaded < fn->bufsize) {
 			size_t old_fn_loaded = fn->loaded;
-			PARA_DEBUG_LOG("fc %p loaded: %zd, calling %s convert\n",
-				fc, *loaded, fn->filter->name);
+//			PARA_DEBUG_LOG("fc %p loaded: %zd, calling %s convert\n",
+//				fc, *loaded, fn->filter->name);
 			t->ret = fn->filter->convert(ib, *loaded, fn);
 			if (t->ret < 0)
 				goto err_out;
@@ -138,8 +144,9 @@ again:
 			*loaded -= t->ret;
 			conv += t->ret;
 			if (*loaded && t->ret) {
-				PARA_DEBUG_LOG("moving %zd bytes in input buffer for %s filter\n",
-					*loaded,  fn->filter->name);
+//				PARA_DEBUG_LOG("moving %zd bytes in input "
+//					"buffer for %s filter\n",
+//					*loaded,  fn->filter->name);
 				memmove(ib, ib + t->ret, *loaded);
 			}
 		}
@@ -147,8 +154,10 @@ again:
 		loaded = &fn->loaded;
 	}
 	conv_total += conv;
-	PARA_DEBUG_LOG("eof (in/out/fc): %d/%d/%d out_loaded: %d, conv: %d, conv_total: %d\n", *fc->input_eof,
-		*fc->output_eof, fc->eof, *fc->out_loaded, conv, conv_total);
+//	PARA_DEBUG_LOG("eof (in/out/fc): %d/%d/%d out_loaded: %zd, "
+//		"conv: %d, conv_total: %d\n", *fc->input_eof,
+//		fc->output_eof? *fc->output_eof : -42,
+//		fc->eof, *fc->out_loaded, conv, conv_total);
 	if (conv)
 		goto again;
 	t->ret = 1;
@@ -181,11 +190,10 @@ void close_filters(struct filter_chain *fc)
 
 	if (!fc)
 		return;
-	PARA_DEBUG_LOG("closing filter chain %p\n", fc);
+	PARA_NOTICE_LOG("closing filter chain %p\n", fc);
 	list_for_each_entry_safe(fn, tmp, &fc->filters, node) {
-		PARA_NOTICE_LOG("closing %s filter callbacks (fc %p, fn %p)\n", fn->filter->name, fc, fn);
 		close_callbacks(fn);
-		PARA_NOTICE_LOG("closing %s filter (fc %p, fn %p)\n", fn->filter->name, fc, fn);
+		PARA_INFO_LOG("closing %s filter\n", fn->filter->name);
 		fn->filter->close(fn);
 		list_del(&fn->node);
 		free(fn);
@@ -214,6 +222,8 @@ static int parse_filter_args(int filter_num, char *options, void **conf)
 	argv[0] = para_strdup(f->name);
 	argc += 1;
 	*conf = f->parse_config(argc, argv);
+	free(argv[0]);
+	free(argv);
 	return *conf? filter_num : -E_BAD_FILTER_OPTIONS;
 }