X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=filter_common.c;h=6db0c57f6a062f923abdb2eafb807d0a547eff82;hp=1233c9ad80ac5c76d8d50c7b52a6abfe0f4a1219;hb=47a9983cc65ef57ad25c4ba3e16cabe48fd57b23;hpb=d49cd9a91015766cb19d7d43bb04048265925fe5

diff --git a/filter_common.c b/filter_common.c
index 1233c9ad..6db0c57f 100644
--- a/filter_common.c
+++ b/filter_common.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2014 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -8,7 +8,6 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <stdbool.h>
 
 #include "para.h"
 #include "list.h"
@@ -42,25 +41,16 @@ void filter_init(void)
 static int parse_filter_args(int filter_num, char *options, void **conf)
 {
 	struct filter *f = &filters[filter_num];
-	int ret, i, argc = 2;
+	int ret, argc;
 	char **argv;
 
-//	PARA_DEBUG_LOG("%s, options: %s, parser: %p\n", f->name,
-//		options? options : "(none)", f->parse_config);
 	if (!f->parse_config)
 		return strlen(options)? -E_BAD_FILTER_OPTIONS : filter_num;
-//	PARA_DEBUG_LOG("options: %s\n", options);
-	argc = create_argv(options, " \t", &argv);
+	argc = create_shifted_argv(options, " \t", &argv);
 	if (argc < 0)
 		return -E_BAD_FILTER_OPTIONS;
-	PARA_DEBUG_LOG("argc = %d, argv[0]: %s\n", argc, argv[0]);
-	for (i = argc - 1; i >= 0; i--)
-		argv[i + 1] = argv[i];
 	argv[0] = para_strdup(f->name);
-	argc++;
 	ret = f->parse_config(argc, argv, conf);
-	free(argv[argc - 1]);
-	argv[argc - 1] = NULL;
 	free_argv(argv);
 	return ret < 0? ret : filter_num;
 }
@@ -111,43 +101,48 @@ int check_filter_arg(char *fa, void **conf)
 /**
  * Print help text of each filter to stdout.
  *
- * \param detailed If non-zero, print detailed help.
+ * \param flags Passed to \ref ggo_print_help().
  */
-void print_filter_helps(int detailed)
+void print_filter_helps(unsigned flags)
 {
-	int i;
+	int i, num = 0;
 
-	printf_or_die("\nAvailable filters: \n\t");
-	FOR_EACH_SUPPORTED_FILTER(i)
-		printf_or_die("%s%s", i? " " : "", filters[i].name);
-	printf_or_die("\n\n");
+	printf_or_die("\nAvailable filters: ");
+	FOR_EACH_SUPPORTED_FILTER(i) {
+		if (num > 50) {
+			printf_or_die("\n                  ");
+			num = 0;
+		}
+		num += printf_or_die("%s%s", i? " " : "", filters[i].name);
+	}
+	printf_or_die("\n");
 
 	FOR_EACH_SUPPORTED_FILTER(i) {
 		struct filter *f = filters + i;
 
 		if (!f->help.short_help)
 			continue;
-		printf_or_die("Options for %s:\n", f->name);
-		ggo_print_help(&f->help, detailed);
+		printf_or_die("\nOptions for %s (%s):", f->name,
+			f->help.purpose);
+		ggo_print_help(&f->help, flags);
 	}
 }
 
 /**
- * Set select timeout of the the scheduler.
+ * Set select timeout of the scheduler.
  *
  * \param s The scheduler.
- * \param t The task struct of this filter.
+ * \param context Pointer to the filter node (task context).
  *
  * This looks at the status of the btr node of the filter. If data is available
- * in the input queue of the filter, or if an error occured, a minimal timeout
+ * in the input queue of the filter, or if an error occurred, a minimal timeout
  * for the next select call is requested from the scheduler. Otherwise the
  * scheduler timeout is left unchanged.
  */
-void generic_filter_pre_select(struct sched *s, struct task *t)
+void generic_filter_pre_select(struct sched *s, void *context)
 {
-	struct filter_node *fn = container_of(t, struct filter_node, task);
+	struct filter_node *fn = context;
 
-	t->error = 0;
 	if (btr_node_status(fn->btrn, fn->min_iqs, BTR_NT_INTERNAL) != 0)
 		sched_min_delay(s);
 }