X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=filter_common.c;h=6fb9bd96ef8278b3e328198e24db78664a956542;hp=53cde746001b6a42eb8e482addcd6231ad5560d5;hb=5e8d8a8eea6de9459ebdf4498f9f061c84bfa63a;hpb=7eab3b26d6c5094ad13bf64ac07eaed57f7b69a0 diff --git a/filter_common.c b/filter_common.c index 53cde746..6fb9bd96 100644 --- a/filter_common.c +++ b/filter_common.c @@ -23,7 +23,24 @@ #define FOR_EACH_SUPPORTED_FILTER(j) for (j = 0; j < NUM_SUPPORTED_FILTERS; j++) /** The array of supported filters. */ -struct filter filters[NUM_SUPPORTED_FILTERS] = {FILTER_ARRAY}; +static struct filter filters[NUM_SUPPORTED_FILTERS] = {FILTER_ARRAY}; + +/** + * Obtain a reference to a filter structure. + * + * \param filter_num Between zero and NUM_SUPPORTED_FILTERS, inclusively. + * + * \return Pointer to the filter identified by the given filter number. + * + * It is a fatal error if the given number is out of range. In this case + * the function aborts. + */ +const struct filter *filter_get(int filter_num) +{ + assert(filter_num >= 0); + assert(filter_num < NUM_SUPPORTED_FILTERS); + return filters + filter_num; +} /** * Call the init function of each supported filter. @@ -34,7 +51,7 @@ void filter_init(void) int i; FOR_EACH_SUPPORTED_FILTER(i) - filters[i].init(filters + i); + filter_get(i)->init((struct filter *)filter_get(i)); } /* @@ -43,7 +60,7 @@ void filter_init(void) */ static int parse_filter_args(int filter_num, char *options, void **conf) { - struct filter *f = &filters[filter_num]; + const struct filter *f = filter_get(filter_num); int ret, argc; char **argv; @@ -83,7 +100,7 @@ int check_filter_arg(char *fa, void **conf) *conf = NULL; // PARA_DEBUG_LOG("arg: %s\n", fa); FOR_EACH_SUPPORTED_FILTER(j) { - const char *name = filters[j].name; + const char *name = filter_get(j)->name; size_t len = strlen(name); char c; if (strlen(fa) < len) @@ -93,7 +110,7 @@ int check_filter_arg(char *fa, void **conf) c = fa[len]; if (c && c != ' ') continue; - if (c && !filters[j].parse_config) + if (c && !filter_get(j)->parse_config) return -E_BAD_FILTER_OPTIONS; return parse_filter_args(j, c? fa + len + 1 : fa + strlen(fa), conf); @@ -116,12 +133,12 @@ void print_filter_helps(unsigned flags) printf_or_die("\n "); num = 0; } - num += printf_or_die("%s%s", i? " " : "", filters[i].name); + num += printf_or_die("%s%s", i? " " : "", filter_get(i)->name); } printf_or_die("\n"); FOR_EACH_SUPPORTED_FILTER(i) { - struct filter *f = filters + i; + struct filter *f = (struct filter *)filter_get(i); if (!f->help.short_help) continue;