X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=filter_common.c;h=cfe08dd1e7274bff947ddc50e70f3711fe60422e;hp=1b02e1cdfbd1c106ae8ec69125af108ae24b8d8f;hb=1dbe0b9828c0fe0fb642361473dedbcef7defc4c;hpb=0981b6cfe49fedf9855e42bbde1f81a89c6a4ea1 diff --git a/filter_common.c b/filter_common.c index 1b02e1cd..cfe08dd1 100644 --- a/filter_common.c +++ b/filter_common.c @@ -6,6 +6,7 @@ /** \file filter_common.c Common helper functions for filter input/output. */ +#include #include #include @@ -43,7 +44,7 @@ void filter_init(void) */ static void close_filter_callback(struct filter_callback *fcb) { - PARA_NOTICE_LOG("closing filter_callback %p, data: %p\n", fcb, fcb->data); + PARA_NOTICE_LOG("closing filter_callback %p\n", fcb); list_del(&fcb->node); fcb->close(fcb); } @@ -208,15 +209,18 @@ static int parse_filter_args(int filter_num, char *options, void **conf) if (!f->parse_config) return strlen(options)? -E_BAD_FILTER_OPTIONS : filter_num; // PARA_DEBUG_LOG("options: %s\n", options); - argc = split_args(options, &argv, " \t"); -// PARA_DEBUG_LOG("argc = %d, argv[0]: %s\n", argc, argv[0]); + argc = create_argv(options, " \t", &argv); + if (argc < 0) + return -E_BAD_FILTER_OPTIONS; + PARA_DEBUG_LOG("argc = %d, argv[0]: %s\n", argc, argv[0]); for (i = argc - 1; i >= 0; i--) argv[i + 1] = argv[i]; argv[0] = para_strdup(f->name); - argc += 1; + argc++; ret = f->parse_config(argc, argv, conf); - free(argv[0]); - free(argv); + free(argv[argc - 1]); + argv[argc - 1] = NULL; + free_argv(argv); return ret < 0? ret : filter_num; }