X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=grab_client.c;h=77d3616d2c2e41b3caf32f5fea13d54cf778642b;hp=d842cb8a86e90f283729b25979d62971c3628c4b;hb=d27b31524e1d60ad4fdbeb606bba31ba0ee54048;hpb=3689799ede7bba230ca544ac953392b428c3d662 diff --git a/grab_client.c b/grab_client.c index d842cb8a..77d3616d 100644 --- a/grab_client.c +++ b/grab_client.c @@ -1,14 +1,14 @@ /* - * Copyright (C) 2006 Andre Noll + * Copyright (C) 2006-2008 Andre Noll * * Licensed under the GPL v2. For licencing details see COPYING. */ /** - * \file grab_client.c functions for grabbing the stream at any position - * in a filter chain + * \file grab_client.c Functions for grabbing the stream at any position + * in a filter chain. * - * \sa filter_chain filter_chain_info filter + * \sa filter_chain filter_chain_info filter. */ #include @@ -26,7 +26,7 @@ #include "fd.h" #include "crypt.h" -/** grab clients that are not yet attached to a filter node */ +/** Grab clients that are not yet attached to a filter node. */ struct list_head inactive_grab_client_list; static int max_num_filters(void) @@ -97,15 +97,15 @@ static int check_gc_args(struct grab_client *gc) if (gc->audio_format_num < 0) return gc->audio_format_num; } - if (c->slot_arg > MAX_STREAM_SLOTS) + if (c->slot_arg >= MAX_STREAM_SLOTS) return -E_BAD_GC_SLOT; - if (c->filter_num_arg <= 0) + if (c->filter_num_arg < 0) return -E_BAD_GC_FILTER_NUM; if (c->audio_format_given) { - if (num_filters(gc->audio_format_num) < c->filter_num_arg) + if (num_filters(gc->audio_format_num) <= c->filter_num_arg) return -E_BAD_GC_FILTER_NUM; } else - if (c->filter_num_arg > max_num_filters()) + if (c->filter_num_arg >= max_num_filters()) return -E_BAD_GC_FILTER_NUM; return 1; @@ -145,12 +145,12 @@ static void gc_close(struct filter_callback *fcb) } /** - * move a grab client from the inactive list to a filter node + * Move a grab client from the inactive list to a filter node. * - * \param gc the grab client to activate - * \param fn the filter node \a gc gets attached to + * \param gc The grab client to activate. + * \param fn The filter node \a gc gets attached to. * - * \sa filter_node::callbacks, inactive_grab_client_list + * \sa filter_node::callbacks, inactive_grab_client_list. */ void activate_grab_client(struct grab_client *gc, struct filter_node *fn) { @@ -160,11 +160,11 @@ void activate_grab_client(struct grab_client *gc, struct filter_node *fn) } /** - * activate inactive grab clients if possible + * Activate inactive grab clients if possible. * - * \param slot_num audiod's slot for the new audio file - * \param audio_format_num the number of the audio format of the new audio file - * \param filter_list the list of activated filters for that new audio file + * \param slot_num Audiod's slot for the new audio file. + * \param audio_format_num The number of the audio format of the new audio file. + * \param fc The filter chain containing the activated filters. * * This is called from audiod.c when the current audio file changes. It loops * over all inactive grab clients and checks each grab client's configuration @@ -173,13 +173,13 @@ void activate_grab_client(struct grab_client *gc, struct filter_node *fn) * appropriate filter_node. * * \sa filter_chain_info::filters, inactive_grab_client_list, - * activate_grab_client + * activate_grab_client. */ void activate_inactive_grab_clients(int slot_num, int audio_format_num, - struct list_head *filter_list) + struct filter_chain *fc) { struct grab_client *gc, *tmp; - int i; + int filter_num; struct filter_node *fn; list_for_each_entry_safe(gc, tmp, &inactive_grab_client_list, node) { @@ -189,27 +189,20 @@ void activate_inactive_grab_clients(int slot_num, int audio_format_num, if (gc->audio_format_num >= 0 && gc->audio_format_num != audio_format_num) continue; - if (gc->conf->filter_num_arg >= 0 && - num_filters(gc->audio_format_num) - < gc->conf->filter_num_arg) + filter_num = gc->conf->filter_num_arg; + if (filter_num >= num_filters(gc->audio_format_num)) continue; - i = 1; - list_for_each_entry(fn, filter_list, node) { - if (gc->conf->filter_num_arg <= 0 - || i == gc->conf->filter_num_arg) - break; - i++; - } + fn = fc->filter_nodes + filter_num; activate_grab_client(gc, fn); } } /** - * check the command line options and allocate a grab_client structure + * Check the command line options and allocate a grab_client structure. * - * \param fd the file descriptor of the client - * \param line the command line - * \param err non-zero if an error occured + * \param fd The file descriptor of the client. + * \param line The command line. + * \param err Non-zero if an error occurred. * * If the command line options given by \a argc and \a argv are valid. * allocate a struct grab_client and initialize it with this valid @@ -219,7 +212,7 @@ void activate_inactive_grab_clients(int slot_num, int audio_format_num, * struct. On errors, it returns NULL and sets \a err appropriately. * * \sa grab_client, inactive_grab_client_list, activate_grab_client, - * filter_node::callbacks + * filter_node::callbacks. */ /* * argc, argv get freed when com_grab() returns, so we have to make a @@ -263,14 +256,14 @@ err_out: return NULL; } -/** initialize the grabbing subsystem. +/** + * Initialize the grabbing subsystem. * * This has to be called once during startup before any other function from * grab_client.c may be used. It initializes \a inactive_grab_client_list. */ void init_grabbing(void) { - PARA_INFO_LOG("%s", "grab init\n"); + PARA_INFO_LOG("grab init\n"); INIT_LIST_HEAD(&inactive_grab_client_list); } -