X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=grab_client.c;h=9109c2f8f6c5f1978eddd356ff7f8e979d73dd8a;hp=5971f115e7e11d077e825cc744d97abf2f6cbfd5;hb=bda95f9508b456dcea89d300f6d4104e30ab9f3e;hpb=645175864a613fc539f46ffa4028742aad3b1b30

diff --git a/grab_client.c b/grab_client.c
index 5971f115..9109c2f8 100644
--- a/grab_client.c
+++ b/grab_client.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2011 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -8,7 +8,6 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <dirent.h>
 #include <stdbool.h>
 
 #include "para.h"
@@ -62,9 +61,9 @@ struct grab_client {
 };
 
 /* Grab clients that are attached to a btr node. */
-INITIALIZED_LIST_HEAD(active_grab_client_list);
+static INITIALIZED_LIST_HEAD(active_grab_client_list);
 /* Grab clients that are not currently attached any btr node. */
-INITIALIZED_LIST_HEAD(inactive_grab_client_list);
+static INITIALIZED_LIST_HEAD(inactive_grab_client_list);
 
 static int gc_write(struct grab_client *gc, char *buf, size_t len)
 {
@@ -101,11 +100,8 @@ static void gc_pre_select(struct sched *s, struct task *t)
 
 	if (ret == 0)
 		return;
-	if (ret < 0) {
-		s->timeout.tv_sec = 0;
-		s->timeout.tv_usec = 0;
-		return;
-	}
+	if (ret < 0)
+		sched_min_delay(s);
 	para_fd_set(gc->fd, &s->wfds, &s->max_fileno);
 }
 
@@ -134,13 +130,12 @@ static void gc_activate(struct grab_client *gc)
 	list_move(&gc->node, &active_grab_client_list);
 	gc->btrn = btr_new_node(&(struct btr_node_description)
 		EMBRACE(.name = name, .parent = parent));
-	if (!gc->task.pre_select) {
-		gc->task.pre_select = gc_pre_select;
-		gc->task.post_select = gc_post_select;
-		snprintf(gc->task.status, sizeof(gc->task.status) - 1, "%s", name);
-		gc->task.status[sizeof(gc->task.status) - 1] = '\0';
-		register_task(&gc->task);
-	}
+	gc->task.pre_select = gc_pre_select;
+	gc->task.post_select = gc_post_select;
+	snprintf(gc->task.status, sizeof(gc->task.status) - 1, "%s", name);
+	gc->task.status[sizeof(gc->task.status) - 1] = '\0';
+	gc->task.error = 0;
+	register_task(&gc->task);
 }
 
 /**
@@ -159,7 +154,7 @@ void activate_grab_clients(void)
 	struct grab_client *gc, *tmp;
 
 	list_for_each_entry_safe(gc, tmp, &inactive_grab_client_list, node) {
-		if (gc->task.error == -E_TASK_UNREGISTERED) {
+		if (gc->fd < 0) {
 			list_del(&gc->node);
 			free(gc);
 			continue;
@@ -182,11 +177,11 @@ static int gc_close(struct grab_client *gc, int err)
 		 * post_select().
 		 */
 		close(gc->fd);
+		gc->fd = -1;
 		free(gc->parent);
 		free(gc->name);
 		return 1;
 	}
-	gc_activate(gc);
 	return 0;
 }
 
@@ -213,7 +208,8 @@ static void gc_post_select(__a_unused struct sched *s, struct task *t)
 		btr_consume(btrn, ret);
 	return;
 err:
-	t->error = gc_close(gc, ret)? ret : 0;
+	gc_close(gc, ret);
+	t->error = ret;
 }
 
 static int gc_check_args(int argc, char **argv, struct grab_client *gc)