X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=grab_client.c;h=ecc16fc89bd66d6a71b351b9e468d125bc8a1775;hp=9109c2f8f6c5f1978eddd356ff7f8e979d73dd8a;hb=9d75ded33ce6664156acb07e311f51d55970bbea;hpb=32e646780461f96682d1191d31e08e4602ab125e

diff --git a/grab_client.c b/grab_client.c
index 9109c2f8..ecc16fc8 100644
--- a/grab_client.c
+++ b/grab_client.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -8,7 +8,6 @@
 
 #include <regex.h>
 #include <sys/types.h>
-#include <stdbool.h>
 
 #include "para.h"
 #include "list.h"
@@ -77,7 +76,7 @@ static int gc_write(struct grab_client *gc, char *buf, size_t len)
 		if (gc->mode == GM_SLOPPY)
 			return len;
 	}
-	ret = write_nonblock(gc->fd, buf, len);
+	ret = xwrite(gc->fd, buf, len);
 	if (ret < 0)
 		goto err;
 	if (ret > 0)
@@ -109,14 +108,14 @@ static void gc_pre_select(struct sched *s, struct task *t)
  * We need this forward declaration as post_select() needs
  * activate_grab_client and vice versa.
  */
-static void gc_post_select(struct sched *s, struct task *t);
+static int gc_post_select(struct sched *s, struct task *t);
 
 /**
  * Move a grab client to the active list and start it.
  *
  * \param gc The grab client to activate.
  */
-static void gc_activate(struct grab_client *gc)
+static void gc_activate(struct grab_client *gc, struct sched *s)
 {
 	struct btr_node *root = audiod_get_btr_root(), *parent;
 	char *name = gc->name? gc->name : "grab";
@@ -135,12 +134,14 @@ static void gc_activate(struct grab_client *gc)
 	snprintf(gc->task.status, sizeof(gc->task.status) - 1, "%s", name);
 	gc->task.status[sizeof(gc->task.status) - 1] = '\0';
 	gc->task.error = 0;
-	register_task(&gc->task);
+	register_task(s, &gc->task);
 }
 
 /**
  * Activate inactive grab clients if possible.
  *
+ * \param s Needed to schedule the grab client task.
+ *
  * This is called from audiod.c when the current audio file changes. It loops
  * over all inactive grab clients and checks each grab client's configuration
  * to determine if the client in question wishes to grab the new stream.  If
@@ -149,7 +150,7 @@ static void gc_activate(struct grab_client *gc)
  * This function also garbage collects all grab clients whose tasks have been
  * unscheduled.
  */
-void activate_grab_clients(void)
+void activate_grab_clients(struct sched *s)
 {
 	struct grab_client *gc, *tmp;
 
@@ -159,15 +160,13 @@ void activate_grab_clients(void)
 			free(gc);
 			continue;
 		}
-		gc_activate(gc);
+		gc_activate(gc, s);
 	}
 }
 
 static int gc_close(struct grab_client *gc, int err)
 {
-	btr_remove_node(gc->btrn);
-	btr_free_node(gc->btrn);
-	gc->btrn = NULL;
+	btr_remove_node(&gc->btrn);
 	PARA_INFO_LOG("closing gc: %s\n", para_strerror(-err));
 	list_move(&gc->node, &inactive_grab_client_list);
 	if (err == -E_GC_WRITE || (gc->flags & GF_ONE_SHOT)) {
@@ -185,7 +184,7 @@ static int gc_close(struct grab_client *gc, int err)
 	return 0;
 }
 
-static void gc_post_select(__a_unused struct sched *s, struct task *t)
+static int gc_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct grab_client *gc = container_of(t, struct grab_client, task);
 	struct btr_node *btrn = gc->btrn;
@@ -193,10 +192,9 @@ static void gc_post_select(__a_unused struct sched *s, struct task *t)
 	size_t sz;
 	char *buf;
 
-	t->error = 0;
 	ret = btr_node_status(btrn, 0, BTR_NT_LEAF);
 	if (ret == 0)
-		return;
+		return 0;
 	if (ret < 0)
 		goto err;
 	sz = btr_next_buffer(btrn, &buf);
@@ -206,10 +204,10 @@ static void gc_post_select(__a_unused struct sched *s, struct task *t)
 		goto err;
 	if (ret > 0)
 		btr_consume(btrn, ret);
-	return;
+	return 0;
 err:
 	gc_close(gc, ret);
-	t->error = ret;
+	return ret;
 }
 
 static int gc_check_args(int argc, char **argv, struct grab_client *gc)
@@ -266,6 +264,7 @@ static int gc_check_args(int argc, char **argv, struct grab_client *gc)
  * \param fd The file descriptor of the client.
  * \param argc Argument count.
  * \param argv Argument vector.
+ * \param s The scheduler to register the grab client task to.
  *
  * If the command line options given by \a argc and \a argv are valid.
  * allocate a struct grab_client and initialize it with this valid
@@ -276,7 +275,7 @@ static int gc_check_args(int argc, char **argv, struct grab_client *gc)
  *
  * \return Standard.
  */
-int grab_client_new(int fd, int argc, char **argv)
+int grab_client_new(int fd, int argc, char **argv, struct sched *s)
 {
 	int ret;
 	struct grab_client *gc = para_calloc(sizeof(struct grab_client));
@@ -286,7 +285,7 @@ int grab_client_new(int fd, int argc, char **argv)
 		goto err_out;
 	gc->fd = fd;
 	para_list_add(&gc->node, &inactive_grab_client_list);
-	gc_activate(gc);
+	gc_activate(gc, s);
 	return 1;
 err_out:
 	free(gc);