X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=http_recv.c;h=03fca4e11bf519a0202e191b7df704c617fd570b;hp=a913d3a2aaf42850b190f0ad5943db52e2902fd4;hb=69a294cd641c623db61f46ee86901845789a1c7b;hpb=c5e38315901ea63efd169af5d4ba3f3c66db7de9

diff --git a/http_recv.c b/http_recv.c
index a913d3a2..03fca4e1 100644
--- a/http_recv.c
+++ b/http_recv.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2013 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2014 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -7,7 +7,12 @@
 /** \file http_recv.c paraslash's http receiver */
 
 #include <regex.h>
+#include <netinet/in.h>
+#include <sys/socket.h>
 #include <sys/types.h>
+#include <arpa/inet.h>
+#include <sys/un.h>
+#include <netdb.h>
 
 #include "para.h"
 #include "error.h"
@@ -57,10 +62,9 @@ static char *make_request_msg(void)
 
 static void http_recv_pre_select(struct sched *s, struct task *t)
 {
-	struct receiver_node *rn = container_of(t, struct receiver_node, task);
+	struct receiver_node *rn = task_context(t);
 	struct private_http_recv_data *phd = rn->private_data;
 
-	t->error = 0;
 	if (generic_recv_pre_select(s, t) <= 0)
 		return;
 	if  (phd->status == HTTP_CONNECTED)
@@ -74,9 +78,9 @@ static void http_recv_pre_select(struct sched *s, struct task *t)
  * area with data read from the socket. In any case, update the state of the
  * connection if necessary.
  */
-static void http_recv_post_select(struct sched *s, struct task *t)
+static int http_recv_post_select(struct sched *s, struct task *t)
 {
-	struct receiver_node *rn = container_of(t, struct receiver_node, task);
+	struct receiver_node *rn = task_context(t);
 	struct private_http_recv_data *phd = rn->private_data;
 	struct btr_node *btrn = rn->btrn;
 	int ret, iovcnt;
@@ -90,11 +94,11 @@ static void http_recv_post_select(struct sched *s, struct task *t)
 	if (ret < 0)
 		goto out;
 	if (ret == 0)
-		return;
+		return 0;
 	if (phd->status == HTTP_CONNECTED) {
 		char *rq;
 		if (!FD_ISSET(rn->fd, &s->wfds))
-			return;
+			return 0;
 		rq = make_request_msg();
 		PARA_INFO_LOG("sending http request\n");
 		ret = write_va_buffer(rn->fd, "%s", rq);
@@ -102,17 +106,17 @@ static void http_recv_post_select(struct sched *s, struct task *t)
 		if (ret < 0)
 			goto out;
 		phd->status = HTTP_SENT_GET_REQUEST;
-		return;
+		return 0;
 	}
 	if (phd->status == HTTP_SENT_GET_REQUEST) {
 		ret = read_pattern(rn->fd, HTTP_OK_MSG, strlen(HTTP_OK_MSG), &s->rfds);
 		if (ret < 0)
 			goto out;
 		if (ret == 0)
-			return;
+			return 0;
 		PARA_INFO_LOG("received ok msg, streaming\n");
 		phd->status = HTTP_STREAMING;
-		return;
+		return 0;
 	}
 	ret = -E_HTTP_RECV_OVERRUN;
 	iovcnt = btr_pool_get_buffers(rn->btrp, iov);
@@ -128,10 +132,9 @@ static void http_recv_post_select(struct sched *s, struct task *t)
 		btr_add_output_pool(rn->btrp, num_bytes - iov[0].iov_len, btrn);
 	}
 out:
-	if (ret >= 0)
-		return;
-	btr_remove_node(&rn->btrn);
-	t->error = ret;
+	if (ret < 0)
+		btr_remove_node(&rn->btrn);
+	return ret;
 }
 
 static void http_recv_close(struct receiver_node *rn)
@@ -145,10 +148,8 @@ static void *http_recv_parse_config(int argc, char **argv)
 {
 	struct http_recv_args_info *tmp = para_calloc(sizeof(*tmp));
 
-	if (!http_recv_cmdline_parser(argc, argv, tmp))
-		return tmp;
-	free(tmp);
-	return NULL;
+	http_recv_cmdline_parser(argc, argv, tmp);
+	return tmp;
 }
 
 static int http_recv_open(struct receiver_node *rn)
@@ -197,9 +198,6 @@ void http_recv_init(struct receiver *r)
 	r->post_select = http_recv_post_select;
 	r->parse_config = http_recv_parse_config;
 	r->free_config = http_recv_free_config;
-	r->help = (struct ggo_help) {
-		.short_help = http_recv_args_info_help,
-		.detailed_help = http_recv_args_info_detailed_help
-	};
+	r->help = (struct ggo_help)DEFINE_GGO_HELP(http_recv);
 	http_recv_cmdline_parser_free(&dummy);
 }