X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=http_send.c;h=4d612285aeff00f7d8d153be5c9f1743f3fa9425;hp=d692c2d2f3b741f093775bd983d84100bb741644;hb=e2167286448ce2ed9a01a548e7e9832563035088;hpb=2b004fc5dc0c652c6eb4daf84e5875f2c852ca72

diff --git a/http_send.c b/http_send.c
index d692c2d2..4d612285 100644
--- a/http_send.c
+++ b/http_send.c
@@ -16,6 +16,7 @@
 #include "error.h"
 #include "string.h"
 #include "afh.h"
+#include "net.h"
 #include "server.h"
 #include "http.h"
 #include "list.h"
@@ -23,10 +24,8 @@
 #include "sched.h"
 #include "vss.h"
 #include "close_on_fork.h"
-#include "net.h"
 #include "fd.h"
 #include "chunk_queue.h"
-#include "acl.h"
 
 /** Message sent to clients that do not send a valid get request. */
 #define HTTP_ERR_MSG "HTTP/1.0 400 Bad Request\n"
@@ -77,6 +76,12 @@ static void http_shutdown_clients(void)
 	shutdown_clients(hss);
 }
 
+static void http_shutdown(void)
+{
+	http_shutdown_clients();
+	generic_acl_deplete(&hss->acl);
+}
+
 static int queue_chunk_or_shutdown(struct sender_client *sc,
 		struct sender_status *ss, const char *buf, size_t num_bytes)
 {
@@ -236,30 +241,12 @@ static char *http_status(void)
 	return generic_sender_status(hss, "http");
 }
 
-/**
- * The init function of the http sender.
- *
- * \param s Pointer to the http sender struct.
- *
- * It initializes all function pointers of \a s, the client list and the access
- * control list. If the autostart option was given, the tcp port is opened.
+/*
+ * Initialize the client list and the access control list, and optionally
+ * listen on the tcp port.
  */
-void http_send_init(struct sender *s)
+static void http_send_init(void)
 {
-	s->status = http_status;
-	s->send = http_send;
-	s->pre_select = http_pre_select;
-	s->post_select = http_post_select;
-	s->shutdown_clients = http_shutdown_clients;
-	s->resolve_target = NULL;
-	s->help = generic_sender_help;
-	s->client_cmds[SENDER_on] = http_com_on;
-	s->client_cmds[SENDER_off] = http_com_off;
-	s->client_cmds[SENDER_deny] = http_com_deny;
-	s->client_cmds[SENDER_allow] = http_com_allow;
-	s->client_cmds[SENDER_add] = NULL;
-	s->client_cmds[SENDER_delete] = NULL;
-
 	init_sender_status(hss, OPT_RESULT(HTTP_ACCESS),
 		OPT_UINT32_VAL(HTTP_PORT), OPT_UINT32_VAL(HTTP_MAX_CLIENTS),
 		OPT_GIVEN(HTTP_DEFAULT_DENY));
@@ -267,3 +254,31 @@ void http_send_init(struct sender *s)
 		return;
 	generic_com_on(hss, IPPROTO_TCP);
 }
+
+/**
+ * The HTTP sender.
+ *
+ * This is the only sender which does not FEC-encode the stream. This is not
+ * necessary because HTTP sits on top of TCP, a reliable transport which
+ * retransmits lost packets automatically. The sender employs per-client queues
+ * which queue chunks of audio data if they can not be sent immediately because
+ * the write operation would block. Most methods of the sender are implemented
+ * as wrappers for the generic functions defined in \ref send_common.c.
+ */
+const struct sender http_sender = {
+	.name = "http",
+	.init = http_send_init,
+	.shutdown = http_shutdown,
+	.pre_select = http_pre_select,
+	.post_select = http_post_select,
+	.send = http_send,
+	.shutdown_clients = http_shutdown_clients,
+	.client_cmds = {
+		[SENDER_on] = http_com_on,
+		[SENDER_off] = http_com_off,
+		[SENDER_deny] = http_com_deny,
+		[SENDER_allow] = http_com_allow,
+	},
+	.help = generic_sender_help,
+	.status = http_status,
+};