X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=http_send.c;h=ec7c51355fdfad5b695b6a9b2c9a941801cc4570;hp=c1a4fc6af4b72ce20122ef98ec9cf36ce11f1439;hb=57726462f32788fe818d96b9538d98d9598347db;hpb=caaa42217811ca2c3a0e275af9dc99f80b5a8b75 diff --git a/http_send.c b/http_send.c index c1a4fc6a..ec7c5135 100644 --- a/http_send.c +++ b/http_send.c @@ -116,19 +116,37 @@ static int http_send_err_msg(struct http_client *hc) return http_send_msg(hc, HTTP_ERR_MSG); } +/* + * ret: Negative on errors, zero if nothing was written and write returned + * EAGAIN, number of bytes written else. + */ +static int http_write(int fd, const char *buf, size_t len) +{ + size_t written = 0; + + while (written < len) { + int ret = write(fd, buf + written, len - written); + if (ret < 0 && errno == EAGAIN) + return written; + if (ret < 0) + return -ERRNO_TO_PARA_ERROR(errno); + written += ret; + } + return written; +} + + static int send_queued_chunks(struct http_client *hc) { struct queued_chunk *qc; while ((qc = cq_peek(hc->cq))) { char *buf; size_t len; - int ret = write_ok(hc->fd); - if (ret <= 0) - return ret? -E_WRITE_OK : 0; + int ret; cq_get(qc, &buf, &len); - ret = write(hc->fd, buf, len); + ret = http_write(hc->fd, buf, len); if (ret < 0) - return -E_SEND_QUEUED_CHUNK; + return ret; cq_update(hc->cq, ret); if (ret != len) return 1; @@ -258,6 +276,9 @@ static void http_post_select(fd_set *rfds, fd_set *wfds) err_msg = "permission denied"; goto err_out; } + err_msg = "failed to mark fd non-blocking"; + if (mark_fd_nonblocking(hc->fd) < 0) + goto err_out; hc->status = HTTP_CONNECTED; hc->cq = cq_new(MAX_BACKLOG); numclients++; @@ -265,7 +286,6 @@ static void http_post_select(fd_set *rfds, fd_set *wfds) hc->name, hc->fd); para_list_add(&hc->node, &clients); add_close_on_fork_list(hc->fd); - mark_fd_nonblocking(hc->fd); return; err_out: PARA_WARNING_LOG("ignoring connect request from %s (%s)\n",