X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=interactive.c;h=4de81d0d4a394df6d20f5b3a427ee768118e7981;hp=6d30e12aae63503061114e18b3e1fc7b4a118ec8;hb=c0162946c2124d1afd09bc7fc3b0aa4bb386f9f8;hpb=f8931d4607fdf8cb98761b9814d068256d2925a3

diff --git a/interactive.c b/interactive.c
index 6d30e12a..4de81d0d 100644
--- a/interactive.c
+++ b/interactive.c
@@ -1,21 +1,19 @@
 /*
- * Copyright (C) 2011-2013 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2011 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
 
 /** \file interactive.c Readline abstraction for interactive sessions. */
 
+#include "para.h"
+
 #include <regex.h>
-#include <stdbool.h>
-#include <curses.h>
 #include <readline/readline.h>
 #include <readline/history.h>
 #include <sys/ioctl.h>
-#include <assert.h>
 #include <signal.h>
 
-#include "para.h"
 #include "fd.h"
 #include "buffer_tree.h"
 #include "list.h"
@@ -28,8 +26,9 @@ struct i9e_private {
 	struct i9e_client_info *ici;
 	FILE *stderr_stream;
 	int num_columns;
+	int num_key_bindings;
 	char empty_line[1000];
-	struct task task;
+	struct task *task;
 	struct btr_node *stdout_btrn;
 	bool last_write_was_status;
 	bool line_handler_running;
@@ -52,7 +51,7 @@ static struct i9e_private i9e_private, *i9ep = &i9e_private;
  */
 int i9e_get_error(void)
 {
-	return i9ep->task.error;
+	return task_status(i9ep->task);
 }
 
 static bool is_prefix(const char *partial, const char *full, size_t len)
@@ -227,6 +226,7 @@ static void wipe_bottom_line(void)
 	fprintf(i9ep->stderr_stream, "\r");
 }
 
+#ifndef RL_FREE_KEYMAP_DECLARED
 /**
  * Free all storage associated with a keymap.
  *
@@ -237,6 +237,7 @@ static void wipe_bottom_line(void)
  * \param keymap The keymap to deallocate.
  */
 void rl_free_keymap(Keymap keymap);
+#endif
 
 /**
  * Reset the terminal and save the in-memory command line history.
@@ -272,6 +273,7 @@ static void clear_bottom_line(void)
 	rl_redisplay();
 	wipe_bottom_line(); /* wipe out the prompt */
 	rl_insert_text(text);
+	free(text);
 	rl_point = point;
 }
 
@@ -311,7 +313,7 @@ free_line:
 	free(line);
 }
 
-static int i9e_post_select(__a_unused struct sched *s, __a_unused struct task *t)
+static int i9e_post_select(__a_unused struct sched *s, __a_unused void *context)
 {
 	int ret;
 	struct i9e_client_info *ici = i9ep->ici;
@@ -368,7 +370,7 @@ out:
 	return ret;
 }
 
-static void i9e_pre_select(struct sched *s, __a_unused struct task *t)
+static void i9e_pre_select(struct sched *s, __a_unused void *context)
 {
 	int ret;
 
@@ -416,15 +418,17 @@ static void update_winsize(void)
  * Defined key sequences are mapped to keys starting with this offset. I.e.
  * pressing the first defined key sequence yields the key number \p KEY_OFFSET.
  */
-#define KEY_OFFSET 64
-
-static int dispatch_key(__a_unused int count, int key)
+static int dispatch_key(__a_unused int count, __a_unused int key)
 {
-	int ret;
+	int i, ret;
 
-	assert(key >= KEY_OFFSET);
-	ret = i9ep->ici->key_handler(key - KEY_OFFSET);
-	return ret < 0? ret : 0;
+	for (i = i9ep->num_key_bindings - 1; i >= 0; i--) {
+		if (strcmp(rl_executing_keyseq, i9ep->ici->bound_keyseqs[i]))
+			continue;
+		ret = i9ep->ici->key_handler(i);
+		return ret < 0? ret : 0;
+	}
+	assert(0);
 }
 
 /**
@@ -436,7 +440,6 @@ static int dispatch_key(__a_unused int count, int key)
  * The caller must allocate and initialize the structure \a ici points to.
  *
  * \return Standard.
- * \sa \ref register_task().
  */
 int i9e_open(struct i9e_client_info *ici, struct sched *s)
 {
@@ -450,10 +453,13 @@ int i9e_open(struct i9e_client_info *ici, struct sched *s)
 	ret = mark_fd_nonblocking(ici->fds[1]);
 	if (ret < 0)
 		return ret;
-	i9ep->task.pre_select = i9e_pre_select;
-	i9ep->task.post_select = i9e_post_select;
-	sprintf(i9ep->task.status, "i9e");
-	register_task(s, &i9ep->task);
+	i9ep->task = task_register(&(struct task_info) {
+		.name = "i9e",
+		.pre_select = i9e_pre_select,
+		.post_select = i9e_post_select,
+		.context = i9ep,
+	}, s);
+
 	rl_readline_name = "para_i9e";
 	rl_basic_word_break_characters = " ";
 	rl_attempted_completion_function = i9e_completer;
@@ -466,13 +472,11 @@ int i9e_open(struct i9e_client_info *ici, struct sched *s)
 	if (ici->bound_keyseqs) {
 		char *seq;
 		int i;
-		/* FIXME: This is an arbitrary constant.  */
-		for (i = 0; i < 32 && (seq = ici->bound_keyseqs[i]); i++) {
-			char buf[2] = {KEY_OFFSET + i, '\0'};
-			/* readline needs an allocated buffer for the macro */
-			rl_generic_bind(ISMACR, seq, para_strdup(buf), i9ep->bare_km);
-			rl_bind_key_in_map(KEY_OFFSET + i, dispatch_key, i9ep->bare_km);
-		}
+		/* bind each key sequence to the our dispatcher */
+		for (i = 0; (seq = ici->bound_keyseqs[i]); i++)
+			rl_generic_bind(ISFUNC, seq, (char *)dispatch_key,
+				i9ep->bare_km);
+		i9ep->num_key_bindings = i;
 	}
 	if (ici->history_file)
 		read_history(ici->history_file);