X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mood.c;h=54867e582f4f4b1997d7b86dfb0e71cbca67dc24;hp=61332461d7bbed500723452fb956c3dd05cf416b;hb=b90c61663c32cdc6cfc0e78070e2a94a14cb2f8e;hpb=dabdb25fd7fe411933d3639f71a8148b5dc29630

diff --git a/mood.c b/mood.c
index 61332461..54867e58 100644
--- a/mood.c
+++ b/mood.c
@@ -101,7 +101,7 @@ struct mood_item {
 	/** The data structure computed by the mood parser. */
 	void *parser_data;
 	/** The given score value, or zero if none was given. */
-	long score_arg;
+	int32_t score_arg;
 	/** Non-zero if random scoring was requested. */
 	int random_score;
 	/** Whether the "not" keyword was given in the mood line. */
@@ -358,6 +358,11 @@ enum mood_line_type {
 	ML_SCORE
 };
 
+struct mood_line_parser_data {
+	struct mood *m;
+	unsigned line_num;
+};
+
 /*
  * <accept [with score <score>] | deny [with score <score>]  | score <score>>
  * 	[if] [not] <mood_method> [options]
@@ -367,7 +372,7 @@ enum mood_line_type {
 
 static int parse_mood_line(char *mood_line, void *data)
 {
-	struct mood *m = data;
+	struct mood_line_parser_data *mlpd = data;
 	char **argv;
 	char *delim = " \t";
 	unsigned num_words;
@@ -377,6 +382,7 @@ static int parse_mood_line(char *mood_line, void *data)
 	struct mood_item *mi = NULL;
 	char *buf = para_strdup(mood_line);
 
+	mlpd->line_num++;
 	num_words = split_args(buf, &argv, delim);
 	ret = 1;
 	if (!num_words) /* empty line */
@@ -412,7 +418,7 @@ static int parse_mood_line(char *mood_line, void *data)
 			goto out;
 		if (strcmp(*w, "random")) {
 			mi->random_score = 0;
-			ret = para_atol(*w, &mi->score_arg);
+			ret = para_atoi32(*w, &mi->score_arg);
 			if (ret < 0)
 				goto out;
 		} else {
@@ -454,12 +460,14 @@ static int parse_mood_line(char *mood_line, void *data)
 		goto out;
 	mi->method = &mood_methods[i];
 success:
-	if (mlt == ML_ACCEPT)
-		para_list_add(&mi->mood_item_node, &m->accept_list);
-	else if (mlt == ML_DENY)
-		para_list_add(&mi->mood_item_node, &m->deny_list);
-	else
-		para_list_add(&mi->mood_item_node, &m->score_list);
+	if (mlpd->m) {
+		if (mlt == ML_ACCEPT)
+			para_list_add(&mi->mood_item_node, &mlpd->m->accept_list);
+		else if (mlt == ML_DENY)
+			para_list_add(&mi->mood_item_node, &mlpd->m->deny_list);
+		else
+			para_list_add(&mi->mood_item_node, &mlpd->m->score_list);
+	}
 	PARA_DEBUG_LOG("%s entry added, method: %p\n", mlt == ML_ACCEPT? "accept" :
 		(mlt == ML_DENY? "deny" : "score"), mi->method);
 	ret = 1;
@@ -477,33 +485,36 @@ out:
 
 static int load_mood(const struct osl_row *mood_row, struct mood **m)
 {
-	int ret;
-	struct osl_object objs[NUM_BLOB_COLUMNS];
+	char *mood_name;
+	struct osl_object mood_def;
+	struct mood_line_parser_data mlpd = {.line_num = 0};
+	int ret = mood_get_name_and_def_by_row(mood_row, &mood_name, &mood_def);
 
-	ret = osl_get_object(moods_table, mood_row, BLOBCOL_NAME, &objs[BLOBCOL_NAME]);
 	if (ret < 0)
 		return ret;
-	if (objs[BLOBCOL_NAME].size <= 1)
+	if (!*mood_name)
 		return -E_DUMMY_ROW;
-	ret = osl_open_disk_object(moods_table, mood_row, BLOBCOL_DEF, &objs[BLOBCOL_DEF]);
-	if (ret < 0)
-		return ret;
-	*m = alloc_new_mood((char*)objs[BLOBCOL_NAME].data);
-	ret = for_each_line_ro(objs[BLOBCOL_DEF].data, objs[BLOBCOL_DEF].size,
-		parse_mood_line, *m);
-	osl_close_disk_object(&objs[BLOBCOL_DEF]);
+	mlpd.m = alloc_new_mood(mood_name);
+	ret = for_each_line_ro(mood_def.data, mood_def.size,
+		parse_mood_line, &mlpd);
+	osl_close_disk_object(&mood_def);
 	if (ret < 0) {
-		PARA_ERROR_LOG("unable to load mood %s: %s\n", (*m)->name,
+		PARA_ERROR_LOG("unable to load mood %s: %s\n", mlpd.m->name,
 			PARA_STRERROR(-ret));
-		destroy_mood(*m);
+		destroy_mood(mlpd.m);
 		return ret;
 	}
-	PARA_INFO_LOG("loaded mood %s\n", (*m)->name);
+	PARA_INFO_LOG("loaded mood %s\n", mlpd.m->name);
+	*m = mlpd.m;
 	return 1;
 }
 
-/* returns -E_MOOD_LOADED on _success_ to terminate the loop */
-static int mood_loop(struct osl_row *mood_row, void *data)
+/*
+ * Calls load_mood() and reverts its error value: It returns -E_MOOD_LOADED
+ * on _success_, and 1 on errors. This way the loop over all moods stops at the
+ * first valid mood.
+ */
+static int load_mood_loop_func(struct osl_row *mood_row, void *data)
 {
 	struct mood **m = data;
 	int ret = load_mood(mood_row, m);
@@ -518,7 +529,7 @@ static int mood_loop(struct osl_row *mood_row, void *data)
 static int load_first_available_mood(struct mood **m)
 {
 	int ret = osl_rbtree_loop(moods_table, BLOBCOL_NAME, m,
-		mood_loop);
+		load_mood_loop_func);
 	if (ret == -E_MOOD_LOADED) /* success */
 		return 1;
 	if (ret < 0)
@@ -527,6 +538,51 @@ static int load_first_available_mood(struct mood **m)
 	return -E_NO_MOOD;
 }
 
+static int check_mood(struct osl_row *mood_row, void *data)
+{
+	struct para_buffer *pb = data;
+	char *mood_name;
+	struct osl_object mood_def;
+	struct mood_line_parser_data mlpd = {.line_num = 0};
+
+	int ret = mood_get_name_and_def_by_row(mood_row, &mood_name, &mood_def);
+
+	if (ret < 0) {
+		para_printf(pb, "failed to get mood definition\n");
+		return ret;
+	}
+	if (!*mood_name) /* ignore dummy row */
+		goto out;
+	para_printf(pb, "checking mood %s...\n", mood_name);
+	ret = for_each_line_ro(mood_def.data, mood_def.size,
+		parse_mood_line, &mlpd);
+	if (ret < 0)
+		para_printf(pb, "%s line %u: %s\n", mood_name, mlpd.line_num,
+			PARA_STRERROR(-ret));
+out:
+	osl_close_disk_object(&mood_def);
+	return 1;
+}
+
+/**
+ * Check all moods for syntax errors.
+ *
+ * \param query Unused.
+ * \param result: Contains check messages.
+ */
+int mood_check_callback(__a_unused const struct osl_object *query,
+	struct osl_object *result)
+{
+	struct para_buffer pb = {.buf = NULL};
+
+	para_printf(&pb, "checking moods...\n");
+	osl_rbtree_loop(moods_table, BLOBCOL_ID, &pb,
+		check_mood);
+	result->data = pb.buf;
+	result->size = pb.size;
+	return 1;
+}
+
 #if 0
 static unsigned int_log2(uint64_t x)
 {