X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mp3_afh.c;h=70f2ec9f6b3817887799edab3292f7136aec0a84;hp=484172abe6e28345073f339623f5219c390b58ce;hb=3ea5399aeec092dcdb9f039288f1e146aadbb2f7;hpb=30e8f0c610f0f3279475197e70e3be62af5cfcc9

diff --git a/mp3_afh.c b/mp3_afh.c
index 484172ab..70f2ec9f 100644
--- a/mp3_afh.c
+++ b/mp3_afh.c
@@ -300,6 +300,9 @@ static int replace_tags(struct id3_tag *id3_t, struct taginfo *tags)
 static void free_tag(struct id3_tag *id3_t)
 {
 	int i, j;
+
+	if (!id3_t)
+		return;
 	for (i = 0; i < id3_t->nframes; i++) {
 		struct id3_frame *fr = id3_t->frames[i];
 		for (j = 0; j < fr->nfields; j++) {
@@ -337,29 +340,27 @@ static int mp3_rewrite_tags(const char *map, size_t mapsize,
 	if (v2_tag) {
 		PARA_NOTICE_LOG("replacing id3v2 tag\n");
 		old_v2size = v2_tag->paddedsize;
-	} else if (!v1_tag) {
-		PARA_NOTICE_LOG("no id3 tags found, adding id3v2 tag\n");
+	} else {
+		PARA_NOTICE_LOG("adding id3v2 tag\n");
 		v2_tag = id3_tag_new();
 		assert(v2_tag);
 	}
-	if (v2_tag) {
-		/*
-		 * Turn off all options to avoid creating an extended header.
-		 * id321 does not understand it.
-		 */
-		id3_tag_options(v2_tag, ~0U, 0);
-		ret = replace_tags(v2_tag, tags);
-		if (ret < 0)
-			goto out;
-		new_v2size = id3_tag_render(v2_tag, NULL);
-		v2_buffer = para_malloc(new_v2size);
-		id3_tag_render(v2_tag, v2_buffer);
-		PARA_INFO_LOG("writing v2 tag (%lu bytes)\n", new_v2size);
-		ret = write_all(fd, (char *)v2_buffer, new_v2size);
-		free(v2_buffer);
-		if (ret < 0)
-			goto out;
-	}
+	/*
+	 * Turn off all options to avoid creating an extended header.  id321
+	 * does not understand it.
+	 */
+	id3_tag_options(v2_tag, ~0U, 0);
+	ret = replace_tags(v2_tag, tags);
+	if (ret < 0)
+		goto out;
+	new_v2size = id3_tag_render(v2_tag, NULL);
+	v2_buffer = para_malloc(new_v2size);
+	id3_tag_render(v2_tag, v2_buffer);
+	PARA_INFO_LOG("writing v2 tag (%lu bytes)\n", new_v2size);
+	ret = write_all(fd, (char *)v2_buffer, new_v2size);
+	free(v2_buffer);
+	if (ret < 0)
+		goto out;
 	data_sz = mapsize - old_v2size;
 	if (v1_tag && data_sz >= 128)
 		data_sz -= 128;
@@ -372,10 +373,8 @@ static int mp3_rewrite_tags(const char *map, size_t mapsize,
 		ret = write_all(fd, (char *)v1_buffer, 128);
 	}
 out:
-	if (v1_tag)
-		free_tag(v1_tag);
-	if (v2_tag)
-		free_tag(v2_tag);
+	free_tag(v1_tag);
+	free_tag(v2_tag);
 	return ret;
 }
 
@@ -656,14 +655,13 @@ static int mp3_read_info(unsigned char *map, size_t numbytes, int fd,
 	afhi->channels = header_channels(&header);
 	afhi->seconds_total = (tv2ms(&total_time) + 500) / 1000;
 	tv_divide(afhi->chunks_total, &total_time, &afhi->chunk_tv);
-	PARA_DEBUG_LOG("%lu chunks, each %lums\n", afhi->chunks_total,
+	PARA_DEBUG_LOG("%" PRIu32 "chunks, each %lums\n", afhi->chunks_total,
 		tv2ms(&afhi->chunk_tv));
 	ret = mp3_get_id3(map, numbytes, fd, &afhi->tags);
 	afhi->techinfo = make_message("%cbr, %s, %s tags", vbr? 'v' : 'c',
 		header_mode(&header), tag_versions[ret]);
 	return 1;
 err_out:
-	PARA_ERROR_LOG("%s\n", para_strerror(-ret));
 	free(afhi->chunk_table);
 	return ret;
 }
@@ -684,7 +682,7 @@ static int mp3_get_file_info(char *map, size_t numbytes, int fd,
 	return 1;
 }
 
-static const char* mp3_suffixes[] = {"mp3", NULL};
+static const char * const mp3_suffixes[] = {"mp3", NULL};
 
 /**
  * the init function of the mp3 audio format handler