X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mp3_afh.c;h=ae7f117bfaeac1841c6883388a4b2e16c7a31a97;hp=8ca319b4705c9c12492ef2f26a418affb4cd39c3;hb=ba30bb8d0bb025c0dad80e5ff47352b4bc130423;hpb=095fc31c48324112a71602ba6975d9d33cf4378e diff --git a/mp3_afh.c b/mp3_afh.c index 8ca319b4..ae7f117b 100644 --- a/mp3_afh.c +++ b/mp3_afh.c @@ -1,19 +1,7 @@ /* * Copyright (C) 2003-2007 Andre Noll * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Licensed under the GPL v2. For licencing details see COPYING. */ /** \file mp3_afh.c para_server's mp3 audio format handler */ @@ -28,6 +16,8 @@ * Johannes Overmann */ +#include "para.h" +#include "afh.h" #include "server.h" #include "error.h" #include "string.h" @@ -122,7 +112,7 @@ static int header_channels(struct mp3header *h) static int header_bitrate(struct mp3header *h) { - if (h->layer > 3 || h->bitrate > 14) + if (!h->layer || h->layer > 3 || h->bitrate > 14 || !h->bitrate) return -E_HEADER_BITRATE; return mp3info_bitrate[h->version & 1][3 - h->layer][h->bitrate - 1]; } @@ -200,7 +190,7 @@ static int compare_headers(struct mp3header *h1,struct mp3header *h2) * retrieve a valid frame header, and a negative return value indicates an * error. */ -static int get_header(unsigned char *map, off_t numbytes, off_t *fpos, +static int get_header(unsigned char *map, size_t numbytes, off_t *fpos, struct mp3header *header) { int fl, ret; @@ -239,7 +229,7 @@ out: * Return the length of the next frame header or zero if the end of the file is * reached. */ -static int mp3_seek_next_header(unsigned char *map, off_t numbytes, off_t *fpos) +static int mp3_seek_next_header(unsigned char *map, size_t numbytes, off_t *fpos) { int k, l = 0, first_len; struct mp3header h, h2; @@ -269,7 +259,7 @@ static int mp3_seek_next_header(unsigned char *map, off_t numbytes, off_t *fpos) return 0; } -static void mp3_get_id3(unsigned char *map, off_t numbytes, off_t *fpos) +static void mp3_get_id3(unsigned char *map, size_t numbytes, off_t *fpos) { mp3.id3_isvalid = 0; mp3.id3.title[0] = '\0'; @@ -280,8 +270,8 @@ static void mp3_get_id3(unsigned char *map, off_t numbytes, off_t *fpos) if (numbytes < 128) return; *fpos = numbytes - 128; - if (strncmp("TAG", map + *fpos, 3)) { - PARA_INFO_LOG("%s", "no id3 tag\n"); + if (strncmp("TAG", (char *) map + *fpos, 3)) { + PARA_DEBUG_LOG("%s", "no id3 tag\n"); return; } *fpos = numbytes - 125; @@ -307,7 +297,7 @@ static void mp3_get_id3(unsigned char *map, off_t numbytes, off_t *fpos) unpad(mp3.id3.comment); } -static int find_valid_start(unsigned char *map, off_t numbytes, off_t *fpos) +static int find_valid_start(unsigned char *map, size_t numbytes, off_t *fpos) { int frame_len; @@ -325,7 +315,7 @@ static int find_valid_start(unsigned char *map, off_t numbytes, off_t *fpos) return frame_len; } -static int mp3_read_info(unsigned char *map, off_t numbytes, +static int mp3_read_info(unsigned char *map, size_t numbytes, struct audio_format_info *afi) { long fl_avg = 0, freq_avg = 0, br_avg = 0; @@ -340,17 +330,24 @@ static int mp3_read_info(unsigned char *map, off_t numbytes, fpos = 0; mp3.vbr = 0; while (1) { - int freq, br, fl; + unsigned long freq, br, fl; struct timeval tmp, cct; /* current chunk time */ fpos += len; len = find_valid_start(map, numbytes, &fpos); if (len <= 0) break; - freq = header_frequency(&mp3.header); - br = header_bitrate(&mp3.header); - fl = frame_length(&mp3.header); - if (freq < 0 || br < 0 || fl < 0) + ret = header_frequency(&mp3.header); + if (ret < 0) + continue; + freq = ret; + ret = header_bitrate(&mp3.header); + if (ret < 0) + continue; + br = ret; + ret = frame_length(&mp3.header); + if (ret < 0) continue; + fl = ret; tmp.tv_sec = fl; tmp.tv_usec = 0; tv_divide(br * 125, &tmp, &cct); @@ -374,9 +371,9 @@ static int mp3_read_info(unsigned char *map, off_t numbytes, fl_avg = fl; continue; } - freq_avg += (freq - freq_avg) / (afi->chunks_total + 1); - fl_avg += (fl - fl_avg) / (afi->chunks_total + 1); - br_avg += (br - br_avg) / ((long)afi->chunks_total + 1); + freq_avg += ((long)freq - freq_avg) / ((long)afi->chunks_total + 1); + fl_avg += ((long)fl - fl_avg) / ((long)afi->chunks_total + 1); + br_avg += ((long)br - br_avg) / ((long)afi->chunks_total + 1); if (old_br != br) mp3.vbr = 1; old_br = br; @@ -404,7 +401,7 @@ err_out: /* * Read mp3 information from audio file */ -static int mp3_get_file_info(char *map, off_t numbytes, +int mp3_get_file_info(char *map, size_t numbytes, struct audio_format_info *afi) { int ret;