X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mp3dec_filter.c;h=33c0dfc9f7d5019484a17f97a47064fb75798358;hp=bd1f0d35dbc0fe54a75c25e59beae3bc07cd5f3c;hb=1e97f6746b605e37826fb6ee2ad35b7b330145d6;hpb=f652ce6afe7f6fd0e42814505234cbf4321a736e

diff --git a/mp3dec_filter.c b/mp3dec_filter.c
index bd1f0d35..33c0dfc9 100644
--- a/mp3dec_filter.c
+++ b/mp3dec_filter.c
@@ -77,7 +77,7 @@ static void mp3dec_close(struct filter_node *fn)
 
 #define MP3DEC_MAX_FRAME 8192
 
-static void mp3dec_post_select(__a_unused struct sched *s, struct task *t)
+static int mp3dec_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct filter_node *fn = container_of(t, struct filter_node, task);
 	int i, ret;
@@ -88,13 +88,12 @@ static void mp3dec_post_select(__a_unused struct sched *s, struct task *t)
 
 next_buffer:
 	pmd->stream.error = 0;
-	t->error = 0;
 	iqs = btr_get_input_queue_size(btrn);
 	ret = btr_node_status(btrn, fn->min_iqs, BTR_NT_INTERNAL);
 	if (ret < 0)
 		goto err;
 	if (ret == 0)
-		return;
+		return 0;
 	btr_merge(btrn, fn->min_iqs);
 	len = btr_next_buffer(btrn, &inbuffer);
 	/*
@@ -120,7 +119,7 @@ next_frame:
 		}
 		if (loaded == 0)
 			goto next_buffer;
-		return;
+		return 0;
 	}
 	pmd->sample_rate = pmd->frame.header.samplerate;
 	pmd->channels = MAD_NCHANNELS(&pmd->frame.header);
@@ -140,12 +139,12 @@ decode:
 			if (fn->min_iqs > MP3DEC_MAX_FRAME)
 				goto err;
 			mp3dec_consume(btrn, &pmd->stream, len);
-			return;
+			return 0;
 		}
 		if (pmd->stream.error != MAD_ERROR_BADDATAPTR)
 			goto decode;
 		mp3dec_consume(btrn, &pmd->stream, len);
-		return;
+		return 0;
 	}
 	fn->min_iqs = 0;
 	mad_synth_frame(&pmd->synth, &pmd->frame);
@@ -165,8 +164,8 @@ decode:
 	goto next_frame;
 err:
 	assert(ret < 0);
-	t->error = ret;
 	btr_remove_node(&fn->btrn);
+	return ret;
 }
 
 static void mp3dec_open(struct filter_node *fn)
@@ -222,8 +221,5 @@ void mp3dec_filter_init(struct filter *f)
 	f->pre_select = generic_filter_pre_select;
 	f->post_select = mp3dec_post_select;
 	f->execute = mp3dec_execute;
-	f->help = (struct ggo_help) {
-		.short_help = mp3dec_filter_args_info_help,
-		.detailed_help = mp3dec_filter_args_info_detailed_help
-	};
+	f->help = (struct ggo_help)DEFINE_GGO_HELP(mp3dec_filter);
 }