X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mp3dec_filter.c;h=b053aaa8f3fd33171aca682fe53dd85906bcca11;hp=4bdbc6fd5dc84b6fd73e7678dd04affba1eb6c4b;hb=e79198e9851faddfd64e47654b5bc66fbc574255;hpb=1cefe6a503c74d609db4e99e689d46575a5e40fd

diff --git a/mp3dec_filter.c b/mp3dec_filter.c
index 4bdbc6fd..b053aaa8 100644
--- a/mp3dec_filter.c
+++ b/mp3dec_filter.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2012 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -8,12 +8,12 @@
 
 #include <mad.h>
 #include <regex.h>
+#include <lopsub.h>
 
+#include "filter_cmd.lsg.h"
 #include "para.h"
-#include "mp3dec_filter.cmdline.h"
 #include "list.h"
 #include "sched.h"
-#include "ggo.h"
 #include "buffer_tree.h"
 #include "filter.h"
 #include "error.h"
@@ -77,9 +77,9 @@ static void mp3dec_close(struct filter_node *fn)
 
 #define MP3DEC_MAX_FRAME 8192
 
-static void mp3dec_post_select(__a_unused struct sched *s, struct task *t)
+static int mp3dec_post_select(__a_unused struct sched *s, void *context)
 {
-	struct filter_node *fn = container_of(t, struct filter_node, task);
+	struct filter_node *fn = context;
 	int i, ret;
 	struct private_mp3dec_data *pmd = fn->private_data;
 	struct btr_node *btrn = fn->btrn;
@@ -88,13 +88,12 @@ static void mp3dec_post_select(__a_unused struct sched *s, struct task *t)
 
 next_buffer:
 	pmd->stream.error = 0;
-	t->error = 0;
 	iqs = btr_get_input_queue_size(btrn);
 	ret = btr_node_status(btrn, fn->min_iqs, BTR_NT_INTERNAL);
 	if (ret < 0)
 		goto err;
 	if (ret == 0)
-		return;
+		return 0;
 	btr_merge(btrn, fn->min_iqs);
 	len = btr_next_buffer(btrn, &inbuffer);
 	/*
@@ -120,7 +119,7 @@ next_frame:
 		}
 		if (loaded == 0)
 			goto next_buffer;
-		return;
+		return 0;
 	}
 	pmd->sample_rate = pmd->frame.header.samplerate;
 	pmd->channels = MAD_NCHANNELS(&pmd->frame.header);
@@ -130,7 +129,7 @@ decode:
 		ret = handle_decode_error(pmd);
 		if (ret < 0)
 			goto err;
-		ret = mad_stream_sync(&pmd->stream);
+		mad_stream_sync(&pmd->stream);
 		if (pmd->stream.error == MAD_ERROR_BUFLEN) {
 			ret = -E_MP3DEC_EOF;
 			if (len == iqs && btr_no_parent(btrn))
@@ -140,12 +139,12 @@ decode:
 			if (fn->min_iqs > MP3DEC_MAX_FRAME)
 				goto err;
 			mp3dec_consume(btrn, &pmd->stream, len);
-			return;
+			return 0;
 		}
 		if (pmd->stream.error != MAD_ERROR_BADDATAPTR)
 			goto decode;
 		mp3dec_consume(btrn, &pmd->stream, len);
-		return;
+		return 0;
 	}
 	fn->min_iqs = 0;
 	mad_synth_frame(&pmd->synth, &pmd->frame);
@@ -165,39 +164,22 @@ decode:
 	goto next_frame;
 err:
 	assert(ret < 0);
-	t->error = ret;
-	btr_remove_node(btrn);
+	btr_remove_node(&fn->btrn);
+	return ret;
 }
 
 static void mp3dec_open(struct filter_node *fn)
 {
 	struct private_mp3dec_data *pmd = para_calloc(sizeof(*pmd));
-	struct mp3dec_filter_args_info *mp3_conf = fn->conf;
 
 	fn->private_data = pmd;
 	mad_stream_init(&pmd->stream);
 	mad_frame_init(&pmd->frame);
 	mad_synth_init(&pmd->synth);
-	if (mp3_conf->ignore_crc_given)
+	if (FILTER_CMD_OPT_GIVEN(MP3DEC, IGNORE_CRC, fn->lpr))
 		mad_stream_options(&pmd->stream, MAD_OPTION_IGNORECRC);
 }
 
-static int mp3dec_parse_config(int argc, char **argv, void **config)
-{
-	int ret;
-	struct mp3dec_filter_args_info *mp3_conf;
-
-	mp3_conf = para_calloc(sizeof(*mp3_conf));
-	ret = -E_MP3DEC_SYNTAX;
-	if (mp3dec_cmdline_parser(argc, argv, mp3_conf))
-		goto err;
-	*config = mp3_conf;
-	return 1;
-err:
-	free(mp3_conf);
-	return ret;
-}
-
 static int mp3dec_execute(struct btr_node *btrn, const char *cmd, char **result)
 {
 	struct filter_node *fn = btr_context(btrn);
@@ -206,31 +188,10 @@ static int mp3dec_execute(struct btr_node *btrn, const char *cmd, char **result)
 	return decoder_execute(cmd, pmd->sample_rate, pmd->channels, result);
 }
 
-static void mp3dec_free_config(void *conf)
-{
-	mp3dec_cmdline_parser_free(conf);
-}
-/**
- * The init function of the mp3dec filter.
- *
- * \param f Pointer to the filter struct to initialize.
- *
- * \sa filter::init.
- */
-void mp3dec_filter_init(struct filter *f)
-{
-	struct mp3dec_filter_args_info dummy;
-
-	mp3dec_cmdline_parser_init(&dummy);
-	f->open = mp3dec_open;
-	f->close = mp3dec_close;
-	f->parse_config = mp3dec_parse_config;
-	f->free_config = mp3dec_free_config;
-	f->pre_select = generic_filter_pre_select;
-	f->post_select = mp3dec_post_select;
-	f->execute = mp3dec_execute;
-	f->help = (struct ggo_help) {
-		.short_help = mp3dec_filter_args_info_help,
-		.detailed_help = mp3dec_filter_args_info_detailed_help
-	};
-}
+const struct filter lsg_filter_cmd_com_mp3dec_user_data = {
+	.open = mp3dec_open,
+	.close = mp3dec_close,
+	.pre_select = generic_filter_pre_select,
+	.post_select = mp3dec_post_select,
+	.execute = mp3dec_execute,
+};