X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mp3dec_filter.c;h=b053aaa8f3fd33171aca682fe53dd85906bcca11;hp=aceee9ae686666583f5b6a3bfbbc515cbc4c6328;hb=b1206644af64376f11877f14fa9f9dd3c30f8e4b;hpb=f74525557a0f63090de04fcb2ad401db0783f9a3

diff --git a/mp3dec_filter.c b/mp3dec_filter.c
index aceee9ae..b053aaa8 100644
--- a/mp3dec_filter.c
+++ b/mp3dec_filter.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2009 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005 Andre Noll <maan@tuebingen.mpg.de>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -8,12 +8,13 @@
 
 #include <mad.h>
 #include <regex.h>
+#include <lopsub.h>
 
+#include "filter_cmd.lsg.h"
 #include "para.h"
-#include "mp3dec_filter.cmdline.h"
 #include "list.h"
 #include "sched.h"
-#include "ggo.h"
+#include "buffer_tree.h"
 #include "filter.h"
 #include "error.h"
 #include "string.h"
@@ -30,67 +31,36 @@ struct private_mp3dec_data {
 	struct mad_frame frame;
 	/** Contains the PCM output. */
 	struct mad_synth synth;
+	/** The number of channels of the current stream. */
+	unsigned int channels;
+	/** Current sample rate in Hz. */
+	unsigned int sample_rate;
 };
 
-static ssize_t mp3dec(char *inbuffer, size_t len, struct filter_node *fn)
+/* Returns negative on serious errors. */
+static int handle_decode_error(struct private_mp3dec_data *pmd)
 {
-	int i, ret;
-	struct private_mp3dec_data *pmd = fn->private_data;
-	size_t copy = PARA_MIN(len, (size_t)4096);
-
-	if (fn->loaded + 16384 > fn->bufsize)
-		return 0;
-	mad_stream_buffer(&pmd->stream, (unsigned char *) inbuffer, copy);
-	pmd->stream.error = 0;
-next_frame:
-	ret = mad_header_decode(&pmd->frame.header, &pmd->stream);
-	if (ret < 0) {
-		if (pmd->stream.error != MAD_ERROR_BUFLEN &&
-			pmd->stream.error != MAD_ERROR_LOSTSYNC)
-			PARA_DEBUG_LOG("header decode: %s\n",
-				mad_stream_errorstr(&pmd->stream));
-		goto out;
-	}
-	fn->fc->samplerate = pmd->frame.header.samplerate;
-	fn->fc->channels = MAD_NCHANNELS(&pmd->frame.header);
-	ret = mad_frame_decode(&pmd->frame, &pmd->stream);
-	if (ret) {
-		if (MAD_RECOVERABLE(pmd->stream.error) ||
-			pmd->stream.error == MAD_ERROR_BUFLEN) {
-			PARA_DEBUG_LOG("frame decode: %s\n",
-				mad_stream_errorstr(&pmd->stream));
-			goto out;
-		}
-		PARA_ERROR_LOG("frame decode: %s\n",
-			mad_stream_errorstr(&pmd->stream));
+	if (!MAD_RECOVERABLE(pmd->stream.error)
+			&& pmd->stream.error != MAD_ERROR_BUFLEN) {
+		PARA_ERROR_LOG("%s\n", mad_stream_errorstr(&pmd->stream));
 		return -E_MAD_FRAME_DECODE;
 	}
-	mad_synth_frame(&pmd->synth, &pmd->frame);
+	PARA_DEBUG_LOG("%s\n", mad_stream_errorstr(&pmd->stream));
+	return 0;
+}
 
-	for (i = 0; i < pmd->synth.pcm.length; i++) {
-		int s = MAD_TO_SHORT(pmd->synth.pcm.samples[0][i]);
-		write_int16_host_endian(fn->buf + fn->loaded, s);
-		fn->loaded += 2;
-		if (MAD_NCHANNELS(&pmd->frame.header) == 2) { /* stereo */
-			s = MAD_TO_SHORT(pmd->synth.pcm.samples[1][i]);
-			write_int16_host_endian(fn->buf + fn->loaded, s);
-			fn->loaded += 2;
-		}
-		if (fn->loaded != fn->bufsize) /* output buffer not full */
-			continue;
-		PARA_ERROR_LOG("output buffer full: %zd\n", fn->loaded);
-			return -E_MP3DEC_OVERRUN;
-	}
-	if (fn->loaded + 16384 <= fn->bufsize)
-		goto next_frame;
-out:
-	if (pmd->stream.next_frame) { /* we still have some data */
-		size_t off = pmd->stream.bufend - pmd->stream.next_frame;
-		if (fn->loaded + 16384 <= fn->bufsize && off > 2048)
-			goto next_frame;
-		return copy - off;
+static void mp3dec_consume(struct btr_node *btrn, struct mad_stream *s,
+		size_t max)
+{
+	size_t used;
+
+	if (!s->next_frame)
+		used = max;
+	else { /* we still have some data */
+		used = s->next_frame - s->buffer;
+		assert(used <= max);
 	}
-	return copy;
+	btr_consume(btrn, used);
 }
 
 static void mp3dec_close(struct filter_node *fn)
@@ -101,67 +71,127 @@ static void mp3dec_close(struct filter_node *fn)
 	mad_frame_finish(&pmd->frame);
 	mad_stream_finish(&pmd->stream);
 
-	free(fn->buf);
-	fn->buf = NULL;
 	free(pmd);
 	fn->private_data = NULL;
 }
 
+#define MP3DEC_MAX_FRAME 8192
+
+static int mp3dec_post_select(__a_unused struct sched *s, void *context)
+{
+	struct filter_node *fn = context;
+	int i, ret;
+	struct private_mp3dec_data *pmd = fn->private_data;
+	struct btr_node *btrn = fn->btrn;
+	size_t loaded = 0, len, iqs;
+	char *inbuffer, *outbuffer;
+
+next_buffer:
+	pmd->stream.error = 0;
+	iqs = btr_get_input_queue_size(btrn);
+	ret = btr_node_status(btrn, fn->min_iqs, BTR_NT_INTERNAL);
+	if (ret < 0)
+		goto err;
+	if (ret == 0)
+		return 0;
+	btr_merge(btrn, fn->min_iqs);
+	len = btr_next_buffer(btrn, &inbuffer);
+	/*
+	 * Decode at most 8K in one go to give the post_select() functions of
+	 * other buffer tree nodes a chance to run. This is necessary to avoid
+	 * buffer underruns on slow machines.
+	 */
+	len = PARA_MIN(len, (size_t)MP3DEC_MAX_FRAME);
+	mad_stream_buffer(&pmd->stream, (unsigned char *)inbuffer, len);
+next_frame:
+	ret = mad_header_decode(&pmd->frame.header, &pmd->stream);
+	if (ret < 0) {
+		mp3dec_consume(btrn, &pmd->stream, len);
+		if (pmd->stream.error == MAD_ERROR_BUFLEN) {
+			if (len == iqs && btr_no_parent(btrn)) {
+				ret = -E_MP3DEC_EOF;
+				goto err;
+			}
+			fn->min_iqs += 100;
+			ret = -E_MP3DEC_CORRUPT;
+			if (fn->min_iqs > MP3DEC_MAX_FRAME)
+				goto err;
+		}
+		if (loaded == 0)
+			goto next_buffer;
+		return 0;
+	}
+	pmd->sample_rate = pmd->frame.header.samplerate;
+	pmd->channels = MAD_NCHANNELS(&pmd->frame.header);
+decode:
+	ret = mad_frame_decode(&pmd->frame, &pmd->stream);
+	if (ret != 0) {
+		ret = handle_decode_error(pmd);
+		if (ret < 0)
+			goto err;
+		mad_stream_sync(&pmd->stream);
+		if (pmd->stream.error == MAD_ERROR_BUFLEN) {
+			ret = -E_MP3DEC_EOF;
+			if (len == iqs && btr_no_parent(btrn))
+				goto err;
+			fn->min_iqs += 100;
+			ret = -E_MP3DEC_CORRUPT;
+			if (fn->min_iqs > MP3DEC_MAX_FRAME)
+				goto err;
+			mp3dec_consume(btrn, &pmd->stream, len);
+			return 0;
+		}
+		if (pmd->stream.error != MAD_ERROR_BADDATAPTR)
+			goto decode;
+		mp3dec_consume(btrn, &pmd->stream, len);
+		return 0;
+	}
+	fn->min_iqs = 0;
+	mad_synth_frame(&pmd->synth, &pmd->frame);
+	outbuffer = para_malloc(pmd->synth.pcm.length * 2 * pmd->channels);
+	loaded = 0;
+	for (i = 0; i < pmd->synth.pcm.length; i++) {
+		int sample = MAD_TO_SHORT(pmd->synth.pcm.samples[0][i]);
+		write_int16_host_endian(outbuffer + loaded, sample);
+		loaded += 2;
+		if (pmd->channels == 2) { /* stereo */
+			sample = MAD_TO_SHORT(pmd->synth.pcm.samples[1][i]);
+			write_int16_host_endian(outbuffer + loaded, sample);
+			loaded += 2;
+		}
+	}
+	btr_add_output(outbuffer, loaded, btrn);
+	goto next_frame;
+err:
+	assert(ret < 0);
+	btr_remove_node(&fn->btrn);
+	return ret;
+}
+
 static void mp3dec_open(struct filter_node *fn)
 {
 	struct private_mp3dec_data *pmd = para_calloc(sizeof(*pmd));
-	struct mp3dec_filter_args_info *mp3_conf = fn->conf;
 
 	fn->private_data = pmd;
 	mad_stream_init(&pmd->stream);
 	mad_frame_init(&pmd->frame);
 	mad_synth_init(&pmd->synth);
-	fn->loaded = 0;
-	fn->bufsize = mp3_conf->bufsize_arg * 1024;
-	fn->buf = para_calloc(fn->bufsize);
-	if (mp3_conf->ignore_crc_given)
+	if (FILTER_CMD_OPT_GIVEN(MP3DEC, IGNORE_CRC, fn->lpr))
 		mad_stream_options(&pmd->stream, MAD_OPTION_IGNORECRC);
 }
 
-static int mp3dec_parse_config(int argc, char **argv, void **config)
+static int mp3dec_execute(struct btr_node *btrn, const char *cmd, char **result)
 {
-	int ret;
-	struct mp3dec_filter_args_info *mp3_conf;
+	struct filter_node *fn = btr_context(btrn);
+	struct private_mp3dec_data *pmd = fn->private_data;
 
-	mp3_conf = para_calloc(sizeof(*mp3_conf));
-	ret = -E_MP3DEC_SYNTAX;
-	if (mp3dec_cmdline_parser(argc, argv, mp3_conf))
-		goto err;
-	ret = -ERRNO_TO_PARA_ERROR(EINVAL);
-	if (mp3_conf->bufsize_arg < 32)
-		goto err;
-	if (mp3_conf->bufsize_arg >= INT_MAX / 1024)
-		goto err;
-	*config = mp3_conf;
-	return 1;
-err:
-	free(mp3_conf);
-	return ret;
+	return decoder_execute(cmd, pmd->sample_rate, pmd->channels, result);
 }
 
-/**
- * The init function of the mp3dec filter.
- *
- * \param f Pointer to the filter struct to initialize.
- *
- * \sa filter::init.
- */
-void mp3dec_filter_init(struct filter *f)
-{
-	struct mp3dec_filter_args_info dummy;
-
-	mp3dec_cmdline_parser_init(&dummy);
-	f->open = mp3dec_open;
-	f->convert = mp3dec;
-	f->close = mp3dec_close;
-	f->parse_config = mp3dec_parse_config;
-	f->help = (struct ggo_help) {
-		.short_help = mp3dec_filter_args_info_help,
-		.detailed_help = mp3dec_filter_args_info_detailed_help
-	};
-}
+const struct filter lsg_filter_cmd_com_mp3dec_user_data = {
+	.open = mp3dec_open,
+	.close = mp3dec_close,
+	.pre_select = generic_filter_pre_select,
+	.post_select = mp3dec_post_select,
+	.execute = mp3dec_execute,
+};