X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=mysql_selector.c;h=e2c9562c7aa64bb14e4f5f4830ca0117130aaa63;hp=ff94d8d7c26e5cc8fcd1095a6e1eb85e17c3a348;hb=95491e280363ddaed05599445138fd8191110dc1;hpb=e0e5a7c1a04c6a2ee4a475e823657e06e6df2f99

diff --git a/mysql_selector.c b/mysql_selector.c
index ff94d8d7..e2c9562c 100644
--- a/mysql_selector.c
+++ b/mysql_selector.c
@@ -663,7 +663,7 @@ out:
 	return ret;
 }
 
-static char *escape_blob(char* old, int size)
+static char *escape_blob(const char* old, int size)
 {
 	char *new;
 
@@ -674,7 +674,7 @@ static char *escape_blob(char* old, int size)
 	return new;
 }
 
-static char *escape_str(char* old)
+static char *escape_str(const char* old)
 {
 	return escape_blob(old, strlen(old));
 }
@@ -1840,10 +1840,10 @@ static int update_audio_file(char *name)
 	ret = real_query(q);
 	free(q);
 out:
-	if (ebn)
-		free(ebn);
+	free(ebn);
 	return ret;
 }
+
 /* If called as child, mmd_lock must be held */
 static void update_mmd(char *info)
 {
@@ -2321,7 +2321,6 @@ static int mysql_write_tmp_file(const char *dir, const char *name)
 {
 	int ret = -E_TMPFILE;
 	char *msg = make_message("%s\t%s\n", dir, name);
-
 	if (fputs(msg, out_file) != EOF)
 		ret = 1;
 	free(msg);
@@ -2366,7 +2365,7 @@ static int com_upd(int fd, int argc, __a_unused char *argv[])
 		goto out;
 	if ((ret = real_query("delete from dir")) < 0)
 		goto out;
-	query = make_message("load data infile '%s' into table dir "
+	query = make_message("load data infile '%s' ignore into table dir "
 		"fields terminated by '\t' lines terminated by '\n' "
 		"(dir, name)", tempname);
 	ret = real_query(query);
@@ -2384,12 +2383,15 @@ static int com_upd(int fd, int argc, __a_unused char *argv[])
 		goto out;
 	}
 	while ((row = mysql_fetch_row(result))) {
+		char *erow;
 		ret = -E_NOROW;
 		if (!row[0])
 			goto out;
 		send_va_buffer(fd, "new entry: %s\n", row[0]);
+		erow = escape_str(row[0]);
 		query = make_message("insert into data (name, pic_id) values "
-			"('%s','%s')", row[0], "1");
+			"('%s','%s')", erow, "1");
+		free(erow);
 		ret = real_query(query);
 		free(query);
 		if (ret < 0)
@@ -2420,9 +2422,8 @@ static char **server_get_audio_file_list(unsigned int num)
 	free(stream);
 	query = make_message("%s limit %d", tmp, num);
 	free(tmp);
-	if (!query)
-		goto err_out;
 	result = get_result(query);
+	free(query);
 	if (!result)
 		goto err_out;
 	num_rows = mysql_num_rows(result);
@@ -2444,8 +2445,6 @@ err_out:
 	free(list);
 	list = NULL;
 success:
-	if (query)
-		free(query);
 	if (result)
 		mysql_free_result(result);
 	return list;