X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=net.c;h=2369dc8ce99027a4bb122a9a9d3e71bb5aa10f8b;hp=64602a4bf60e7ce934f230cb0ae9d63f5ec404f5;hb=75d545612d8fb51b7e6b2f8a7349b54502004cfa;hpb=8eec0149df9d3a7566ff28060862ae605bd73b42

diff --git a/net.c b/net.c
index 64602a4b..2369dc8c 100644
--- a/net.c
+++ b/net.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2005-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -380,8 +380,8 @@ int makesock(unsigned l4type, bool passive,
 	     const char *host, uint16_t port_number,
 	     struct flowopts *fo)
 {
-	struct addrinfo *local = NULL, *src,
-			*remote = NULL, *dst, hints;
+	struct addrinfo *local = NULL, *src = NULL, *remote = NULL,
+		*dst = NULL, hints;
 	unsigned int	l3type = AF_UNSPEC;
 	int		rc, on = 1, sockfd = -1,
 			socktype = sock_type(l4type);
@@ -414,7 +414,8 @@ int makesock(unsigned l4type, bool passive,
 				layer4_name(l4type),
 				host? host : (passive? "[loopback]" : "[localhost]"),
 				port, gai_strerror(rc));
-		return -E_ADDRESS_LOOKUP;
+		rc = -E_ADDRESS_LOOKUP;
+		goto out;
 	}
 
 	/* Iterate over all src/dst combination, exhausting dst first */
@@ -439,7 +440,8 @@ int makesock(unsigned l4type, bool passive,
 			close(sockfd);
 			PARA_ERROR_LOG("can not set SO_REUSEADDR: %s\n",
 				       strerror(rc));
-			return -ERRNO_TO_PARA_ERROR(rc);
+			rc = -ERRNO_TO_PARA_ERROR(rc);
+			break;
 		}
 		flowopt_setopts(sockfd, fo);
 
@@ -462,6 +464,7 @@ get_next_src:
 		if (src && (src = src->ai_next)) /* restart inner loop */
 			dst = remote;
 	}
+out:
 	if (local)
 		freeaddrinfo(local);
 	if (remote)
@@ -469,11 +472,12 @@ get_next_src:
 	flowopt_cleanup(fo);
 
 	if (src == NULL && dst == NULL) {
-		rc = errno;
+		if (rc >= 0)
+			rc = -E_MAKESOCK;
 		PARA_ERROR_LOG("can not create %s socket %s#%s.\n",
 			layer4_name(l4type), host? host : (passive?
 			"[loopback]" : "[localhost]"), port);
-		return -ERRNO_TO_PARA_ERROR(rc);
+		return rc;
 	}
 	return sockfd;
 }