X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=net.c;h=3dcd9c0be5884f59293d012c3e117ea61b83a282;hp=6a8eea3b261c3dadb8df2c73d25626150cd5ad00;hb=48027ab6ec9113c037dfd388e91579ecf0a70eae;hpb=6703c9a063a61320294aa2cc519a911a4e76d49b diff --git a/net.c b/net.c index 6a8eea3b..3dcd9c0b 100644 --- a/net.c +++ b/net.c @@ -1,19 +1,7 @@ /* * Copyright (C) 2005-2007 Andre Noll * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Licensed under the GPL v2. For licencing details see COPYING. */ /** \file net.c networking-related helper functions */ @@ -24,21 +12,23 @@ #include "error.h" -/** holds information about one encrypted connection */ +/** Information about one encrypted connection. */ struct crypt_data { - /** function used to decrypt received data */ + /** Function used to decrypt received data. */ crypt_function *recv; - /** function used to encrypt data to be sent */ + /** Function used to encrypt data to be sent. */ crypt_function *send; - /** context-dependent data, passed to \a recv() and \a send() */ + /** + * Context-dependent data (crypt keys), passed verbatim to the above + * crypt functions. + */ void *private_data; }; -/** array holding per fd crypt data per */ +/** Array holding per fd crypt data. */ static struct crypt_data *crypt_data_array; -/** current size of the crypt data array */ +/** Current size of the crypt data array. */ static unsigned cda_size = 0; - /** * activate encryption for one file descriptor * @@ -120,8 +110,7 @@ void init_sockaddr(struct sockaddr_in *addr, int port, const struct hostent *he) */ static int sendall(int fd, const char *buf, size_t *len) { - int total = 0; /* how many bytes we've sent */ - int bytesleft = *len; /* how many we have left to send */ + size_t total = 0, bytesleft = *len; /* how many we have left to send */ int n = -1; while (total < *len) { @@ -162,7 +151,8 @@ int send_bin_buffer(int fd, const char *buf, size_t len) cf = crypt_data_array[fd].send; if (cf) { void *private = crypt_data_array[fd].private_data; - unsigned char *outbuf = para_malloc(len); + /* RC4 may write more than len to the output buffer */ + unsigned char *outbuf = para_malloc(ROUND_UP(len, 8)); (*cf)(len, (unsigned char *)buf, outbuf, private); ret = sendall(fd, (char *)outbuf, &len); free(outbuf); @@ -222,9 +212,9 @@ __printf_2_3 int send_va_buffer(int fd, const char *fmt, ...) * * \sa recv(2) */ -__must_check int recv_bin_buffer(int fd, char *buf, ssize_t size) +__must_check int recv_bin_buffer(int fd, char *buf, size_t size) { - int n; + ssize_t n; crypt_function *cf = NULL; if (fd + 1 <= cda_size) @@ -233,8 +223,11 @@ __must_check int recv_bin_buffer(int fd, char *buf, ssize_t size) unsigned char *tmp = para_malloc(size); void *private = crypt_data_array[fd].private_data; n = recv(fd, tmp, size, 0); - if (n > 0) - (*cf)(n, tmp, (unsigned char *)buf, private); + if (n > 0) { + size_t numbytes = n; + unsigned char *b = (unsigned char *)buf; + (*cf)(numbytes, tmp, b, private); + } free(tmp); } else n = recv(fd, buf, size, 0); @@ -257,10 +250,12 @@ __must_check int recv_bin_buffer(int fd, char *buf, ssize_t size) * * \sa recv_bin_buffer() */ -int recv_buffer(int fd, char *buf, ssize_t size) +int recv_buffer(int fd, char *buf, size_t size) { int n; + if (!size) + return -E_RECV; n = recv_bin_buffer(fd, buf, size - 1); if (n >= 0) buf[n] = '\0'; @@ -298,11 +293,11 @@ int get_host_info(char *host, struct hostent **ret) * * \sa socket(2) */ -int get_socket(void) +int get_stream_socket(int domain) { int socket_fd; - if ((socket_fd = socket(AF_INET, SOCK_STREAM, 0)) == -1) + if ((socket_fd = socket(domain, SOCK_STREAM, 0)) == -1) return -E_SOCKET; return socket_fd; } @@ -382,11 +377,11 @@ int init_unix_addr(struct sockaddr_un *u, const char *name) } /** - * prepare, create, and bind and socket for local communication + * Prepare, create, and bind a socket for local communication. * - * \param name the socket pathname - * \param unix_addr pointer to the \p AF_UNIX socket structure - * \param mode the desired mode of the socket + * \param name The socket pathname. + * \param unix_addr Pointer to the \p AF_UNIX socket structure. + * \param mode The desired mode of the socket. * * This functions creates a local socket for sequenced, reliable, * two-way, connection-based byte streams. @@ -397,22 +392,27 @@ int init_unix_addr(struct sockaddr_un *u, const char *name) * \sa bind(2) * \sa chmod(2) */ -int create_pf_socket(const char *name, struct sockaddr_un *unix_addr, int mode) +int create_local_socket(const char *name, struct sockaddr_un *unix_addr, + mode_t mode) { int fd, ret; - fd = socket(PF_UNIX, SOCK_STREAM, 0); - if (fd < 0) - return -E_SOCKET; -// unlink(name); ret = init_unix_addr(unix_addr, name); if (ret < 0) return ret; + fd = socket(PF_UNIX, SOCK_STREAM, 0); + if (fd < 0) + return -E_SOCKET; + ret = -E_BIND; if (bind(fd, (struct sockaddr *) unix_addr, UNIX_PATH_MAX) < 0) - return -E_BIND; + goto err; + ret = -E_CHMOD; if (chmod(name, mode) < 0) - return -E_CHMOD; + goto err; return fd; +err: + close(fd); + return ret; } #ifndef HAVE_UCRED @@ -471,7 +471,7 @@ ssize_t send_cred_buffer(int sock, char *buf) return ret; } -static void dispose_fds(int *fds, int num) +static void dispose_fds(int *fds, unsigned num) { int i; @@ -543,7 +543,7 @@ int recv_cred_buffer(int fd, char *buf, size_t size) * \return The file descriptor of the created socket, negative * on errors. * - * \sa get_socket() + * \sa get_stream_socket() * \sa setsockopt(2) * \sa bind(2) * \sa listen(2) @@ -551,7 +551,7 @@ int recv_cred_buffer(int fd, char *buf, size_t size) int init_tcp_socket(int port) { struct sockaddr_in my_addr; - int fd, ret = get_socket(); + int fd, ret = get_stream_socket(AF_INET); if (ret < 0) return ret;