X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=net.c;h=91200fc040bcfebafccf9e737fb65514af9ff8f2;hp=23cd8032f5019796d601976524cb63a7067f7a43;hb=refs%2Fheads%2Fpu;hpb=72801d0fbf90fb4193d1592908b485f183ed85fb

diff --git a/net.c b/net.c
index 23cd8032..9b362442 100644
--- a/net.c
+++ b/net.c
@@ -18,6 +18,13 @@
 #include "list.h"
 #include "fd.h"
 
+/* Whether the given address conforms to the IPv4 address format. */
+static inline bool is_valid_ipv4_address(const char *address)
+{
+	struct in_addr test_it;
+	return inet_pton(AF_INET, address, &test_it) != 0;
+}
+
 /**
  * Parse and validate IPv4 address/netmask string.
  *
@@ -58,13 +65,6 @@ failed:
 	return NULL;
 }
 
-
-/**
- * Match string as a candidate IPv4 address.
- *
- * \param address The string to match.
- * \return True if \a address has "dot-quad" format.
- */
 static bool is_v4_dot_quad(const char *address)
 {
 	bool result;
@@ -77,6 +77,13 @@ static bool is_v4_dot_quad(const char *address)
 	return result;
 }
 
+/* Whether a string conforms to IPv6 address format (RFC 4291). */
+static inline bool is_valid_ipv6_address(const char *address)
+{
+	struct in6_addr test_it;
+	return inet_pton(AF_INET6, address, &test_it) != 0;
+}
+
 /**
  * Perform basic syntax checking on the host-part of an URL:
  *
@@ -183,7 +190,7 @@ failed:
  * \return In all cases the returned string is a allocated with malloc(3) and
  * has to be freed by the caller.
  */
-char *format_url(const char *url, int default_port)
+__malloc char *format_url(const char *url, int default_port)
 {
 	char host[MAX_HOSTLEN];
 	int url_port;
@@ -205,7 +212,7 @@ char *format_url(const char *url, int default_port)
  * \param transport Transport protocol name (e.g. "udp", "tcp"), or NULL.
  * \return Pointer to static result buffer.
  *
- * \sa getservent(3), services(5), nsswitch.conf(5).
+ * \sa getservbyport(3), services(5), nsswitch.conf(5).
  */
 const char *stringify_port(int port, const char *transport)
 {
@@ -228,12 +235,9 @@ const char *stringify_port(int port, const char *transport)
 #define SOCK_DCCP 6 /**< Linux socket type. */
 #endif
 
-/**
- * Determine the socket type for a given layer-4 protocol.
- *
- * \param l4type The symbolic name of the transport-layer protocol.
- *
- * \sa ip(7), socket(2).
+/*
+ * Determine the socket type, given the symbolic name of the transport-layer
+ * protocol. See ip(7), socket(2).
  */
 static inline int sock_type(const unsigned l4type)
 {
@@ -245,9 +249,7 @@ static inline int sock_type(const unsigned l4type)
 	return -1;		/* not supported here */
 }
 
-/**
- * Pretty-print transport-layer name.
- */
+/* Pretty-print transport-layer name. */
 static const char *layer4_name(const unsigned l4type)
 {
 	switch (l4type) {
@@ -334,7 +336,7 @@ void flowopt_add(struct flowopts *fo, int lev, int opt,
 	list_add_tail(&new->node, &fo->sockopts);
 }
 
-/** Set the entire bunch of pre-connection options at once. */
+/* Set the entire bunch of pre-connection options at once. */
 static void flowopt_setopts(int sockfd, struct flowopts *fo)
 {
 	struct pre_conn_opt *pc;
@@ -518,7 +520,7 @@ int makesock(unsigned l4type, bool passive, const char *host, uint16_t port_numb
 	if (ai)
 		freeaddrinfo(ai);
 	if (ret < 0) {
-		PARA_ERROR_LOG("can not create %s socket %s#%d.\n",
+		PARA_NOTICE_LOG("can not create %s socket %s#%d.\n",
 		layer4_name(l4type), host? host : (passive?
 		"[loopback]" : "[localhost]"), port_number);
 	}
@@ -580,11 +582,7 @@ int para_listen_simple(unsigned l4type, uint16_t port)
 	return para_listen(l4type, NULL, port);
 }
 
-/**
- * Determine IPv4/v6 socket address length.
- * \param sa Container of IPv4 or IPv6 address.
- * \return Address-family dependent address length.
- */
+/* Compute the address-family dependent address length of an IPv4/v6 socket. */
 static socklen_t salen(const struct sockaddr *sa)
 {
 	assert(sa->sa_family == AF_INET || sa->sa_family == AF_INET6);
@@ -594,7 +592,7 @@ static socklen_t salen(const struct sockaddr *sa)
 		: sizeof(struct sockaddr_in);
 }
 
-/** True if @ss holds a v6-mapped-v4 address (RFC 4291, 2.5.5.2) */
+/* True if ss holds a v6-mapped-v4 address (RFC 4291, 2.5.5.2) */
 static bool SS_IS_ADDR_V4MAPPED(const struct sockaddr_storage *ss)
 {
 	const struct sockaddr_in6 *ia6 = (const struct sockaddr_in6 *)ss;
@@ -602,10 +600,10 @@ static bool SS_IS_ADDR_V4MAPPED(const struct sockaddr_storage *ss)
 	return ss->ss_family == AF_INET6 && IN6_IS_ADDR_V4MAPPED(&ia6->sin6_addr);
 }
 
-/**
+/*
  * Process IPv4/v6 address, turn v6-mapped-v4 address into normal IPv4 address.
- * \param ss Container of IPv4/6 address.
- * \return Pointer to normalized address (may be static storage).
+ * ss: Container of IPv4/6 address.
+ * Returns: Pointer to normalized address (may be static storage).
  *
  * \sa RFC 3493.
  */
@@ -626,7 +624,7 @@ normalize_ip_address(const struct sockaddr_storage *ss)
 	return (const struct sockaddr *)ss;
 }
 
-/**
+/*
  * Generic/fallback MTU values
  *
  * These are taken from RFC 1122, RFC 2460, and RFC 5405.
@@ -641,7 +639,7 @@ static inline int generic_mtu(const int af_type)
 	return af_type == AF_INET6 ? 1280 : 576;
 }
 
-/** Crude approximation of IP header overhead - neglecting options. */
+/* Crude approximation of IP header overhead - neglecting options. */
 static inline int estimated_header_overhead(const int af_type)
 {
 	return af_type == AF_INET6 ? 40 : 20;
@@ -856,7 +854,7 @@ int dccp_available_ccids(uint8_t **ccid_array)
 	socklen_t nccids = sizeof(ccids);
 	int ret, fd;
 
-	ret = fd = makesock(IPPROTO_DCCP, 1, NULL, 0, NULL);
+	ret = fd = makesock(IPPROTO_DCCP, true /* passive */, NULL, 0, NULL);
 	if (ret < 0)
 		return ret;