X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=osx_write.c;h=f1e308d8beb498586f60acbe1fa93b24077bc320;hp=b057b9c057991864b582ad8519cbac1b9083a90d;hb=081c8921f827c1ed482c45ba22bd8bb97db2838b;hpb=83ab4b5d38bb63cf4724022c3804d3eaa2ac51d3

diff --git a/osx_write.c b/osx_write.c
index b057b9c0..f1e308d8 100644
--- a/osx_write.c
+++ b/osx_write.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2012 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -301,7 +301,7 @@ static void osx_write_pre_select(struct sched *s, struct task *t)
 	sched_request_timeout_ms(50, s);
 }
 
-static void osx_write_post_select(__a_unused struct sched *s, struct task *t)
+static int osx_write_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct writer_node *wn = container_of(t, struct writer_node, task);
 	struct private_osx_write_data *powd = wn->private_data;
@@ -314,7 +314,7 @@ static void osx_write_post_select(__a_unused struct sched *s, struct task *t)
 	if (!powd) {
 		ret = btr_node_status(btrn, wn->min_iqs, BTR_NT_LEAF);
 		if (ret == 0)
-			return;
+			return 0;
 		if (ret < 0)
 			goto fail;
 		ret = core_audio_init(wn);
@@ -326,7 +326,7 @@ static void osx_write_post_select(__a_unused struct sched *s, struct task *t)
 			AudioUnitUninitialize(powd->audio_unit);
 			CloseComponent(powd->audio_unit);
 			btr_remove_node(&powd->callback_btrn);
-			goto remove_btrn;
+			goto fail;
 		}
 	}
 	mutex_lock(powd->mutex);
@@ -337,7 +337,7 @@ static void osx_write_post_select(__a_unused struct sched *s, struct task *t)
 		ret = 0;
 	mutex_unlock(powd->mutex);
 	if (ret >= 0)
-		return;
+		return 0;
 fail:
 	assert(ret < 0);
 	if (powd && powd->callback_btrn) {
@@ -348,7 +348,7 @@ fail:
 	}
 	btr_remove_node(&wn->btrn);
 	PARA_NOTICE_LOG("%s\n", para_strerror(-ret));
-	t->error = ret;
+	return ret;
 }
 
 /**
@@ -366,9 +366,6 @@ void osx_write_init(struct writer *w)
 	w->post_select = osx_write_post_select;
 	w->parse_config_or_die = osx_write_parse_config_or_die;
 	w->free_config = osx_free_config;
-	w->help = (struct ggo_help) {
-		.short_help = osx_write_args_info_help,
-		.detailed_help = osx_write_args_info_detailed_help
-	};
+	w->help = (struct ggo_help)DEFINE_GGO_HELP(osx_write);
 	osx_write_cmdline_parser_free(&dummy);
 }