X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=server.c;h=95ff25cf77afb9f772a4336626e2bf340a2da868;hp=da55b99923621975335a86a7dfbbad41e3e6a573;hb=refs%2Fheads%2Fv0.3;hpb=a0b1604a44be6bb89c91ae760f1ccf00768eb09a

diff --git a/server.c b/server.c
index da55b999..95ff25cf 100644
--- a/server.c
+++ b/server.c
@@ -59,7 +59,7 @@
  *	- Ring buffer: \ref ringbuffer.c, \ref ringbuffer.h,
  *	- Hashing: \ref hash.h, \ref sha1.h, \ref sha1.c,
  *	- Crypto: \ref crypt.c.
- *
+ *	- Forward error correction: \ref fec.c
  */
 
 #include <signal.h>
@@ -335,25 +335,15 @@ static void init_signal_task(void)
 	st->task.post_select = signal_post_select;
 	sprintf(st->task.status, "signal task");
 
+	PARA_NOTICE_LOG("setting up signal handling\n");
 	st->fd = para_signal_init(); /* always successful */
-
-	PARA_NOTICE_LOG("setting up signal handlers\n");
-	if (para_install_sighandler(SIGINT) < 0)
-		goto err;
-	if (para_install_sighandler(SIGTERM) < 0)
-		goto err;
-	if (para_install_sighandler(SIGHUP) < 0)
-		goto err;
-	if (para_install_sighandler(SIGCHLD) < 0)
-		goto err;
-	if (signal(SIGPIPE, SIG_IGN) == SIG_ERR)
-		goto err;
+	para_install_sighandler(SIGINT);
+	para_install_sighandler(SIGTERM);
+	para_install_sighandler(SIGHUP);
+	para_install_sighandler(SIGCHLD);
+	para_sigaction(SIGPIPE, SIG_IGN);
 	add_close_on_fork_list(st->fd);
 	register_task(&st->task);
-	return;
-err:
-	PARA_EMERG_LOG("could not install signal handlers\n");
-	exit(EXIT_FAILURE);
 }
 
 static void command_pre_select(struct sched *s, struct task *t)
@@ -480,18 +470,20 @@ err:
 static int init_afs(void)
 {
 	int ret, afs_server_socket[2];
+	pid_t afs_pid;
 
 	ret = socketpair(PF_UNIX, SOCK_DGRAM, 0, afs_server_socket);
 	if (ret < 0)
 		exit(EXIT_FAILURE);
 	afs_socket_cookie = para_random((uint32_t)-1);
-	mmd->afs_pid = fork();
-	if (mmd->afs_pid < 0)
+	afs_pid = fork();
+	if (afs_pid < 0)
 		exit(EXIT_FAILURE);
-	if (!mmd->afs_pid) { /* child (afs) */
+	if (afs_pid == 0) { /* child (afs) */
 		close(afs_server_socket[0]);
 		afs_init(afs_socket_cookie, afs_server_socket[1]);
 	}
+	mmd->afs_pid = afs_pid;
 	close(afs_server_socket[1]);
 	ret = mark_fd_nonblocking(afs_server_socket[0]);
 	if (ret < 0)
@@ -546,19 +538,13 @@ static void server_init(int argc, char **argv)
 	 * before the child gets a chance to ignore this signal -- only the
 	 * good die young.
 	 */
-	if (signal(SIGUSR1, SIG_IGN) == SIG_ERR) {
-		PARA_EMERG_LOG("failed to ignore SIGUSR1\n");
-		exit(EXIT_FAILURE);
-	}
+	para_sigaction(SIGUSR1, SIG_IGN);
 	/*
 	 * We have to install a SIGCHLD handler before the afs process is being
 	 * forked off. Otherwise, para_server does not notice if afs dies before
 	 * the SIGCHLD handler has been installed by init_signal_task() below.
 	 */
-	if (signal(SIGCHLD, tmp_sigchld_handler) == SIG_ERR) {
-		PARA_EMERG_LOG("failed to install temporary SIGCHLD handler\n");
-		exit(EXIT_FAILURE);
-	}
+	para_sigaction(SIGCHLD, tmp_sigchld_handler);
 	PARA_NOTICE_LOG("initializing the audio file selector\n");
 	afs_socket = init_afs();
 	init_signal_task();