X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=signal.c;h=67af16558fa9357518eaef956d74f477c8625794;hp=33449c632f5214e5acd464faeeae079b0701f0d5;hb=5d581fbd46a6d1949bfd876aec63041dc6724eb0;hpb=7a3352c3c6969a3019fd4adb3a957c711441160e

diff --git a/signal.c b/signal.c
index 33449c63..67af1655 100644
--- a/signal.c
+++ b/signal.c
@@ -40,15 +40,15 @@ int para_signal_init(void)
 		ret = -ERRNO_TO_PARA_ERROR(errno);
 		goto err_out;
 	}
-	ret = mark_fd_nonblock(signal_pipe[0]);
+	ret = mark_fd_nonblocking(signal_pipe[0]);
 	if (ret < 0)
 		goto err_out;
-	ret = mark_fd_nonblock(signal_pipe[1]);
+	ret = mark_fd_nonblocking(signal_pipe[1]);
 	if (ret < 0)
 		goto err_out;
 	return signal_pipe[0];
 err_out:
-	PARA_EMERG_LOG("%s\n", PARA_STRERROR(-ret));
+	PARA_EMERG_LOG("%s\n", para_strerror(-ret));
 	exit(EXIT_FAILURE);
 }
 
@@ -85,13 +85,13 @@ int para_reap_child(pid_t *pid)
 	if (*pid < 0)
 		return -ERRNO_TO_PARA_ERROR(errno);
 	if (WIFEXITED(status))
-		PARA_DEBUG_LOG("child %i exited. Exit status: %i\n", *pid,
+		PARA_DEBUG_LOG("child %i exited. Exit status: %i\n", (int)*pid,
 			WEXITSTATUS(status));
 	else if (WIFSIGNALED(status))
-		PARA_DEBUG_LOG("child %i was killed by signal %i\n", *pid,
+		PARA_DEBUG_LOG("child %i was killed by signal %i\n", (int)*pid,
 			WTERMSIG(status));
 	else
-		PARA_WARNING_LOG("child %i terminated abormally\n", *pid);
+		PARA_WARNING_LOG("child %i terminated abormally\n", (int)*pid);
 	return 1;
 }
 
@@ -137,13 +137,17 @@ int para_next_signal(void)
 	int s;
 	ssize_t r;
 
-	if ((r = read(signal_pipe[0], &s, sizeof(s)) == sizeof(s)) > 0) {
+	r = read(signal_pipe[0], &s, sizeof(s));
+	if (r == sizeof(s)) {
 		PARA_DEBUG_LOG("next signal: %d\n", s);
 		return s;
 	}
 	return r < 0 && (errno != EAGAIN)? 0 : -E_SIGNAL_READ;
 }
 
+/**
+ * Close the signal pipe.
+ */
 void para_signal_shutdown(void)
 {
 	close(signal_pipe[1]);