X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=signal.c;h=da395157c29ae8aff0459a2731e10ae7a13e90e6;hp=67af16558fa9357518eaef956d74f477c8625794;hb=c36f5e92c572c8eaf77c227bce164b9e98a74a3e;hpb=c73d23911d78ed10179c12ef8f79a3fcf3bbcdaf

diff --git a/signal.c b/signal.c
index 67af1655..da395157 100644
--- a/signal.c
+++ b/signal.c
@@ -1,9 +1,9 @@
 /*
- * Copyright (C) 2004-2006 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2004-2009 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
-/** \file signal.c signal handling functions */
+/** \file signal.c Signal handling functions. */
 
 #include <signal.h>
 #include <sys/types.h>
@@ -57,8 +57,15 @@ err_out:
  */
 static void generic_signal_handler(int s)
 {
-	write(signal_pipe[1], &s, sizeof(int));
-	//fprintf(stderr, "got sig %i, write returned %d\n", s, ret);
+	ssize_t ret = write(signal_pipe[1], &s, sizeof(int));
+
+	if (ret == sizeof(int))
+		return;
+	if (ret < 0)
+		PARA_EMERG_LOG("%s\n", strerror(errno));
+	else
+		PARA_EMERG_LOG("short write to signal pipe\n");
+	exit(EXIT_FAILURE);
 }
 
 /**
@@ -73,7 +80,7 @@ static void generic_signal_handler(int s)
  * one otherwise. If and only if the function returns one, the content of \a
  * pid is meaningful.
  *
- * \sa waitpid(2)
+ * \sa waitpid(2).
  */
 int para_reap_child(pid_t *pid)
 {
@@ -96,57 +103,81 @@ int para_reap_child(pid_t *pid)
 }
 
 /**
- * Paraslash's zombie killer.
+ * Install the given handler for the given signal.
  *
- * It just calls \p para_reap_child() until there are no more children left to
- * reap.
+ * \param sig The number of the signal to catch.
+ * \param handler to be installed, \p SIG_IGN, or \p SIG_DFL.
+ *
+ * This either succeeds or calls exit(EXIT_FAILURE).
+ *
+ * \sa sigaction(2).
  */
-void para_reap_children(void)
+void para_sigaction(int sig, void (*handler)(int))
 {
-	pid_t pid;
+	struct sigaction act;
 
-	while (para_reap_child(&pid) > 0)
-		; /* nothing */
+	PARA_DEBUG_LOG("catching signal %d\n", sig);
+	act.sa_handler = handler;
+	sigemptyset(&act.sa_mask);
+	act.sa_flags = 0;
+	if (sig == SIGALRM) {
+		#ifdef SA_INTERRUPT /* SunOS */
+			act.sa_flags |= SA_INTERRUPT;
+		#endif
+	} else {
+		#ifdef SA_RESTART /* BSD */
+			act.sa_flags |= SA_RESTART;
+		#endif
+	}
+	if (sigaction(sig, &act, NULL) >= 0)
+		return;
+	PARA_EMERG_LOG("failed to install signal handler for signal %d\n",
+		sig);
+	exit(EXIT_FAILURE);
 }
 
 /**
- * wrapper around signal(2)
- * \param sig the number of the signal to catch
+ * Install the generic signal handler for the given signal number.
  *
- * This installs the generic signal handler for the given signal.
- * \return This function returns 1 on success and \p -E_SIGNAL_SIG_ERR on errors.
- * \sa signal(2)
+ * \param sig The number of the signal to catch.
+ *
+ * \sa signal(2), sigaction(2).
  */
-int para_install_sighandler(int sig)
+void para_install_sighandler(int sig)
 {
-	PARA_DEBUG_LOG("catching signal %d\n", sig);
-	return signal(sig, &generic_signal_handler) == SIG_ERR?  -E_SIGNAL_SIG_ERR : 1;
+	para_sigaction(sig, &generic_signal_handler);
 }
 
 /**
- * return number of next pending signal
+ * Return the number of next pending signal.
  *
  * This should be called if the fd for the signal pipe is ready for reading.
  *
- * \return On success, the number of the received signal is returned. \p
- * -E_SIGNAL_READ is returned if a read error occurred while reading the signal
- * pipe.  If the read was interrupted by another signal the function returns 0.
+ * \return On success, the number of the received signal is returned.  If the
+ * read returned zero or was interrupted by another signal the function returns
+ * 0.  Otherwise, a negative error value is returned.
  */
 int para_next_signal(void)
 {
 	int s;
-	ssize_t r;
+	ssize_t r = read(signal_pipe[0], &s, sizeof(s));
 
-	r = read(signal_pipe[0], &s, sizeof(s));
-	if (r == sizeof(s)) {
-		PARA_DEBUG_LOG("next signal: %d\n", s);
-		return s;
+	if (!r) {
+		PARA_CRIT_LOG("read from signal pipe returned zero\n");
+		return 0;
+	}
+	if (r < 0) {
+		if (errno == EAGAIN || errno == EINTR)
+			return 0;
+		return -ERRNO_TO_PARA_ERROR(errno);
 	}
-	return r < 0 && (errno != EAGAIN)? 0 : -E_SIGNAL_READ;
+	assert(r == sizeof(s));
+	PARA_DEBUG_LOG("next signal: %d\n", s);
+	return s;
 }
 
 /**
- * Close the signal pipe.
+ * Close the write end of the signal pipe.
  */
 void para_signal_shutdown(void)
 {