X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=stdin.c;h=868e1ed0e031744e1df39368ed241547e02fd836;hp=abe69cafd4270ddf0e82ed9d2b30d3cf3603f43a;hb=df0b105444be76e6bcb1f54987824f7f4f6f13a5;hpb=2b1f064a6357d027b4c06eee6cf191940726859e diff --git a/stdin.c b/stdin.c index abe69caf..868e1ed0 100644 --- a/stdin.c +++ b/stdin.c @@ -53,12 +53,13 @@ static void stdin_pre_select_btr(struct sched *s, struct task *t) t->error = 0; ret = btr_node_status(sit->btrn, 0, BTR_NT_ROOT); - if (ret > 0) - para_fd_set(STDIN_FILENO, &s->rfds, &s->max_fileno); - else if (ret < 0) { - s->timeout.tv_sec = 0; - s->timeout.tv_usec = 1; - } + if (ret < 0) + sched_min_delay(s); + if (ret <= 0) + return; + if (btr_pool_unused(sit->btrp) > 0) + return para_fd_set(STDIN_FILENO, &s->rfds, &s->max_fileno); + sched_request_timeout_ms(100, s); } /** @@ -95,11 +96,11 @@ static void stdin_post_select(struct sched *s, struct task *t) t->error = -E_STDIN_EOF; } -#define STDIN_INPUT_BUFFER_SIZE (1024 * 32) static void stdin_post_select_btr(struct sched *s, struct task *t) { struct stdin_task *sit = container_of(t, struct stdin_task, task); ssize_t ret; + size_t sz; char *buf = NULL; t->error = 0; @@ -110,21 +111,27 @@ static void stdin_post_select_btr(struct sched *s, struct task *t) return; if (!FD_ISSET(STDIN_FILENO, &s->rfds)) return; - buf = para_malloc(STDIN_INPUT_BUFFER_SIZE); - ret = read(STDIN_FILENO, buf, STDIN_INPUT_BUFFER_SIZE); - //PARA_CRIT_LOG("read ret: %d\n", ret); - if (ret <= 0) { - if (ret < 0) - ret = -ERRNO_TO_PARA_ERROR(errno); - else - ret = -E_STDIN_EOF; + sz = btr_pool_get_buffer(sit->btrp, &buf); + if (sz == 0) + return; + /* + * Do not use the maximal size to avoid having only a single buffer + * reference for the whole pool. This is bad because if that single + * reference can not be freed, we're stuck. + */ + sz = PARA_MIN(sz, btr_pool_size(sit->btrp) / 2); + ret = read(STDIN_FILENO, buf, sz); + if (ret < 0) + ret = -ERRNO_TO_PARA_ERROR(errno); + if (ret == 0) + ret = -E_STDIN_EOF; + if (ret < 0) goto err; - } - btr_add_output(buf, ret, sit->btrn); + btr_add_output_pool(sit->btrp, ret, sit->btrn); return; err: - free(buf); btr_remove_node(sit->btrn); + //btr_pool_free(sit->btrp); t->error = ret; } @@ -135,7 +142,7 @@ err: * * This fills in the pre/post select function pointers of the task structure * given by \a sit. Moreover, the stdin file desctiptor is set to nonblocking - * mode and \a bufsize is initialized to 16 KB (but no buffer is allocated). + * mode and \a bufsize is initialized (but no buffer is allocated). */ void stdin_set_defaults(struct stdin_task *sit) { @@ -145,6 +152,7 @@ void stdin_set_defaults(struct stdin_task *sit) if (sit->btrn) { sit->task.pre_select = stdin_pre_select_btr; sit->task.post_select = stdin_post_select_btr; + sit->btrp = btr_pool_new("stdin", 64 * 1024); } else { sit->task.pre_select = stdin_pre_select; sit->task.post_select = stdin_post_select;