X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=udp_recv.c;h=2657beec952059a58cac468f02d0dc2d3350777c;hp=f68a7100b99128a29ed18cd3e5fe04b2b4263327;hb=98ab15f91ac1b5127c86d5f0b6aed353f43ffd35;hpb=c282c836791cedf57c128555af90af37c7c01c05

diff --git a/udp_recv.c b/udp_recv.c
index f68a7100..2657beec 100644
--- a/udp_recv.c
+++ b/udp_recv.c
@@ -23,8 +23,6 @@
 #include "fd.h"
 #include "buffer_tree.h"
 
-/** The size of the receiver node buffer. */
-#define UDP_RECV_CHUNK_SIZE (128 * 1024)
 /**
  * Data specific to the udp receiver.
  *
@@ -33,83 +31,27 @@
 struct private_udp_recv_data {
 	/** The socket file descriptor. */
 	int fd;
+	struct btr_pool *btrp;
 };
 
 static void udp_recv_pre_select(struct sched *s, struct task *t)
 {
 	struct receiver_node *rn = container_of(t, struct receiver_node, task);
 	struct private_udp_recv_data *purd = rn->private_data;
-	int ret;
-
-	if (rn->btrn) {
-		ret = generic_recv_pre_select(s, t);
-		if (ret <= 0)
-			return;
-	}
-	para_fd_set(purd->fd, &s->rfds, &s->max_fileno);
-}
-
-static int enough_space(size_t nbytes, size_t loaded)
-{
-	return nbytes + loaded < UDP_RECV_CHUNK_SIZE;
-}
-
-static int add_rn_output(struct receiver_node *rn, char *buf, size_t len)
-{
-	if (!len)
-		return 1;
-	if (!enough_space(len, rn->loaded))
-		return -E_UDP_OVERRUN;
-	memcpy(rn->buf + rn->loaded, buf, len);
-	rn->loaded += len;
-	return 1;
-}
 
-static void udp_recv_post_select_nobtr(__a_unused struct sched *s, struct task *t)
-{
-	struct receiver_node *rn = container_of(t, struct receiver_node, task);
-	struct private_udp_recv_data *purd = rn->private_data;
-	int ret;
-	char tmpbuf[UDP_RECV_CHUNK_SIZE];
-	size_t packet_size;
-
-	if (rn->output_error && *rn->output_error < 0) {
-		t->error = *rn->output_error;
-		return;
-	}
-	if (!FD_ISSET(purd->fd, &s->rfds))
-		return;
-	ret = recv_bin_buffer(purd->fd, tmpbuf, UDP_RECV_CHUNK_SIZE);
-	if (ret < 0) {
-		if (is_errno(ret, EINTR) || is_errno(ret, EAGAIN))
-			goto success;
-		t->error = ret;
+	if (generic_recv_pre_select(s, t) <= 0)
 		return;
-	}
-	t->error = -E_RECV_EOF;
-	if (!ret)
-		return;
-	packet_size = ret;
-	if (packet_size >= FEC_EOF_PACKET_LEN)
-		if (!memcmp(tmpbuf, FEC_EOF_PACKET, FEC_EOF_PACKET_LEN))
-			return;
-	t->error = add_rn_output(rn, tmpbuf, packet_size);
-	if (t->error < 0)
-		return;
-success:
-	t->error = 1;
+	para_fd_set(purd->fd, &s->rfds, &s->max_fileno);
 }
 
-#define UDP_RECV_READ_BUF_SIZE 1500
-
-static void udp_recv_post_select_btr(__a_unused struct sched *s, struct task *t)
+static void udp_recv_post_select(__a_unused struct sched *s, struct task *t)
 {
 	struct receiver_node *rn = container_of(t, struct receiver_node, task);
 	struct private_udp_recv_data *purd = rn->private_data;
 	struct btr_node *btrn = rn->btrn;
 	int ret;
 	char *buf = NULL;
-	size_t packet_size;
+	size_t packet_size, bufsize;
 
 	t->error = 0;
 	ret = btr_node_status(btrn, 0, BTR_NT_ROOT);
@@ -119,8 +61,11 @@ static void udp_recv_post_select_btr(__a_unused struct sched *s, struct task *t)
 		return;
 	if (!FD_ISSET(purd->fd, &s->rfds))
 		return;
-	buf = para_malloc(UDP_RECV_READ_BUF_SIZE);
-	ret = recv_bin_buffer(purd->fd, buf, UDP_RECV_READ_BUF_SIZE);
+	bufsize = btr_pool_get_buffer(purd->btrp, &buf);
+	ret = -E_UDP_OVERRUN;
+	if (bufsize == 0)
+		goto err;
+	ret = recv_bin_buffer(purd->fd, buf, bufsize);
 	if (ret == 0)
 		ret = -E_RECV_EOF;
 	if (ret < 0)
@@ -128,29 +73,18 @@ static void udp_recv_post_select_btr(__a_unused struct sched *s, struct task *t)
 	packet_size = ret;
 	if (packet_size >= FEC_EOF_PACKET_LEN) {
 		if (!memcmp(buf, FEC_EOF_PACKET, FEC_EOF_PACKET_LEN)) {
+			PARA_INFO_LOG("received eof packet\n");
 			ret = -E_RECV_EOF;
 			goto err;
 		}
 	}
-	btr_add_output(buf, ret, btrn);
+	btr_add_output_pool(purd->btrp, packet_size, btrn);
 	return;
 err:
-	free(buf);
 	btr_remove_node(btrn);
 	t->error = ret;
-}
-
-static void udp_recv_post_select(__a_unused struct sched *s, struct task *t)
-{
-	struct receiver_node *rn = container_of(t, struct receiver_node, task);
-	if (rn->btrn)
-		return udp_recv_post_select_btr(s, t);
-	udp_recv_post_select_nobtr(s, t);
-}
-
-static void udp_shutdown(void)
-{
-	return;
+	close(purd->fd);
+	purd->fd = -1;
 }
 
 static void udp_recv_close(struct receiver_node *rn)
@@ -159,9 +93,8 @@ static void udp_recv_close(struct receiver_node *rn)
 
 	if (purd->fd >= 0)
 		close(purd->fd);
+	btr_pool_free(purd->btrp);
 	free(rn->private_data);
-	free(rn->buf);
-	udp_recv_cmdline_parser_free(rn->conf);
 }
 
 static void *udp_recv_parse_config(int argc, char **argv)
@@ -245,7 +178,6 @@ static int udp_recv_open(struct receiver_node *rn)
 	char  *iface = c->iface_given ? c->iface_arg : NULL;
 	int ret;
 
-	rn->buf = para_calloc(UDP_RECV_CHUNK_SIZE);
 	rn->private_data = para_calloc(sizeof(struct private_udp_recv_data));
 	purd = rn->private_data;
 
@@ -261,14 +193,16 @@ static int udp_recv_open(struct receiver_node *rn)
 	}
 
 	ret = mark_fd_nonblocking(purd->fd);
-	if (ret < 0)
+	if (ret < 0) {
+		close(purd->fd);
 		goto err;
-	PARA_NOTICE_LOG("receiving from %s:%d, fd=%d\n", c->host_arg,
+	}
+	PARA_INFO_LOG("receiving from %s:%d, fd=%d\n", c->host_arg,
 		c->port_arg, purd->fd);
+	purd->btrp = btr_pool_new("udp_recv", 320 * 1024);
 	return purd->fd;
 err:
 	free(rn->private_data);
-	free(rn->buf);
 	return ret;
 }
 
@@ -289,7 +223,6 @@ void udp_recv_init(struct receiver *r)
 	struct udp_recv_args_info dummy;
 
 	udp_recv_cmdline_parser_init(&dummy);
-	r->shutdown = udp_shutdown;
 	r->open = udp_recv_open;
 	r->close = udp_recv_close;
 	r->pre_select = udp_recv_pre_select;