X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=udp_recv.c;h=45d24eae2cd40e9ee4b53106b92ccb85c779dc85;hp=00ad3e2781745c2e04af80dc462b75171e380dd0;hb=bda95f9508b456dcea89d300f6d4104e30ab9f3e;hpb=6668ac4a8c7f2a92efb9e6d405d954beff77d230

diff --git a/udp_recv.c b/udp_recv.c
index 00ad3e27..45d24eae 100644
--- a/udp_recv.c
+++ b/udp_recv.c
@@ -1,12 +1,11 @@
 /*
- * Copyright (C) 2005-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
 /** \file udp_recv.c Paraslash's udp receiver */
 
 #include <regex.h>
-#include <dirent.h>
 #include <sys/socket.h>
 #include <net/if.h>
 
@@ -67,43 +66,36 @@ static void udp_recv_post_select(__a_unused struct sched *s, struct task *t)
 	struct receiver_node *rn = container_of(t, struct receiver_node, task);
 	struct private_udp_recv_data *purd = rn->private_data;
 	struct btr_node *btrn = rn->btrn;
-	size_t packet_size;
+	size_t num_bytes;
 	struct iovec iov[2];
-	int ret, iovcnt;
+	int ret, readv_ret, iovcnt;
 
 	t->error = 0;
 	ret = btr_node_status(btrn, 0, BTR_NT_ROOT);
-	if (ret < 0)
-		goto err;
-	if (ret == 0)
-		return;
-	if (!FD_ISSET(purd->fd, &s->rfds))
-		return;
+	if (ret <= 0)
+		goto out;
 	iovcnt = btr_pool_get_buffers(purd->btrp, iov);
 	ret = -E_UDP_OVERRUN;
 	if (iovcnt == 0)
-		goto err;
-	ret = para_readv(purd->fd, iov, iovcnt);
-	/* EAGAIN is possible even if FD_ISSET */
-	if (ret < 0 && is_errno(-ret, EAGAIN))
-		return;
-	if (ret == 0)
-		ret = -E_RECV_EOF;
+		goto out;
+	ret = readv_nonblock(purd->fd, iov, iovcnt, &s->rfds, &num_bytes);
+	if (num_bytes == 0)
+		goto out;
+	readv_ret = ret;
+	ret = udp_check_eof(num_bytes, iov);
 	if (ret < 0)
-		goto err;
-	packet_size = ret;
-	ret = udp_check_eof(packet_size, iov);
-	if (ret < 0)
-		goto err;
-	if (iov[0].iov_len >= packet_size)
-		btr_add_output_pool(purd->btrp, packet_size, btrn);
+		goto out;
+	if (iov[0].iov_len >= num_bytes)
+		btr_add_output_pool(purd->btrp, num_bytes, btrn);
 	else { /* both buffers contain data */
 		btr_add_output_pool(purd->btrp, iov[0].iov_len, btrn);
-		btr_add_output_pool(purd->btrp, packet_size - iov[0].iov_len,
+		btr_add_output_pool(purd->btrp, num_bytes - iov[0].iov_len,
 			btrn);
 	}
-	return;
-err:
+	ret = readv_ret;
+out:
+	if (ret >= 0)
+		return;
 	btr_remove_node(btrn);
 	t->error = ret;
 	close(purd->fd);
@@ -149,9 +141,11 @@ static int mcast_receiver_setup(int fd, const char *iface)
 
 	if (getsockname(fd, (struct sockaddr *)&ss, &sslen) < 0)
 		goto err;
+	assert(ss.ss_family == AF_INET || ss.ss_family == AF_INET6);
 
 	if (iface != NULL && id == 0)
-		PARA_WARNING_LOG("could not resolve interface %s, using default", iface);
+		PARA_WARNING_LOG("could not resolve interface %s, using default\n",
+			iface);
 
 	switch (ss.ss_family) {
 	case AF_INET:
@@ -166,12 +160,13 @@ static int mcast_receiver_setup(int fd, const char *iface)
 
 			m4.imr_interface.s_addr	= INADDR_ANY;
 			if (id != 0)
-				PARA_ERROR_LOG("Setting IPv4 receiver mcast interface not supported.");
+				PARA_ERROR_LOG("Setting IPv4 receiver mcast interface not supported\n");
 
 #endif
-			m4.imr_multiaddr	= ((struct sockaddr_in *)&ss)->sin_addr;
+			m4.imr_multiaddr = ((struct sockaddr_in *)&ss)->sin_addr;
 
-			if (setsockopt(fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &m4, sizeof(m4)) < 0)
+			if (setsockopt(fd, IPPROTO_IP, IP_ADD_MEMBERSHIP,
+					&m4, sizeof(m4)) < 0)
 				break;
 		}
 		return 0;
@@ -186,9 +181,6 @@ static int mcast_receiver_setup(int fd, const char *iface)
 				break;
 		}
 		return 0;
-	default:
-		PARA_ERROR_LOG("address family %d not supported", ss.ss_family);
-		return -E_ADDRESS_LOOKUP;
 	}
 err:
 	return -ERRNO_TO_PARA_ERROR(errno);