X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=udp_send.c;h=6ed5026ac31102932d4fb3b23e6e87d375002096;hp=4fb10b444be321c51e7d33da2442fd6b8a469138;hb=a713c13d1089170828403e98c57d3fba9aedf9a4;hpb=a365b8263a0d7a1673699bdf454677c95b38eb95

diff --git a/udp_send.c b/udp_send.c
index 4fb10b44..6ed5026a 100644
--- a/udp_send.c
+++ b/udp_send.c
@@ -1,20 +1,22 @@
 /*
- * Copyright (C) 2005-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2005-2014 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
 
 /** \file udp_send.c Para_server's udp sender. */
 
-
+#include <netinet/in.h>
+#include <sys/socket.h>
 #include <regex.h>
-#include <sys/time.h>
-#include <dirent.h>
+#include <sys/types.h>
 #include <sys/socket.h>
 #include <netinet/udp.h>
 #include <net/if.h>
+#include <arpa/inet.h>
+#include <sys/un.h>
 #include <osl.h>
-#include <stdbool.h>
+#include <netdb.h>
 
 #include "server.cmdline.h"
 #include "para.h"
@@ -25,11 +27,11 @@
 #include "server.h"
 #include "list.h"
 #include "send.h"
+#include "sched.h"
 #include "vss.h"
 #include "portable_io.h"
 #include "net.h"
 #include "fd.h"
-#include "sched.h"
 #include "close_on_fork.h"
 
 /**
@@ -57,8 +59,13 @@ static void udp_close_target(struct sender_client *sc)
 	const char *buf;
 	size_t len = vss_get_fec_eof_packet(&buf);
 
-	/* ignore return value, closing the target anyway. */
-	(void)write(sc->fd, buf, len);
+	/*
+	 * Ignore the return value of wirte() since we are closing the target
+	 * anyway. The sole purpose of the "do_nothing" statement is to silence
+	 * gcc.
+	 */
+	if (write(sc->fd, buf, len))
+		do_nothing;
 }
 
 static void udp_delete_target(struct sender_client *sc, const char *msg)
@@ -274,18 +281,18 @@ static int udp_check_socket_state(struct sender_client *sc)
 	return -ERRNO_TO_PARA_ERROR(ret);
 }
 
-static int udp_send_fec(struct sender_client *sc, char *buf, size_t len)
+static void udp_send_fec(struct sender_client *sc, char *buf, size_t len)
 {
 	int ret;
 
 	if (sender_status == SENDER_OFF)
-		return 0;
+		return;
 	if (len == 0)
-		return 0;
+		return;
 	ret = udp_check_socket_state(sc);
 	if (ret < 0)
 		goto fail;
-	ret = write_nonblock(sc->fd, buf, len);
+	ret = xwrite(sc->fd, buf, len);
 	if (ret == -ERRNO_TO_PARA_ERROR(ECONNREFUSED)) {
 		/*
 		 * Happens if meanwhile an ICMP Destination / Port Unreachable
@@ -295,10 +302,9 @@ static int udp_send_fec(struct sender_client *sc, char *buf, size_t len)
 	}
 	if (ret < 0)
 		goto fail;
-	return 1;
+	return;
 fail:
 	udp_delete_target(sc, para_strerror(-ret));
-	return ret;
 }
 
 static int udp_com_add(struct sender_command_data *scd)