X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=vss.c;h=06707d6cfee11a70089db3fd7ef230af454e1516;hp=3405d5a0600d27f359558be50f2cb1f853a0ab9e;hb=820ae21f7a453408dca3faa9ff1d28ca94d60009;hpb=fd62cf6f3c17ec9f504d3a05be4fd48f969dcb01

diff --git a/vss.c b/vss.c
index 3405d5a0..06707d6c 100644
--- a/vss.c
+++ b/vss.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 1997-2010 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 1997-2013 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -12,7 +12,6 @@
  */
 
 #include <regex.h>
-#include <dirent.h>
 #include <osl.h>
 
 #include "para.h"
@@ -27,10 +26,10 @@
 #include "server.cmdline.h"
 #include "list.h"
 #include "send.h"
+#include "sched.h"
 #include "vss.h"
 #include "ipc.h"
 #include "fd.h"
-#include "sched.h"
 
 extern struct misc_meta_data *mmd;
 
@@ -86,7 +85,7 @@ struct vss_task {
 	/** Used by the scheduler. */
 	struct task task;
 	/** Pointer to the header of the mapped audio file. */
-	const char *header_buf;
+	char *header_buf;
 	/** Length of the audio file header. */
 	size_t header_len;
 	/** Time between audio file headers are sent. */
@@ -133,6 +132,7 @@ struct fec_group {
 	uint16_t slice_bytes;
 };
 
+/** A FEC client is always in one of these states. */
 enum fec_client_state {
 	FEC_STATE_NONE = 0,	/**< not initialized and not enabled */
 	FEC_STATE_DISABLED,	/**< temporarily disabled */
@@ -167,6 +167,8 @@ struct fec_client {
 	struct timeval next_header_time;
 	/** Used for the last source pointer of an audio file. */
 	unsigned char *extra_src_buf;
+	/** Needed for the last slice of the audio file header. */
+	unsigned char *extra_header_buf;
 	/** Extra slices needed to store largest chunk + header. */
 	int num_extra_slices;
 	/** Contains the FEC-encoded data. */
@@ -211,10 +213,11 @@ static void write_fec_header(struct fec_client *fc, struct vss_task *vsst)
 	write_u32(buf + 14, g->bytes);
 
 	write_u8(buf + 18, fc->current_slice_num);
+	write_u8(buf + 19, 0); /* unused */
 	write_u16(buf + 20, g->slice_bytes);
 	write_u8(buf + 22, g->first_chunk? 0 : 1);
 	write_u8(buf + 23, vsst->header_len? 1 : 0);
-	memset(buf + 24, 0, 7);
+	memset(buf + 24, 0, 8);
 }
 
 static bool need_audio_header(struct fec_client *fc, struct vss_task *vsst)
@@ -227,12 +230,29 @@ static bool need_audio_header(struct fec_client *fc, struct vss_task *vsst)
 		return false;
 	if (vsst->header_len == 0)
 		return false;
-	if (fc->group.num && tv_diff(&fc->next_header_time, now, NULL) > 0)
-		return false;
+	if (fc->group.num > 0) {
+		if (!fc->fcp->need_periodic_header)
+			return false;
+		if (tv_diff(&fc->next_header_time, now, NULL) > 0)
+			return false;
+	}
 	tv_add(now, &vsst->header_interval, &fc->next_header_time);
 	return true;
 }
 
+static bool need_data_slices(struct fec_client *fc, struct vss_task *vsst)
+{
+	if (fc->group.num > 0)
+		return true;
+	if (!vsst->header_buf)
+		return true;
+	if (vsst->header_len == 0)
+		return true;
+	if (fc->fcp->need_periodic_header)
+		return true;
+	return false;
+}
+
 static int num_slices(long unsigned bytes, int max_payload, int rs)
 {
 	int ret;
@@ -246,11 +266,15 @@ static int num_slices(long unsigned bytes, int max_payload, int rs)
 }
 
 /* set group start and group duration */
-static void set_group_timing(struct fec_client *fc, struct fec_group *g)
+static void set_group_timing(struct fec_client *fc, struct vss_task *vsst)
 {
+	struct fec_group *g = &fc->group;
 	struct timeval *chunk_tv = vss_chunk_time();
 
-	tv_scale(g->num_chunks, chunk_tv, &g->duration);
+	if (!need_data_slices(fc, vsst))
+		ms2tv(200, &g->duration);
+	else
+		tv_scale(g->num_chunks, chunk_tv, &g->duration);
 	tv_divide(fc->fcp->slices_per_group + fc->num_extra_slices,
 		&g->duration, &g->slice_duration);
 	PARA_DEBUG_LOG("durations (group/chunk/slice): %lu/%lu/%lu\n",
@@ -282,13 +306,16 @@ static int initialize_fec_client(struct fec_client *fc, struct vss_task *vsst)
 	rs = fc->fcp->slices_per_group - fc->fcp->data_slices_per_group;
 	ret = num_slices(vsst->header_len, fc->mps - FEC_HEADER_SIZE, rs);
 	if (ret < 0)
-		goto err;
+		return ret;
 	hs = ret;
 	ret = num_slices(mmd->afd.max_chunk_size, fc->mps - FEC_HEADER_SIZE, rs);
 	if (ret < 0)
-		goto err;
+		return ret;
 	ds = ret;
-	k = hs + ds;
+	if (fc->fcp->need_periodic_header)
+		k = hs + ds;
+	else
+		k = PARA_MAX(hs, ds);
 	if (k < fc->fcp->data_slices_per_group)
 		k = fc->fcp->data_slices_per_group;
 	fc->num_extra_slices = k - fc->fcp->data_slices_per_group;
@@ -302,22 +329,49 @@ static int initialize_fec_client(struct fec_client *fc, struct vss_task *vsst)
 	fc->src_data = para_realloc(fc->src_data, k * sizeof(char *));
 	fc->enc_buf = para_realloc(fc->enc_buf, fc->mps);
 	fc->extra_src_buf = para_realloc(fc->extra_src_buf, fc->mps);
+	fc->extra_header_buf = para_realloc(fc->extra_header_buf, fc->mps);
 
 	fc->state = FEC_STATE_READY_TO_RUN;
 	fc->next_header_time.tv_sec = 0;
 	fc->stream_start = *now;
 	fc->first_stream_chunk = mmd->current_chunk;
 	return 1;
-err:
-	fec_free(fc->parms);
-	return ret;
+}
+
+static void vss_get_chunk(int chunk_num, struct vss_task *vsst,
+		char **buf, size_t *sz)
+{
+	/*
+	 * Chunk zero is special for header streams: It is the first portion of
+	 * the audio file which consists of the audio file header. It may be
+	 * arbitrary large due to embedded meta data. Audio format handlers may
+	 * replace the header by a stripped one with meta data omitted which is
+	 * of bounded size. We always use the stripped header for streaming
+	 * rather than the unmodified header (chunk zero).
+	 */
+	if (chunk_num == 0 && vsst->header_len > 0) {
+		*buf = vsst->header_buf; /* stripped header */
+		*sz = vsst->header_len;
+		return;
+	}
+	afh_get_chunk(chunk_num, &mmd->afd.afhi, vsst->map, (const char **)buf,
+		sz);
 }
 
 static void compute_group_size(struct vss_task *vsst, struct fec_group *g,
 		int max_bytes)
 {
+	char *buf;
+	size_t len;
 	int i, max_chunks = PARA_MAX(1LU, 150 / tv2ms(vss_chunk_time()));
 
+	if (g->first_chunk == 0) {
+		g->num_chunks = 1;
+		vss_get_chunk(0, vsst, &buf, &len);
+		g->bytes = len;
+		return;
+	}
+
 	g->num_chunks = 0;
 	g->bytes = 0;
 	/*
@@ -327,15 +381,13 @@ static void compute_group_size(struct vss_task *vsst, struct fec_group *g,
 	 * of exactly one chunk for these audio formats.
 	 */
 	for (i = 0;; i++) {
-		const char *buf;
-		size_t len;
 		int chunk_num = g->first_chunk + i;
 
 		if (g->bytes > 0 && i >= max_chunks) /* duration limit */
 			break;
 		if (chunk_num >= mmd->afd.afhi.chunks_total) /* eof */
 			break;
-		afh_get_chunk(chunk_num, &mmd->afd.afhi, vsst->map, &buf, &len);
+		vss_get_chunk(chunk_num, vsst, &buf, &len);
 		if (g->bytes + len > max_bytes)
 			break;
 		/* Include this chunk */
@@ -410,6 +462,13 @@ static int compute_slice_size(struct fec_client *fc, struct vss_task *vsst)
 			g->slice_bytes = 1;
 		return 1;
 	}
+	if (!need_data_slices(fc, vsst)) {
+		g->bytes = 0;
+		g->num_chunks = 0;
+		g->slice_bytes = DIV_ROUND_UP(vsst->header_len, k);
+		g->num_header_slices = k;
+		return 1;
+	}
 	h = vsst->header_len;
 	max_group_bytes = (k - num_slices(h, max_slice_bytes, n - k))
 		* max_slice_bytes;
@@ -450,7 +509,7 @@ static int setup_next_fec_group(struct fec_client *fc, struct vss_task *vsst)
 {
 	int ret, i, k, n, data_slices;
 	size_t len;
-	const char *buf;
+	char *buf, *p;
 	struct fec_group *g = &fc->group;
 
 	if (fc->state == FEC_STATE_NONE) {
@@ -470,7 +529,7 @@ static int setup_next_fec_group(struct fec_client *fc, struct vss_task *vsst)
 		 */
 		tmp = g->start;
 		tv_add(&tmp, &g->duration, &g->start);
-		set_group_timing(fc, g);
+		set_group_timing(fc, vsst);
 		g->first_chunk += g->num_chunks;
 		g->num++;
 	}
@@ -486,26 +545,50 @@ static int setup_next_fec_group(struct fec_client *fc, struct vss_task *vsst)
 	assert(g->num_header_slices + data_slices <= k);
 	fc->current_slice_num = 0;
 	if (g->num == 0)
-		set_group_timing(fc, g);
-
+		set_group_timing(fc, vsst);
 	/* setup header slices */
 	buf = vsst->header_buf;
 	for (i = 0; i < g->num_header_slices; i++) {
-		fc->src_data[i] = (const unsigned char *)buf;
-		buf += g->slice_bytes;
+		uint32_t payload_size;
+		if (buf + g->slice_bytes <= vsst->header_buf + vsst->header_len) {
+			fc->src_data[i] = (const unsigned char *)buf;
+			buf += g->slice_bytes;
+			continue;
+		}
+		/*
+		 * Can not use vss->header_buf for this slice as it
+		 * goes beyond the buffer. This slice will not be fully
+		 * used.
+		 */
+		payload_size = vsst->header_buf + vsst->header_len - buf;
+		memcpy(fc->extra_header_buf, buf, payload_size);
+		if (payload_size < g->slice_bytes)
+			memset(fc->extra_header_buf + payload_size, 0,
+				g->slice_bytes - payload_size);
+		/*
+		 * There might be more than one header slice to fill although
+		 * only the first one will be used. Set all header slices to
+		 * our extra buffer.
+		 */
+		while (i < g->num_header_slices)
+			fc->src_data[i++] = fc->extra_header_buf;
+		break; /* we don't want i to be increased. */
 	}
 
-	/* setup data slices */
-	afh_get_chunk(g->first_chunk, &mmd->afd.afhi, vsst->map, &buf, &len);
-	for (; i < g->num_header_slices + data_slices; i++) {
-		if (buf + g->slice_bytes > vsst->map + mmd->size) {
+	/*
+	 * Setup data slices. Note that for ogg streams chunk 0 points to a
+	 * buffer on the heap rather than to the mapped audio file.
+	 */
+	vss_get_chunk(g->first_chunk, vsst, &buf, &len);
+	for (p = buf; i < g->num_header_slices + data_slices; i++) {
+		if (p + g->slice_bytes > buf + g->bytes) {
 			/*
-			 * Can not use the memory mapped audio file for this
-			 * slice as it goes beyond the map. This slice will not
-			 * be fully used.
+			 * We must make a copy for this slice since using p
+			 * directly would exceed the buffer.
 			 */
-			uint32_t payload_size = vsst->map + mmd->size - buf;
-			memcpy(fc->extra_src_buf, buf, payload_size);
+			uint32_t payload_size = buf + g->bytes - p;
+			assert(payload_size + FEC_HEADER_SIZE <= fc->mps);
+			memcpy(fc->extra_src_buf, p, payload_size);
 			if (payload_size < g->slice_bytes)
 				memset(fc->extra_src_buf + payload_size, 0,
 					g->slice_bytes - payload_size);
@@ -513,8 +596,8 @@ static int setup_next_fec_group(struct fec_client *fc, struct vss_task *vsst)
 			i++;
 			break;
 		}
-		fc->src_data[i] = (const unsigned char *)buf;
-		buf += g->slice_bytes;
+		fc->src_data[i] = (const unsigned char *)p;
+		p += g->slice_bytes;
 	}
 	if (i < k) {
 		/* use arbitrary data for all remaining slices */
@@ -598,6 +681,7 @@ void vss_del_fec_client(struct fec_client *fc)
 	free(fc->src_data);
 	free(fc->enc_buf);
 	free(fc->extra_src_buf);
+	free(fc->extra_header_buf);
 	fec_free(fc->parms);
 	free(fc);
 }
@@ -622,26 +706,6 @@ static int next_slice_is_due(struct fec_client *fc, struct timeval *diff)
 	return ret < 0? 1 : 0;
 }
 
-static void compute_slice_timeout(struct timeval *timeout)
-{
-	struct fec_client *fc;
-
-	list_for_each_entry(fc, &fec_client_list, node) {
-		struct timeval diff;
-
-		if (fc->state != FEC_STATE_READY_TO_RUN)
-			continue;
-		if (next_slice_is_due(fc, &diff)) {
-			timeout->tv_sec = 0;
-			timeout->tv_usec = 0;
-			return;
-		}
-		/* timeout = min(timeout, diff) */
-		if (tv_diff(&diff, timeout, NULL) < 0)
-			*timeout = diff;
-	}
-}
-
 static void set_eof_barrier(struct vss_task *vsst)
 {
 	struct fec_client *fc;
@@ -732,42 +796,38 @@ static int chk_barrier(const char *bname, const struct timeval *barrier,
 	return -1;
 }
 
-/*
- * != NULL: timeout for next chunk
- * NULL: nothing to do
- */
-static struct timeval *vss_compute_timeout(struct vss_task *vsst)
+static void vss_compute_timeout(struct sched *s, struct vss_task *vsst)
 {
-	static struct timeval the_timeout;
-	struct timeval next_chunk;
-
-	if (vss_next() && vsst->map) {
-		/* only sleep a bit, nec*/
-		the_timeout.tv_sec = 0;
-		the_timeout.tv_usec = 100;
-		return &the_timeout;
-	}
-	if (chk_barrier("autoplay_delay", &vsst->autoplay_barrier,
-			&the_timeout, 1) < 0)
-		return &the_timeout;
-	if (chk_barrier("eof", &vsst->eof_barrier, &the_timeout, 1) < 0)
-		return &the_timeout;
-	if (chk_barrier("data send", &vsst->data_send_barrier,
-			&the_timeout, 1) < 0)
-		return &the_timeout;
+	struct timeval tv;
+	struct fec_client *fc;
+
 	if (!vss_playing() || !vsst->map)
-		return NULL;
+		return;
+	if (vss_next() && vsst->map) /* only sleep a bit, nec*/
+		return sched_request_timeout_ms(100, s);
+
+	/* Each of these barriers must have passed until we may proceed */
+	if (sched_request_barrier(&vsst->autoplay_barrier, s) == 1)
+		return;
+	if (sched_request_barrier(&vsst->eof_barrier, s) == 1)
+		return;
+	if (sched_request_barrier(&vsst->data_send_barrier, s) == 1)
+		return;
+	/*
+	 * Compute the select timeout as the minimal time until the next
+	 * chunk/slice is due for any client.
+	 */
 	compute_chunk_time(mmd->chunks_sent, &mmd->afd.afhi.chunk_tv,
-		&mmd->stream_start, &next_chunk);
-	if (chk_barrier("chunk", &next_chunk, &the_timeout, 0) >= 0) {
-		/* chunk is due or bof */
-		the_timeout.tv_sec = 0;
-		the_timeout.tv_usec = 0;
-		return &the_timeout;
+		&mmd->stream_start, &tv);
+	if (sched_request_barrier_or_min_delay(&tv, s) == 0)
+		return;
+	list_for_each_entry(fc, &fec_client_list, node) {
+		if (fc->state != FEC_STATE_READY_TO_RUN)
+			continue;
+		if (next_slice_is_due(fc, &tv))
+			return sched_min_delay(s);
+		sched_request_timeout(&tv, s);
 	}
-	/* compute min of current timeout and next slice time */
-	compute_slice_timeout(&the_timeout);
-	return &the_timeout;
 }
 
 static void vss_eof(struct vss_task *vsst)
@@ -778,6 +838,8 @@ static void vss_eof(struct vss_task *vsst)
 	if (mmd->new_vss_status_flags & VSS_NOMORE)
 		mmd->new_vss_status_flags = VSS_NEXT;
 	set_eof_barrier(vsst);
+	afh_free_header(vsst->header_buf, mmd->afd.audio_format_id);
+	vsst->header_buf = NULL;
 	para_munmap(vsst->map, mmd->size);
 	vsst->map = NULL;
 	mmd->chunks_sent = 0;
@@ -834,7 +896,6 @@ static void set_mmd_offset(void)
 static void vss_pre_select(struct sched *s, struct task *t)
 {
 	int i;
-	struct timeval *tv;
 	struct vss_task *vsst = container_of(t, struct vss_task, task);
 
 	if (!vsst->map || vss_next() || vss_paused() || vss_repos()) {
@@ -872,9 +933,7 @@ static void vss_pre_select(struct sched *s, struct task *t)
 			continue;
 		senders[i].pre_select(&s->max_fileno, &s->rfds, &s->wfds);
 	}
-	tv = vss_compute_timeout(vsst);
-	if (tv)
-		sched_request_timeout(tv, s);
+	vss_compute_timeout(s, vsst);
 }
 
 static int recv_afs_msg(int afs_socket, int *fd, uint32_t *code, uint32_t *data)
@@ -911,6 +970,10 @@ static int recv_afs_msg(int afs_socket, int *fd, uint32_t *code, uint32_t *data)
 	return 1;
 }
 
+#ifndef MAP_POPULATE
+#define MAP_POPULATE 0
+#endif
+
 static void recv_afs_result(struct vss_task *vsst, fd_set *rfds)
 {
 	int ret, passed_fd, shmid;
@@ -945,8 +1008,8 @@ static void recv_afs_result(struct vss_task *vsst, fd_set *rfds)
 	}
 	mmd->size = statbuf.st_size;
 	mmd->mtime = statbuf.st_mtime;
-	ret = para_mmap(mmd->size, PROT_READ, MAP_PRIVATE, passed_fd,
-		0, &vsst->map);
+	ret = para_mmap(mmd->size, PROT_READ, MAP_PRIVATE | MAP_POPULATE,
+		passed_fd, 0, &vsst->map);
 	if (ret < 0)
 		goto err;
 	close(passed_fd);
@@ -956,8 +1019,8 @@ static void recv_afs_result(struct vss_task *vsst, fd_set *rfds)
 	mmd->events++;
 	mmd->num_played++;
 	mmd->new_vss_status_flags &= (~VSS_NEXT);
-	afh_get_header(&mmd->afd.afhi, vsst->map, &vsst->header_buf,
-		&vsst->header_len);
+	afh_get_header(&mmd->afd.afhi, mmd->afd.audio_format_id,
+		vsst->map, mmd->size, &vsst->header_buf, &vsst->header_len);
 	return;
 err:
 	free(mmd->afd.afhi.chunk_table);
@@ -1013,7 +1076,7 @@ static void vss_send(struct vss_task *vsst)
 	compute_chunk_time(mmd->chunks_sent, &mmd->afd.afhi.chunk_tv,
 		&mmd->stream_start, &due);
 	if (tv_diff(&due, now, NULL) <= 0) {
-		const char *buf;
+		char *buf;
 		size_t len;
 
 		if (!mmd->chunks_sent) {
@@ -1026,25 +1089,42 @@ static void vss_send(struct vss_task *vsst)
 		 * they might have still some data queued which can be sent in
 		 * this case.
 		 */
-		afh_get_chunk(mmd->current_chunk, &mmd->afd.afhi, vsst->map,
-			&buf, &len);
+		vss_get_chunk(mmd->current_chunk, vsst, &buf, &len);
 		for (i = 0; senders[i].name; i++) {
 			if (!senders[i].send)
 				continue;
 			senders[i].send(mmd->current_chunk, mmd->chunks_sent,
 				buf, len, vsst->header_buf, vsst->header_len);
 		}
+		/*
+		 * Prefault next chunk(s)
+		 *
+		 * If the backing device of the memory-mapped audio file is
+		 * slow and read-ahead is turned off or prevented for some
+		 * reason, e.g. due to memory pressure, it may take much longer
+		 * than the chunk interval to get the next chunk on the wire,
+		 * causing buffer underruns on the client side. Mapping the
+		 * file with MAP_POPULATE seems to help a bit, but it does not
+		 * eliminate the delays completely. Moreover, it is supported
+		 * only on Linux. So we do our own read-ahead here.
+		 */
+		if (mmd->current_chunk > 0) { /* chunk 0 might be on the heap */
+			buf += len;
+			for (i = 0; i < 5 && buf < vsst->map + mmd->size; i++) {
+				__a_unused volatile char x = *buf;
+				buf += 4096;
+			}
+		}
 		mmd->chunks_sent++;
 		mmd->current_chunk++;
 	}
 }
 
-static void vss_post_select(struct sched *s, struct task *t)
+static int vss_post_select(struct sched *s, struct task *t)
 {
 	int ret, i;
 	struct vss_task *vsst = container_of(t, struct vss_task, task);
 
-
 	if (mmd->sender_cmd_data.cmd_num >= 0) {
 		int num = mmd->sender_cmd_data.cmd_num,
 			sender_num = mmd->sender_cmd_data.sender_num;
@@ -1061,7 +1141,7 @@ static void vss_post_select(struct sched *s, struct task *t)
 		recv_afs_result(vsst, &s->rfds);
 	else if (FD_ISSET(vsst->afs_socket, &s->wfds)) {
 		PARA_NOTICE_LOG("requesting new fd from afs\n");
-		ret = send_buffer(vsst->afs_socket, "new");
+		ret = write_buffer(vsst->afs_socket, "new");
 		if (ret < 0)
 			PARA_CRIT_LOG("%s\n", para_strerror(-ret));
 		else
@@ -1076,17 +1156,19 @@ static void vss_post_select(struct sched *s, struct task *t)
 			(vss_next() && vss_playing()))
 		tv_add(now, &vsst->announce_tv, &vsst->data_send_barrier);
 	vss_send(vsst);
+	return 0;
 }
 
 /**
  * Initialize the virtual streaming system task.
  *
  * \param afs_socket The fd for communication with afs.
+ * \param s The scheduler to register the vss task to.
  *
  * This also initializes all supported senders and starts streaming
  * if the --autoplay command line flag was given.
  */
-void init_vss_task(int afs_socket)
+void init_vss_task(int afs_socket, struct sched *s)
 {
 	static struct vss_task vss_task_struct, *vsst = &vss_task_struct;
 	int i;
@@ -1118,5 +1200,6 @@ void init_vss_task(int afs_socket)
 		tv_add(&vsst->autoplay_barrier, &vsst->announce_tv,
 			&vsst->data_send_barrier);
 	}
-	register_task(&vsst->task);
+	sprintf(vsst->task.status, "vss task");
+	register_task(s, &vsst->task);
 }