X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=wma_afh.c;h=63e49677b0f1b85c13c17160a7b249531c1fbcd4;hp=b4935f0d44f30fc6091f8431b99a63f23674aed6;hb=73a77d2b8293081f7bda2838242935bd74aebbe0;hpb=1b9bf429a91f4c9fc1abc6030b02ca0c7739bca8

diff --git a/wma_afh.c b/wma_afh.c
index b4935f0d..63e49677 100644
--- a/wma_afh.c
+++ b/wma_afh.c
@@ -1,8 +1,4 @@
-/*
- * Copyright (C) 2009 Andre Noll <maan@tuebingen.mpg.de>
- *
- * Licensed under the GPL v2. For licencing details see COPYING.
- */
+/* Copyright (C) 2009 Andre Noll <maan@tuebingen.mpg.de>, see file COPYING. */
 
 /** \file wma_afh.c The audio format handler for WMA files. */
 
@@ -38,8 +34,7 @@ static int count_frames(const char *buf, int buf_size, uint32_t packet_size,
 		sfc++;
 	}
 	PARA_INFO_LOG("%d frames, %d superframes\n", fc, sfc);
-	if (num_superframes)
-		*num_superframes = sfc;
+	*num_superframes = sfc;
 	return fc;
 }
 
@@ -68,7 +63,7 @@ static int put_utf8(uint32_t val, char *result)
 		*out++ = in;
 		return 1;
 	}
-	bytes = (wma_log2(in) + 4) / 5;
+	bytes = DIV_ROUND_UP(wma_log2(in), 5);
 	shift = (bytes - 1) * 6;
 	*out++ = (256 - (256 >> bytes)) | (in >> shift);
 	while (shift >= 6) {
@@ -229,6 +224,7 @@ static int wma_make_chunk_table(char *buf, size_t buf_size, uint32_t packet_size
 		}
 	}
 	afhi->chunks_total = j;
+	set_max_chunk_size(afhi);
 	set_chunk_tv(frames_per_chunk, afhi->frequency, &afhi->chunk_tv);
 	return 1;
 fail:
@@ -365,8 +361,7 @@ static int make_cdo(struct taginfo *tags, const struct asf_object *cdo,
 		struct asf_object *result)
 {
 	const char *cr, *rating; /* orig data */
-	uint16_t orig_title_bytes, orig_artist_bytes, orig_cr_bytes,
-		orig_comment_bytes, orig_rating_bytes;
+	uint16_t orig_cr_bytes, orig_rating_bytes;
 	/* pointers to new UTF-16 tags */
 	char *artist = NULL, *title = NULL, *comment = NULL;
 	/* number of bytes in UTF-16 for the new tags */
@@ -378,17 +373,21 @@ static int make_cdo(struct taginfo *tags, const struct asf_object *cdo,
 	ret = convert_utf8_to_utf16(tags->artist, &artist);
 	if (ret < 0)
 		return ret;
+	assert(artist);
 	artist_bytes = ret;
 	ret = convert_utf8_to_utf16(tags->title, &title);
 	if (ret < 0)
 		goto out;
+	assert(title);
 	title_bytes = ret;
 	ret = convert_utf8_to_utf16(tags->comment, &comment);
 	if (ret < 0)
 		goto out;
+	assert(comment);
 	comment_bytes = ret;
 
 	if (cdo) {
+		uint16_t orig_title_bytes, orig_artist_bytes, orig_comment_bytes;
 		/*
 		 * Sizes of the five fields (stored as 16-bit numbers) are
 		 * located after the header (16 bytes) and the cdo size (8
@@ -402,10 +401,7 @@ static int make_cdo(struct taginfo *tags, const struct asf_object *cdo,
 		cr = cdo->ptr + 34 + orig_title_bytes + orig_artist_bytes;
 		rating = cr + orig_cr_bytes + orig_comment_bytes;
 	} else {
-		orig_title_bytes = 2;
-		orig_artist_bytes = 2;
 		orig_cr_bytes = 2;
-		orig_comment_bytes = 2;
 		orig_rating_bytes = 2;
 		cr = null;
 		rating = null;
@@ -461,10 +457,12 @@ static int make_ecdo(struct taginfo *tags, struct asf_object *result)
 	ret = convert_utf8_to_utf16(tags->album, &album);
 	if (ret < 0)
 		return ret;
+	assert(album);
 	album_bytes = ret;
 	ret = convert_utf8_to_utf16(tags->year, &year);
 	if (ret < 0)
 		goto out;
+	assert(year);
 	year_bytes = ret;
 	result->size = 16 + 8 + 2; /* GUID, size, count */
 	/* name_length + name + null + data type + val length + val */
@@ -648,13 +646,13 @@ out:
 static const char * const wma_suffixes[] = {"wma", NULL};
 
 /**
- * The init function of the wma audio format handler.
+ * The audio format handler for Windows Media Audio.
  *
- * \param afh Pointer to the struct to initialize.
+ * Only WMA version 2 is supported. This audio format handler does not depend
+ * on any third party libraries and is therefore always compiled in.
  */
-void wma_afh_init(struct audio_format_handler *afh)
-{
-	afh->get_file_info = wma_get_file_info;
-	afh->suffixes = wma_suffixes;
-	afh->rewrite_tags = wma_rewrite_tags;
-}
+const struct audio_format_handler wma_afh = {
+	.get_file_info = wma_get_file_info,
+	.suffixes = wma_suffixes,
+	.rewrite_tags = wma_rewrite_tags,
+};