X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=wmadec_filter.c;h=7d89d112a53d074cf3538cf890062b7afa87278c;hp=0ec5878c3a836d389ebac7a7188bcdb809ddcc25;hb=d16fe3df649cb48d5ffa26187da3dad4c3066646;hpb=c09e475689a31b2f11a51faf379c72b9d0be73ab

diff --git a/wmadec_filter.c b/wmadec_filter.c
index 0ec5878c..7d89d112 100644
--- a/wmadec_filter.c
+++ b/wmadec_filter.c
@@ -25,7 +25,6 @@
 #include <string.h>
 #include <regex.h>
 #include <sys/select.h>
-#include <stdbool.h>
 
 #include "para.h"
 #include "error.h"
@@ -142,15 +141,15 @@ struct private_wmadec_data {
 };
 
 #define EXPVLCBITS 8
-#define EXPMAX ((19 + EXPVLCBITS - 1) / EXPVLCBITS)
+#define EXPMAX DIV_ROUND_UP(19, EXPVLCBITS)
 
 #define HGAINVLCBITS 9
-#define HGAINMAX ((13 + HGAINVLCBITS - 1) / HGAINVLCBITS)
+#define HGAINMAX DIV_ROUND_UP(13, HGAINVLCBITS)
 
 #define VLCBITS 9
-#define VLCMAX ((22 + VLCBITS - 1) / VLCBITS)
+#define VLCMAX DIV_ROUND_UP(22, VLCBITS)
 
-#define SINE_WINDOW(x) float sine_ ## x[x] __a_aligned(16)
+#define SINE_WINDOW(x) static float sine_ ## x[x] __a_aligned(16)
 
 SINE_WINDOW(128);
 SINE_WINDOW(256);
@@ -769,7 +768,6 @@ static void compute_mdct_coefficients(struct private_wmadec_data *pwd,
 				*coefs++ = 0.0;
 			continue;
 		}
-		mult1 = mult;
 		n1 = pwd->exponent_high_sizes[bsize];
 		/* compute power of high bands */
 		exponents = pwd->exponents[ch] +
@@ -803,8 +801,7 @@ static void compute_mdct_coefficients(struct private_wmadec_data *pwd,
 				mult1 = sqrt(exp_power[j]
 					/ exp_power[last_high_band]);
 				/* XXX: use a table */
-				mult1 = mult1 * pow(10,
-					pwd->high_band_values[ch][j] * 0.05);
+				mult1 *= pow(10, pwd->high_band_values[ch][j] * 0.05);
 				mult1 /= (pwd->max_exponent[ch] * pwd->noise_mult);
 				mult1 *= mdct_norm;
 				for (i = 0; i < n; i++) {
@@ -1010,9 +1007,8 @@ static int wma_decode_block(struct private_wmadec_data *pwd)
 	}
 next:
 	for (ch = 0; ch < pwd->ahi.channels; ch++) {
-		int n4, index;
+		int n4, idx;
 
-		n = pwd->block_len;
 		n4 = pwd->block_len / 2;
 		if (pwd->channel_coded[ch])
 			imdct(pwd->mdct_ctx[bsize], pwd->output, pwd->coefs[ch]);
@@ -1020,8 +1016,8 @@ next:
 			memset(pwd->output, 0, sizeof(pwd->output));
 
 		/* multiply by the window and add in the frame */
-		index = (pwd->frame_len / 2) + pwd->block_pos - n4;
-		wma_window(pwd, &pwd->frame_out[ch][index]);
+		idx = (pwd->frame_len / 2) + pwd->block_pos - n4;
+		wma_window(pwd, &pwd->frame_out[ch][idx]);
 	}
 
 	/* update block number */
@@ -1199,8 +1195,6 @@ static void wmadec_close(struct filter_node *fn)
 	if (!pwd)
 		return;
 	wmadec_cleanup(pwd);
-	free(fn->buf);
-	fn->buf = NULL;
 	free(fn->private_data);
 	fn->private_data = NULL;
 }
@@ -1210,19 +1204,8 @@ static int wmadec_execute(struct btr_node *btrn, const char *cmd, char **result)
 	struct filter_node *fn = btr_context(btrn);
 	struct private_wmadec_data *pwd = fn->private_data;
 
-	if (!strcmp(cmd, "samplerate")) {
-		if (pwd->ahi.sample_rate == 0)
-			return -ERRNO_TO_PARA_ERROR(ENAVAIL);
-		*result = make_message("%u", pwd->ahi.sample_rate);
-		return 1;
-	}
-	if (!strcmp(cmd, "channels")) {
-		if (pwd->ahi.channels == 0)
-			return -ERRNO_TO_PARA_ERROR(ENAVAIL);
-		*result = make_message("%u", pwd->ahi.channels);
-		return 1;
-	}
-	return -ERRNO_TO_PARA_ERROR(ENOTSUP);
+	return decoder_execute(cmd, pwd->ahi.sample_rate, pwd->ahi.channels,
+		result);
 }
 
 #define WMA_OUTPUT_BUFFER_SIZE (128 * 1024)
@@ -1257,11 +1240,12 @@ next_buffer:
 			fn->min_iqs += 4096;
 			goto next_buffer;
 		}
-		fn->min_iqs = WMA_FRAME_SKIP + pwd->ahi.block_align;
+		fn->min_iqs = 2 * (WMA_FRAME_SKIP + pwd->ahi.block_align);
 		fn->private_data = pwd;
 		converted = pwd->ahi.header_len;
 		goto success;
 	}
+	fn->min_iqs = WMA_FRAME_SKIP + pwd->ahi.block_align;
 	for (;;) {
 		char *out;
 		int out_size = WMA_OUTPUT_BUFFER_SIZE;
@@ -1280,7 +1264,7 @@ next_buffer:
 	}
 success:
 	btr_consume(btrn, converted);
-	goto next_buffer;
+	return;
 err:
 	assert(ret < 0);
 	t->error = ret;
@@ -1289,10 +1273,7 @@ err:
 
 static void wmadec_open(struct filter_node *fn)
 {
-	fn->bufsize = 1024 * 1024;
-	fn->buf = para_malloc(fn->bufsize);
 	fn->private_data = NULL;
-	fn->loaded = 0;
 	fn->min_iqs = 4096;
 }