X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=write_common.c;h=316c87ef1f818469c061cf9dc12635d1613fd4ad;hp=dcf7bb166ade3f9efa4d04afd4fb55e67e9c2d8e;hb=f8f6605a4f02a15378a36618dbfacfc862fc6192;hpb=318fbe90e08b6d9c5e781d9b517b670c5a1a04d7

diff --git a/write_common.c b/write_common.c
index dcf7bb16..316c87ef 100644
--- a/write_common.c
+++ b/write_common.c
@@ -27,6 +27,8 @@ static void wng_pre_select(__a_unused struct sched *s, struct task *t)
 
 	FOR_EACH_WRITER_NODE(i, g) {
 		struct writer_node *wn = &g->writer_nodes[i];
+		if (!wn->writer->pre_select)
+			continue;
 		t->error = wn->writer->pre_select(s, wn);
 		if (t->error < 0)
 			return;
@@ -97,7 +99,9 @@ err_out:
 		struct writer_node *wn = &g->writer_nodes[--i];
 		wn->writer->close(wn);
 	}
+	free(g->writer_nodes);
 	g->num_writers = 0;
+	g->task.error = -E_TASK_UNREGISTERED;
 	return ret;
 }
 
@@ -209,7 +213,11 @@ struct writer_node_group *setup_default_wng(void)
 	wng->writer_nodes[0].conf = writers[DEFAULT_WRITER].parse_config("");
 	return wng;
 }
-
+/**
+ * Print the help text of all writers to stdout.
+ *
+ * \param detailed Whether to print the detailed help text.
+ */
 void print_writer_helps(int detailed)
 {
 	int i;