X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=blobdiff_plain;f=write_common.c;h=602f94d893940aae8db06954f493919113eb4b57;hp=5988faf77a5cd13f1b4e1930299b8c90073efc3d;hb=8fa50e3e39b4f65dea2a694dc064038a41036642;hpb=92f089b820b45a5dbdc5b4f69d596105d5acba68

diff --git a/write_common.c b/write_common.c
index 5988faf7..602f94d8 100644
--- a/write_common.c
+++ b/write_common.c
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2006-2011 Andre Noll <maan@systemlinux.org>
+ * Copyright (C) 2006-2012 Andre Noll <maan@systemlinux.org>
  *
  * Licensed under the GPL v2. For licencing details see COPYING.
  */
@@ -7,7 +7,6 @@
 /** \file write_common.c common functions of para_audiod and para_write */
 
 #include <regex.h>
-#include <stdbool.h>
 
 #include "para.h"
 #include "string.h"
@@ -35,10 +34,10 @@ void writer_init(void)
 		writers[i].init(&writers[i]);
 }
 /**
- * check if given string is a valid command line for any writer
+ * Check if given string is a valid command line for any writer.
  *
- * \param \wa string of the form writer_name:options
- * \param writer_num contains the number of the writer upon success
+ * \param \wa String of the form writer_name:options.
+ * \param writer_num Contains the number of the writer upon success.
  *
  * This function checks whether \a wa starts with the name of a supported
  * paraslash writer, optionally followed by a colon and any options for that
@@ -47,30 +46,50 @@ void writer_init(void)
  *
  * \return On success, a pointer to the gengetopt args info struct is returned
  * and \a writer_num contains the number of the writer. Otherwise this function
- * returns \p NULL.
+ * prints an error message and calls exit().
  */
-void *check_writer_arg(const char *wa, int *writer_num)
+void *check_writer_arg_or_die(const char *wa, int *writer_num)
 {
-	int i;
-
-	*writer_num = -E_WRITE_COMMON_SYNTAX;
-	PARA_INFO_LOG("checking  %s\n", wa);
+	int i, ret, argc;
+	const char *cmdline;
+	char **argv;
+	void *conf;
+
+	if (!wa || !*wa) {
+		i = DEFAULT_WRITER;
+		cmdline = NULL;
+		goto check;
+	}
+	PARA_INFO_LOG("checking %s\n", wa);
 	FOR_EACH_WRITER(i) {
 		const char *name = writer_names[i];
 		size_t len = strlen(name);
 		char c;
+
 		if (strlen(wa) < len)
 			continue;
 		if (strncmp(name, wa, len))
 			continue;
 		c = wa[len];
-		if (c && c != ' ')
-			continue;
-		*writer_num = i;
-		return writers[i].parse_config_or_die(c? wa + len + 1 : "");
+		if (!c || c == ' ') {
+			cmdline = c? wa + len + 1 : NULL;
+			goto check;
+		}
 	}
-	PARA_ERROR_LOG("writer not found\n");
-	return NULL;
+	PARA_EMERG_LOG("invalid writer %s\n", wa);
+	exit(EXIT_FAILURE);
+check:
+	ret = create_shifted_argv(cmdline, " \t", &argv);
+	if (ret < 0) {
+		PARA_EMERG_LOG("%s: %s\n", wa, para_strerror(-ret));
+		exit(EXIT_FAILURE);
+	}
+	argc = ret;
+	argv[0] = make_message("%s_write", writer_names[i]);
+	*writer_num = i;
+	conf = writers[i].parse_config_or_die(argc, argv);
+	free_argv(argv);
+	return conf;
 }
 
 /**
@@ -78,11 +97,13 @@ void *check_writer_arg(const char *wa, int *writer_num)
  *
  * \param wn The writer node to open.
  * \param parent The parent btr node (the source for the writer node).
+ * \param s The scheduler instance to register the task to.
  *
  * The configuration of the writer node stored in \p wn->conf must be
  * initialized before this function may be called.
  */
-void register_writer_node(struct writer_node *wn, struct btr_node *parent)
+void register_writer_node(struct writer_node *wn, struct btr_node *parent,
+		struct sched *s)
 {
 	struct writer *w = writers + wn->writer_num;
 	char *name = make_message("%s writer", writer_names[wn->writer_num]);
@@ -94,38 +115,7 @@ void register_writer_node(struct writer_node *wn, struct btr_node *parent)
 	free(name);
 	wn->task.post_select = w->post_select;
 	wn->task.pre_select = w->pre_select;
-	register_task(&wn->task);
-}
-
-/**
- * Setup a writer node with the default writer.
- *
- * If arg is \p NULL, the OS-dependent default writer is used with an empty
- * configuration string.  It defaults to alsa for Linux, osx for OS X, oss for
- * *BSD and the file writer if neither of these is supported.
- *
- * Once the writer configuration has been retrieved, a writer node is created,
- * its buffer tree node is added to the buffer tree as a child of the given
- * parent.
- *
- * Finally, the new writer node's taks structure is initialized and registered
- * to the paraslash scheduler.
- *
- * \return A pointer to the allocated writer node group.
- */
-int setup_writer_node(const char *arg, struct btr_node *parent,
-		struct writer_node *wn)
-{
-	if (arg)
-		wn->conf = check_writer_arg(arg, &wn->writer_num);
-	else {
-		wn->writer_num = DEFAULT_WRITER;
-		wn->conf = writers[DEFAULT_WRITER].parse_config_or_die("");
-	}
-	if (!wn->conf)
-		return -E_WRITE_COMMON_SYNTAX;
-	register_writer_node(wn, parent);
-	return 1;
+	register_task(s, &wn->task);
 }
 
 /**