]> git.tuebingen.mpg.de Git - paraslash.git/commit
mp4: Make most loop variables unsigned.
authorAndre Noll <maan@tuebingen.mpg.de>
Thu, 26 Aug 2021 19:39:31 +0000 (21:39 +0200)
committerAndre Noll <maan@tuebingen.mpg.de>
Mon, 6 Jun 2022 14:30:15 +0000 (16:30 +0200)
commitb540913d5c85386eede1c10930e14219fb7e1fea
tree7dec7299168c619317c795f1fac5fa00478bc7a4
parente4fe9f0acfaf73694f6070d5bda7f14844f61a77
mp4: Make most loop variables unsigned.

If the loop variable iterates from zero to some number stored in a
variable of unsigned type, the loop variable should be of the same
unsigned type. This was not always the case, and if it was, the loop
variable was sometimes called i, which is confusing because i usually
indicates a signed quantity.

Quoting Andrew Morton:

Doing "unsigned i;" is an act of insane vandalism, punishable by
spending five additional years coding in fortran.
mp4.c