wng_open(): Defer registering the wng task.
authorAndre Noll <maan@systemlinux.org>
Tue, 1 Apr 2008 20:05:46 +0000 (22:05 +0200)
committerAndre Noll <maan@systemlinux.org>
Tue, 1 Apr 2008 20:05:46 +0000 (22:05 +0200)
This way we do not have to unregister it on errors.

write_common.c

index f9560d7f1ee1050439f16459a6fda786647d9250..037bb7286e5bb70a5d3830cbe2968bb730417711 100644 (file)
@@ -79,7 +79,6 @@ int wng_open(struct writer_node_group *g)
        int i, ret = 1;
 
        PARA_NOTICE_LOG("opening wng %p with %d writer(s)\n", g, g->num_writers);
        int i, ret = 1;
 
        PARA_NOTICE_LOG("opening wng %p with %d writer(s)\n", g, g->num_writers);
-       register_task(&g->task);
        FOR_EACH_WRITER_NODE(i, g) {
                struct writer_node *wn = &g->writer_nodes[i];
                wn->wng = g;
        FOR_EACH_WRITER_NODE(i, g) {
                struct writer_node *wn = &g->writer_nodes[i];
                wn->wng = g;
@@ -90,10 +89,10 @@ int wng_open(struct writer_node_group *g)
                g->max_chunk_bytes = PARA_MAX(g->max_chunk_bytes, ret);
        }
        sprintf(g->task.status, "%s", "writer node group");
                g->max_chunk_bytes = PARA_MAX(g->max_chunk_bytes, ret);
        }
        sprintf(g->task.status, "%s", "writer node group");
+       register_task(&g->task);
        return 1;
 err_out:
        PARA_ERROR_LOG("%s\n", para_strerror(-ret));
        return 1;
 err_out:
        PARA_ERROR_LOG("%s\n", para_strerror(-ret));
-       unregister_task(&g->task);
        while (i > 0) {
                struct writer_node *wn = &g->writer_nodes[--i];
                wn->writer->close(wn);
        while (i > 0) {
                struct writer_node *wn = &g->writer_nodes[--i];
                wn->writer->close(wn);