mood.c: Avoid overflow in update_quadratic_deviation().

The last multiplication of the expression returned can overflow. This
patch replaces the expression by an equivalent one which avoids to
multiply large numbers.

diff --git a/mood.c b/mood.c
index 415e1702a75f038694b53393d8674c426b1314c6..45b051a7267cdd9cd1a9049a00685a150681a1cb 100644 (file)
--- a/mood.c
+++ b/mood.c
@@ -652,7 +652,8 @@ static int add_if_admissible(struct osl_row *aft_row, void *data)
  * the last number a_n was replaced by b) may be computed in O(1) time in terms
  * of n, q, a_n, b, and S as
  *
  * the last number a_n was replaced by b) may be computed in O(1) time in terms
  * of n, q, a_n, b, and S as
  *

- *     q' = q + d * s - (2 * S + d) * d / n,
+ *     q' = q + d * s - (2 * S + d) * d / n
+ *        = q + d * (s - 2 * S / n - d /n),

  *
  * where d = b - a_n, and s = b + a_n.
  *
  *
  * where d = b - a_n, and s = b + a_n.
  *


@@ -669,7 +670,7 @@ _static_inline_ int64_t update_quadratic_deviation(int64_t n, int64_t old_qd,
 {
        int64_t delta = new_val - old_val;
        int64_t sigma = new_val + old_val;
 {
        int64_t delta = new_val - old_val;
        int64_t sigma = new_val + old_val;

-       return old_qd + delta * sigma - (2 * old_sum + delta) * delta / n;
+       return old_qd + delta * (sigma - 2 * old_sum / n - delta / n);

 }
 
 static int update_afs_statistics(struct afs_info *old_afsi, struct afs_info *new_afsi)
 }
 
 static int update_afs_statistics(struct afs_info *old_afsi, struct afs_info *new_afsi)