user_list.c: Fix a memory leak
authorAndre Noll <maan@systemlinux.org>
Sun, 11 Feb 2007 21:09:06 +0000 (22:09 +0100)
committerAndre Noll <maan@systemlinux.org>
Sun, 11 Feb 2007 21:09:06 +0000 (22:09 +0100)
get_rsa_key() already allocates space for the rsa key pointer. Moreover,
u->perms was set to zero twice. Kill one instance.

user_list.c

index c6d45ca..3d57a94 100644 (file)
@@ -58,11 +58,9 @@ static void populate_user_list(char *user_list_file)
                PARA_DEBUG_LOG("found entry for %s\n", n);
                u = para_malloc(sizeof(struct user));
                u->name = para_strdup(n);
                PARA_DEBUG_LOG("found entry for %s\n", n);
                u = para_malloc(sizeof(struct user));
                u->name = para_strdup(n);
-               u->rsa = para_malloc(sizeof(RSA));
                ret = get_rsa_key(k, &u->rsa, LOAD_PUBLIC_KEY);
                if (ret < 0)
                        break;
                ret = get_rsa_key(k, &u->rsa, LOAD_PUBLIC_KEY);
                if (ret < 0)
                        break;
-               u->perms = 0;
                char_ptr = p;
                num = sscanf(char_ptr, "%200[A-Z_],%200[A-Z_],%200[A-Z_],%200[A-Z_]",
                        tmp[0], tmp[1], tmp[2], tmp[3]);
                char_ptr = p;
                num = sscanf(char_ptr, "%200[A-Z_],%200[A-Z_],%200[A-Z_],%200[A-Z_]",
                        tmp[0], tmp[1], tmp[2], tmp[3]);