Don't set t->error in ->pre_select().
authorAndre Noll <maan@systemlinux.org>
Tue, 31 Dec 2013 17:20:24 +0000 (17:20 +0000)
committerAndre Noll <maan@systemlinux.org>
Sun, 25 May 2014 13:36:37 +0000 (15:36 +0200)
->pre_select() methods should never fail, and tasks should not
set this variable at all. It is ignored anyway when set there.

dccp_recv.c
filter_common.c
recv_common.c
wav_filter.c

index 796a7e6..3d6588a 100644 (file)
@@ -123,7 +123,6 @@ static void dccp_recv_pre_select(struct sched *s, struct task *t)
 {
        struct receiver_node *rn = container_of(t, struct receiver_node, task);
 
-       t->error = 0;
        if (generic_recv_pre_select(s, t) <= 0)
                return;
        para_fd_set(rn->fd, &s->rfds, &s->max_fileno);
index 8ce66ea..f2f5799 100644 (file)
@@ -143,7 +143,6 @@ void generic_filter_pre_select(struct sched *s, struct task *t)
 {
        struct filter_node *fn = container_of(t, struct filter_node, task);
 
-       t->error = 0;
        if (btr_node_status(fn->btrn, fn->min_iqs, BTR_NT_INTERNAL) != 0)
                sched_min_delay(s);
 }
index 2d6aa74..eb5fe57 100644 (file)
@@ -130,7 +130,6 @@ int generic_recv_pre_select(struct sched *s, struct task *t)
        struct receiver_node *rn = container_of(t, struct receiver_node, task);
        int ret = btr_node_status(rn->btrn, 0, BTR_NT_ROOT);
 
-       t->error = 0;
        if (ret < 0)
                sched_min_delay(s);
        return ret;
index ea3236c..bd67695 100644 (file)
@@ -68,7 +68,6 @@ static void wav_pre_select(struct sched *s, struct task *t)
        struct filter_node *fn = container_of(t, struct filter_node, task);
        size_t iqs = btr_get_input_queue_size(fn->btrn);
 
-       t->error = 0;
        if (iqs == 0)
                return;
        sched_min_delay(s);