Don't set t->error in ->pre_select().

->pre_select() methods should never fail, and tasks should not
set this variable at all. It is ignored anyway when set there.

diff --git a/dccp_recv.c b/dccp_recv.c
index 796a7e6baf76fe15041386041e21d403b4c58cf0..3d6588ac4b338ad26c99c76276d0dc05ede9d115 100644 (file)
--- a/dccp_recv.c
+++ b/dccp_recv.c
@@ -123,7 +123,6 @@ static void dccp_recv_pre_select(struct sched *s, struct task *t)
 {
        struct receiver_node *rn = container_of(t, struct receiver_node, task);
 
-       t->error = 0;
        if (generic_recv_pre_select(s, t) <= 0)
                return;
        para_fd_set(rn->fd, &s->rfds, &s->max_fileno);

diff --git a/filter_common.c b/filter_common.c
index 8ce66ea878c309d96e98e944f21af02670d9060c..f2f5799f8593240f6d74d262a8bd93e0becfd191 100644 (file)
--- a/filter_common.c
+++ b/filter_common.c
@@ -143,7 +143,6 @@ void generic_filter_pre_select(struct sched *s, struct task *t)
 {
        struct filter_node *fn = container_of(t, struct filter_node, task);
 
-       t->error = 0;
        if (btr_node_status(fn->btrn, fn->min_iqs, BTR_NT_INTERNAL) != 0)
                sched_min_delay(s);
 }

diff --git a/recv_common.c b/recv_common.c
index 2d6aa74a55063da799f35d1b9abbe07b33aa59b4..eb5fe57ee5da961c208c38a2933e9f09422320d2 100644 (file)
--- a/recv_common.c
+++ b/recv_common.c
@@ -130,7 +130,6 @@ int generic_recv_pre_select(struct sched *s, struct task *t)
        struct receiver_node *rn = container_of(t, struct receiver_node, task);
        int ret = btr_node_status(rn->btrn, 0, BTR_NT_ROOT);
 
-       t->error = 0;
        if (ret < 0)
                sched_min_delay(s);
        return ret;

diff --git a/wav_filter.c b/wav_filter.c
index ea3236c7f56a0ee1b2719b47a80dc4e4754154ad..bd676958e0a4be621ea29a42f51f81fd34c35d07 100644 (file)
--- a/wav_filter.c
+++ b/wav_filter.c
@@ -68,7 +68,6 @@ static void wav_pre_select(struct sched *s, struct task *t)
        struct filter_node *fn = container_of(t, struct filter_node, task);
        size_t iqs = btr_get_input_queue_size(fn->btrn);
 
-       t->error = 0;
        if (iqs == 0)
                return;
        sched_min_delay(s);