Add -Wmissing-noreturn to compiler flags.

And mark all exit functions of gui.c with __noreturn.

diff --git a/Makefile.in b/Makefile.in
index 3831e1c461ca38be977ce7128376e4f6872161cc..5dd08d6d069daea22e1f8deaf49958ed9ef38bcf 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -46,6 +46,7 @@ CPPFLAGS += -DCODENAME='"$(codename)"'
 CPPFLAGS += -DCC_VERSION='"$(cc_version)"'
 CPPFLAGS += -Werror-implicit-function-declaration
 CPPFLAGS += -Wmissing-format-attribute
+CPPFLAGS += -Wmissing-noreturn
 CPPFLAGS += -Wunused-macros
 CPPFLAGS += -Wbad-function-cast
 CPPFLAGS += -DMAIN_INPUT_FILE_IS_$(*F)

diff --git a/gui.c b/gui.c
index 9a02bdcabc3c252fb875b893cea5610f23243b2e..588507154bfb0e620b256c08c2ce6914b1b7c0e6 100644 (file)
--- a/gui.c
+++ b/gui.c
@@ -523,7 +523,7 @@ static void setup_signal_handling(void)
        signal(SIGHUP, SIG_IGN);
 }
 
-static void do_exit(int ret)
+__noreturn static void do_exit(int ret)
 {
        signal(SIGTERM, SIG_IGN);
        kill(0, SIGTERM);
@@ -539,7 +539,7 @@ static void shutdown_curses(void)
        endwin();
 }
 
-static void finish(int ret)
+__noreturn static void finish(int ret)
 {
        shutdown_curses();
        do_exit(ret);
@@ -548,7 +548,7 @@ static void finish(int ret)
 /*
  * exit curses and print given message to stdout/stderr
  */
-__printf_2_3 static void msg_n_exit(int ret, const char* fmt, ...)
+__noreturn __printf_2_3 static void msg_n_exit(int ret, const char* fmt, ...)
 {
        va_list argp;
        FILE *outfd = ret? stderr: stdout;
@@ -1280,7 +1280,7 @@ static void com_version(void)
                CODENAME "\"");
 }
 
-static void com_quit(void)
+__noreturn static void com_quit(void)
 {
        finish(0);
 }