From: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun, 19 Jul 2020 16:35:44 +0000 (+0200)
Subject: vss: Fix NULL pointer dereference in vss_del_fec_client().
X-Git-Tag: v0.6.3~2^2
X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=commitdiff_plain;h=35cab857b6b87782be4549c767cb9013128a74e5

vss: Fix NULL pointer dereference in vss_del_fec_client().

fc->src_data may well be NULL here, for example if para_server is
not currently playing.

This bug was introduced in the previous commit after the topic branch
had been promoted to next.
---

diff --git a/vss.c b/vss.c
index 737b77ac..9857d92d 100644
--- a/vss.c
+++ b/vss.c
@@ -689,9 +689,11 @@ void vss_del_fec_client(struct fec_client *fc)
 
 	list_del(&fc->node);
 	free(fc->enc_buf);
-	for (i = 0; i < fc_num_data_slices(fc); i++)
-		free(fc->src_data[i]);
-	free(fc->src_data);
+	if (fc->src_data) {
+		for (i = 0; i < fc_num_data_slices(fc); i++)
+			free(fc->src_data[i]);
+		free(fc->src_data);
+	}
 	fec_free(fc->parms);
 	free(fc);
 }