From: Andre Noll <maan@systemlinux.org>
Date: Tue, 19 Dec 2006 17:30:51 +0000 (+0100)
Subject: mysql.c: Fix boolean logig bug
X-Git-Tag: v0.2.15~123
X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=commitdiff_plain;h=4d72f19bdd24989dba1af207b29448330fc9aef2;ds=sidebyside

mysql.c: Fix boolean logig bug

Found by davej's findbugs.pl script.

Hard to spot for the human eye.
---

diff --git a/mysql_selector.c b/mysql_selector.c
index 9363dba4..7a3b0a7d 100644
--- a/mysql_selector.c
+++ b/mysql_selector.c
@@ -1502,7 +1502,7 @@ static int com_mv(__a_unused int fd, int argc, char *argv[])
 	ret = -E_ESCAPE;
 	ebn1 = escaped_basename(argv[1]);
 	ebn2 = escaped_basename(argv[2]);
-	if (!ebn1 || !ebn2 | !*ebn1 || !*ebn2)
+	if (!ebn1 || !ebn2 || !*ebn1 || !*ebn2)
 		goto out;
 	ret = -E_MYSQL_SYNTAX;
 	if (!strcmp(ebn1, ebn2))