From: Andre Noll <maan@tuebingen.mpg.de>
Date: Sun, 3 Jul 2016 10:40:47 +0000 (+0200)
Subject: client: No longer fail connection if sideband was not announced.
X-Git-Tag: v0.5.7~22^2~1
X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=commitdiff_plain;h=6ee9f6e477fd968491be395bedfbf660e0ebea5c;ds=inline

client: No longer fail connection if sideband was not announced.

Sideband has become mandatory in paraslash-0.5.0, and the current
para_client does not work with older server versions anyway. Hence
this change has no impact on compatibility.

The E_INCOMPAT_FEAT error code is now unused and can be removed.
---

diff --git a/client_common.c b/client_common.c
index cd1ccc61..eea7510f 100644
--- a/client_common.c
+++ b/client_common.c
@@ -292,11 +292,6 @@ static int client_post_select(struct sched *s, void *context)
 		if (ret < 0 || n == 0)
 			goto out;
 		ct->features = parse_features(buf);
-		if (!has_feature("sideband", ct)) {
-			PARA_ERROR_LOG("server has no sideband support\n");
-			ret = -E_INCOMPAT_FEAT;
-			goto out;
-		}
 		ct->status = CL_RECEIVED_WELCOME;
 		return 0;
 	case CL_RECEIVED_WELCOME: /* send auth command */
diff --git a/error.h b/error.h
index 3d58e630..3bfd8a96 100644
--- a/error.h
+++ b/error.h
@@ -306,7 +306,6 @@ extern const char **para_errlist[];
 	PARA_ERROR(SERVER_EOF, "connection closed by para_server"), \
 	PARA_ERROR(SERVER_CMD_SUCCESS, "command terminated successfully"), \
 	PARA_ERROR(SERVER_CMD_FAILURE, "command failed"), \
-	PARA_ERROR(INCOMPAT_FEAT, "client/server incompatibility"), \
 
 
 #define NET_ERRORS \