From: Andre Noll <maan@tuebingen.mpg.de>
Date: Sat, 2 Nov 2019 13:47:15 +0000 (+0100)
Subject: vss: Improve error diagnostics.
X-Git-Tag: v0.6.3~29
X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=commitdiff_plain;h=9d15fd7e3a77282cec660eed54f46c3282bf8f29;hp=4fb6bf35f5dd6bfcafc0b90e83d4d9084da38365

vss: Improve error diagnostics.

Unless in debug loglevel, para_server prints

	Nov 01 17:06:03 (4) (18596) open_next_audio_file: key not found in rbtree
	Nov 01 17:06:03 (4) (18595) recv_afs_result: did not receive open fd from afs

which does not include information about what was actually received.
---

diff --git a/vss.c b/vss.c
index 73c72311..023b2c1d 100644
--- a/vss.c
+++ b/vss.c
@@ -959,11 +959,12 @@ static void recv_afs_result(struct vss_task *vsst, fd_set *rfds)
 	if (ret < 0)
 		goto err;
 	vsst->afsss = AFS_SOCKET_READY;
-	PARA_DEBUG_LOG("fd: %d, code: %u, shmid: %u\n", passed_fd, afs_code,
-		afs_data);
 	ret = -E_NOFD;
-	if (afs_code != NEXT_AUDIO_FILE)
+	if (afs_code != NEXT_AUDIO_FILE) {
+		PARA_ERROR_LOG("afs code: %u, expected: %d\n", afs_code,
+			NEXT_AUDIO_FILE);
 		goto err;
+	}
 	if (passed_fd < 0)
 		goto err;
 	shmid = afs_data;