From: Andre Noll <maan@systemlinux.org>
Date: Thu, 13 Jun 2013 08:54:24 +0000 (+0200)
Subject: alsa: Don't set t->error in ->pre_select().
X-Git-Tag: v0.5.3~22^2~8
X-Git-Url: http://git.tuebingen.mpg.de/?p=paraslash.git;a=commitdiff_plain;h=aa4a8d9c0f08687618dfcf96bc0c553ef17fbc1d

alsa: Don't set t->error in ->pre_select().

->pre_select() methods should never fail, and tasks should not
set this variable at all. It is ignored anyway when set there.
---

diff --git a/alsa_write.c b/alsa_write.c
index a3912c11..0824640b 100644
--- a/alsa_write.c
+++ b/alsa_write.c
@@ -211,7 +211,6 @@ static void alsa_write_pre_select(struct sched *s, struct task *t)
 	if (ret < 0) {
 		PARA_ERROR_LOG("could not get alsa poll fd: %s\n",
 			snd_strerror(-ret));
-		t->error = -E_ALSA;
 		return;
 	}
 	pad->poll_fd = pfd.fd;