9 years agostring: Add discard feature for for_each_line().
Andre Noll [Mon, 25 Mar 2013 18:02:54 +0000 (18:02 +0000)]
string: Add discard feature for for_each_line().

This adds the new FELF_DISCARD_FIRST flag which instructs
for_each_line() to discard everything up to the next newline.

The new feature is only used by para_gui. When para_gui detects
a partial overlong input line, it ignores this data and passes the
FELF_DISCARD_FIRST flag in subsequent calls to for_each_line(). Hence
output continues at the next line.

9 years agostring: Simplify return value of for_each_line().
Andre Noll [Mon, 25 Mar 2013 17:30:56 +0000 (17:30 +0000)]
string: Simplify return value of for_each_line().

No caller used this function for counting lines, so simplify it by always
returning the number of bytes not processed.

9 years agostring: Simplify for_each_line().
Andre Noll [Mon, 25 Mar 2013 17:16:14 +0000 (17:16 +0000)]
string: Simplify for_each_line().

No user calls this with line_hander == NULL, so remove the special treatment
of this case.

9 years agostring: Clean up for_each_line() and related functions.
Andre Noll [Mon, 25 Mar 2013 16:10:28 +0000 (16:10 +0000)]
string: Clean up for_each_line() and related functions.

While for_each_complete_line() is a static function, there are two
public functions, for_each_line() and for_each_line_ro(), which are
implemented as simple wrappers for the static one. The only difference
between the two is that for_each_line_ro() sets the FELF_READ_ONLY
bit while for_each_line() does not.

Since we are about to add another bit of information soon, let's make
the bitmap and the static function public, and remove the two wrappers.
All callers are changed to pass an additional "unsigned flags" to
indicate whether they want the read-only behavior.

Documentation is updated accordingly.

9 years agostring: Replace the for_each_line_modes enum by a bitmap.
Andre Noll [Mon, 25 Mar 2013 15:36:10 +0000 (15:36 +0000)]
string: Replace the for_each_line_modes enum by a bitmap.

Currently we pass an "enum for_each_line_modes" as the first argument
to for_each_complete_line(). The parameter is effectively a boolean
since the enumeration defines only two possible values.

For the upcoming discard feature of for_each_line_modes() we'll need
to pass another bit of information, so this patch changes the type of
the first argument to for_each_complete_line() to unsigned and treats
it as a bit array. The only bit defined so far is LINE_MODE_RO, with
unchanged semantics.

The two callers are updated to reflect this change.

9 years agogui: Don't sleep before executing the status command.
Andre Noll [Wed, 27 Mar 2013 20:49:40 +0000 (20:49 +0000)]
gui: Don't sleep before executing the status command.

This results in uncacceptable delays when the status command fails
for any reason, for example because the server is down.

Replace this code by introducing a struct timeval variable "next_exec",
which stores the earliest possible time to restart the status command.

Move all status fetching code before the select() call in do_select()
to open_stat_pipe() and rename the function to status_pre_select(),
which is more appropriate.

9 years agogui: Speed up add_spaces().
Andre Noll [Mon, 25 Mar 2013 19:08:12 +0000 (19:08 +0000)]
gui: Speed up add_spaces().

The calls to waddstr() in this function showed up in profiles. So
print the full string at once instead of calling waddstr() for each

9 years agogui: Rename do_exit().
Andre Noll [Mon, 25 Mar 2013 03:08:12 +0000 (03:08 +0000)]
gui: Rename do_exit().

This function sends SIGTERM to every process in the process group of
para_gui and dies thereafter. So kill_pg_and_die() is more descriptive
than the old name.

9 years agogui: Remove superfluous cmd_died.
Andre Noll [Mon, 25 Mar 2013 02:22:24 +0000 (02:22 +0000)]
gui: Remove superfluous cmd_died.

We might as well directly refer to cmd_pid which is set to zero in the
signal handling code after the process exits.

9 years agogui: Check stdin for readability.
Andre Noll [Mon, 25 Mar 2013 02:14:06 +0000 (02:14 +0000)]
gui: Check stdin for readability.

If the select_loop of para_gui runs in getch or command mode we
currently wait a full timeout period before checking for pending

This patch adds stdin to the set of file descriptors monitored by
select so that a key press causes select() to return immediately.

9 years agogui: Discard overlong input lines.
Andre Noll [Mon, 18 Mar 2013 19:13:35 +0000 (20:13 +0100)]
gui: Discard overlong input lines.

If an external command produces output without newlines, the current
code ends up calling read_nonblock() with a buffer size of zero which
triggers the assertion in readv_nonblock().

Increase the output buffer to 32K and fix the problem by simply
discarding all input if the input buffer is full and contains no
newline character.

A better fix would be to discard everything until the next newline
character is read, but this requires more work, so let's go with this
simple fix for now.

9 years agoMerge branch 't/allow_zero_btr_add'
Andre Noll [Thu, 2 May 2013 17:55:18 +0000 (19:55 +0200)]
Merge branch 't/allow_zero_btr_add'

Was cooking for over a month.

9 years agosched: Rename new_post_select back to post_select.
Andre Noll [Sun, 31 Mar 2013 19:47:35 +0000 (19:47 +0000)]
sched: Rename new_post_select back to post_select.

9 years agosched: Kill old ->post_select variant.
Andre Noll [Sun, 31 Mar 2013 19:23:18 +0000 (19:23 +0000)]
sched: Kill old ->post_select variant.

It has no more users.

9 years agograb client: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 19:11:04 +0000 (19:11 +0000)]
grab client: Switch to the alternative post select method.

9 years agoclient supervisor: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:54:10 +0000 (18:54 +0000)]
client supervisor: Switch to the alternative post select method.

9 years agoclient exec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:47:50 +0000 (18:47 +0000)]
client exec: Switch to the alternative post select method.

9 years agoi9e: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:38:39 +0000 (18:38 +0000)]
i9e: Switch to the alternative post select method.

9 years agovss: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:30:03 +0000 (18:30 +0000)]
vss: Switch to the alternative post select method.

9 years agostdout: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:24:32 +0000 (18:24 +0000)]
stdout: Switch to the alternative post select method.

9 years agostdin: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:22:08 +0000 (18:22 +0000)]
stdin: Switch to the alternative post select method.

9 years agoaudioc: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:17:41 +0000 (18:17 +0000)]
audioc: Switch to the alternative post select method.

9 years agoafs command task: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 18:11:48 +0000 (18:11 +0000)]
afs command task: Switch to the alternative post select method.

9 years agoafs signal task: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:58:26 +0000 (17:58 +0000)]
afs signal task: Switch to the alternative post select method.

9 years agoserver signal task: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:47:26 +0000 (17:47 +0000)]
server signal task: Switch to the alternative post select method.

9 years agoserver command task: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:42:17 +0000 (17:42 +0000)]
server command task: Switch to the alternative post select method.

9 years agowrite: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:34:52 +0000 (17:34 +0000)]
write: Switch to the alternative post select method.

9 years agoplay: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:27:28 +0000 (17:27 +0000)]
play: Switch to the alternative post select method.

9 years agoafh_recv: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 17:03:15 +0000 (17:03 +0000)]
afh_recv:  Switch to the alternative post select method.

9 years agoclient: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 16:46:08 +0000 (16:46 +0000)]
client: Switch to the alternative post select method.

9 years agoaudiod: Switch command_task to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 16:44:57 +0000 (16:44 +0000)]
audiod: Switch command_task to the alternative post select method.

9 years agoaudiod: Switch the status task to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 15:52:57 +0000 (15:52 +0000)]
audiod: Switch the status task to the alternative post select method.

9 years agoaudiod: Switch signal task to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 14:11:59 +0000 (14:11 +0000)]
audiod: Switch signal task to the alternative post select method.

9 years agoosx writer: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 14:03:19 +0000 (14:03 +0000)]
osx writer: Switch to the alternative post select method.

9 years agooss writer: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 14:01:35 +0000 (14:01 +0000)]
oss writer: Switch to the alternative post select method.

9 years agofile writer: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:59:41 +0000 (13:59 +0000)]
file writer: Switch to the alternative post select method.

9 years agoao: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:56:49 +0000 (13:56 +0000)]
ao: Switch to the alternative post select method.

9 years agoalsa: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 22:40:48 +0000 (22:40 +0000)]
alsa: Switch to the alternative post select method.

9 years agowmadec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:43:34 +0000 (13:43 +0000)]
wmadec: Switch to the alternative post select method.

9 years agowav filter: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 22:44:38 +0000 (22:44 +0000)]
wav filter: Switch to the alternative post select method.

9 years agospxdec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:37:13 +0000 (13:37 +0000)]
spxdec: Switch to the alternative post select method.

9 years agoresample: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:34:37 +0000 (13:34 +0000)]
resample: Switch to the alternative post select method.

9 years agoprebuffer: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:30:57 +0000 (13:30 +0000)]
prebuffer: Switch to the alternative post select method.

9 years agooggdec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:28:48 +0000 (13:28 +0000)]
oggdec: Switch to the alternative post select method.

9 years agomp3dec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:25:02 +0000 (13:25 +0000)]
mp3dec: Switch to the alternative post select method.

9 years agoflacdec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:20:13 +0000 (13:20 +0000)]
flacdec: Switch to the alternative post select method.

9 years agofecdec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:15:41 +0000 (13:15 +0000)]
fecdec: Switch to the alternative post select method.

9 years agocompress: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:14:08 +0000 (13:14 +0000)]
compress: Switch to the alternative post select method.

9 years agoamp: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:11:46 +0000 (13:11 +0000)]
amp: Switch to the alternative post select method.

9 years agoaacdec: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 13:08:46 +0000 (13:08 +0000)]
aacdec: Switch to the alternative post select method.

9 years agodccp_recv: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 22:45:58 +0000 (22:45 +0000)]
dccp_recv: Switch to the alternative post select method.

9 years agoudp_recv: Switch to the alternative post select method.
Andre Noll [Sun, 31 Mar 2013 12:49:42 +0000 (12:49 +0000)]
udp_recv: Switch to the alternative post select method.

9 years agosched: Provide alternative post_select variant.
Andre Noll [Sun, 31 Mar 2013 12:32:07 +0000 (12:32 +0000)]
sched: Provide alternative post_select variant.

Code which accesses the ->error field of another task has been
a source of bugs in the past. This patch is a first step to make
->error private to sched.c.

Currently the ->post_select() methods of all tasks are supposed
to set ->error to a negative value to indicate that the task
should be terminated, i.e. t->error being negative instructs the
scheduler to not call t->pre_select() or t->post_select() any more
in subsequent iterations.  An equivalent way to achieve the same
is to let ->post_select() return an error code instead. Benefits

* It reduces the use of ->error outside of sched.c
* It's impossible to miss setting the error code
* It simplifies code slightly

Therefore we'd like to change the prototype of the ->post_select()
methods from

void (*post_select)(struct sched *s, struct task *t);
int (*post_select)(struct sched *s, struct task *t);

Changes to struct sched affects many parts of the code base,
hence converting all users at once would result in a very
large patch. Therefore we temporarily introduce an additional
->new_post_select() method according to the second declaration
above. The scheduler calls the new method if it is defined and falls
back to the old variant otherwise. This approach allows to switch
over one task after another without breaking things.

This patch introduces the infrastructure just described and switches
over the http receiver. Subsequent commits will change all other tasks
in the same way. After all tasks have been switched over we can get
rid of the old ->post_select variant and rename ->new_post_select()
back to ->post_select().

9 years agoReplace gettimeofday() by clock_gettime().
Andre Noll [Sun, 31 Mar 2013 02:03:04 +0000 (02:03 +0000)]
Replace gettimeofday() by clock_gettime().

POSIX.1-2008 marks gettimeofday() as obsolete, so let's switch to

clock_gettime() operates on timespecs rather than on timevals like
gettimeofday() does. Since timevals are extensively used in all
parts of paraslash, and select() takes a timeval pointer as the
timeout parameter, it seems to be easiest to add a new wrapper,
clock_get_realtime(). It calls clock_gettime(), performs error
checking (all errors are treated fatal and abort the program), and
converts the result to a timeval.

Another difference between gettimeofday() and clock_gettime()
is that sys/time.h needs to be included for gettimeofday(), while
clock_gettime() is declared in time.h which gets included from para.h.
Hence we can remove the include statement for sys/time.h everywhere.

Programs which call clock_gettime need to be linked against librt on
glibc versions before 2.17 while BSD and newer glibc-based systems
have no such requirement. To make matters more interesting,
MacOS lacks clock_gettime() completely although this function conforms
to SUSv2 and POSIX.1-2001.

We'd like to avoid the unnecessary dependence on librt on systems that
have clock_gettime() in -lc, and we must fall back to gettimeofday()
on MacOS. Hence this commit also introduces a check in
which determines whether clock_gettime() is available and, if it is,
whether -lrt is needed. Executables are only linked with -lrt if
configure found that this is necessary.

9 years agocheck_wav.c: Fix documentation of check_wav_post_select().
Andre Noll [Sun, 14 Apr 2013 09:57:12 +0000 (11:57 +0200)]
check_wav.c: Fix documentation of check_wav_post_select().

This function does not take a pointer to a buffer tree node, yet the
comment referred to "btrn". Simply drop this part of the sentence.

9 years agocompress: Further optimize inner loop.
Andre Noll [Tue, 2 Apr 2013 17:10:08 +0000 (17:10 +0000)]
compress: Further optimize inner loop.

This kills the local adjusted_sample variable of the inner loop of
compress_post_select().  Surprisingly enough, this saves another 5%
of execution time.

9 years agocompress: Remove log statement in inner loop.
Andre Noll [Tue, 2 Apr 2013 16:34:58 +0000 (16:34 +0000)]
compress: Remove log statement in inner loop.

We don't want to spam the log, and killing the statement seems to
make it a bit faster as well.

9 years agocompress: Avoid PARA_ABS and PARA_MAX in inner loop.
Andre Noll [Tue, 2 Apr 2013 15:02:09 +0000 (15:02 +0000)]
compress: Avoid PARA_ABS and PARA_MAX in inner loop.

These macros are type-safe and evaluate their arguments only once.
However, they are also slow. For the compress filter we are dealing
with ints and unsigned ints only, so the additional checks performed
by the macros only slow things down. Getting rid of the macros reduces
the running time of

para_filter -f compress < foo.wav > /dev/null

by approximately 8%.

9 years agocompress: Compile with -O3.
Andre Noll [Tue, 2 Apr 2013 14:46:35 +0000 (14:46 +0000)]
compress: Compile with -O3.

By default all objects are compiled with -Os. For the compress filter,
which has to deal with large amounts of uncompressed audio data,
gcc emits rather inefficient code. Switching to -O3 resulted in a 10%
performance improvement on my Lenovo laptop.

9 years agosched: Get rid of (pre)select shortcuts.
Andre Noll [Sat, 30 Mar 2013 22:43:38 +0000 (22:43 +0000)]
sched: Get rid of (pre)select shortcuts.

These shortcuts let the scheduler skip any subsequent ->pre_select()
calls as well as the actual call to select(2) if the current task's
->pre_select() requested a zero timeout.

This idea turned out to be dubios at best. The main problem is that
->post_select no longer knows whether ->pre_select() and select()
have been called. For example, if ->pre_select() monitors some file
descriptor, ->post_select() might find it not ready for I/O even when
it actually is because ->pre_select() or select() was optimized away.

Another problem are tasks whose ->post_select() method expects that
->pre_select() sets some variable in a shared data structure.

This patch removes the scheduler optimizations so that all
->pre_select() methods of all tasks are called once per scheduler

9 years agoaudiod: Avoid delay when closing slot.
Andre Noll [Sun, 31 Mar 2013 14:58:18 +0000 (14:58 +0000)]
audiod: Avoid delay when closing slot.

Currently we might wait up to a full scheduler interval until a slot
is closed.

This commit changes the pre_select method of the status task to check
whether some slot can be closed. In this case it requests a minimal
delay from the scheduler.

The current try_to_close_slot() is split into two functions,
must_close_slot() and close_unused_slots(). The former function is
called from ->pre_select(). It only checks whether a slot must be
closed but performs no action.

The latter function, close_unused_slots() probes all slots and closes
those for which must_close_slot() returns true.

9 years agoAdd two missing Copyright headers and file annotations.
Andre Noll [Thu, 4 Apr 2013 20:58:48 +0000 (20:58 +0000)]
Add two missing Copyright headers and file annotations.

Andre Noll [Sat, 6 Apr 2013 15:42:54 +0000 (15:42 +0000)]

The audio format handlers are used by para_server, para_afh and
para_play, so the old name was misleading.

9 years Shorten config summary.
Andre Noll [Wed, 27 Mar 2013 02:51:38 +0000 (02:51 +0000)] Shorten config summary.

With many filters/writers the output line becomes rather long.
Moreover, filters and writers are also used by para_play but para_play
is not mentionend in the prefix. Just skip the prefix.

9 years agomanual: Don't try to enumerate audio formats.
Andre Noll [Mon, 25 Mar 2013 23:08:59 +0000 (23:08 +0000)]
manual: Don't try to enumerate audio formats.

This is a high-level description where no details
are needed. Flac was missing anyway.

9 years agoamp: Remove stray comment.
Andre Noll [Fri, 5 Apr 2013 20:10:56 +0000 (20:10 +0000)]
amp: Remove stray comment.

9 years agoAdd documentation of public functions in check_wav.c.
Andre Noll [Thu, 4 Apr 2013 17:00:01 +0000 (17:00 +0000)]
Add documentation of public functions in check_wav.c.

The init, shutdown, pre_select and post_select functions of this
file are exported via check_wav.h, so they should be documented. This
commit adds doxygen comments for all of them.

9 years agoRemove old stream cipher API.
Andre Noll [Tue, 24 Jul 2012 06:38:53 +0000 (08:38 +0200)]
Remove old stream cipher API.

No users remained after the sideband compatibility code has been

9 years agoAllow addblob commands to create output.
Andre Noll [Tue, 24 Jul 2012 06:14:12 +0000 (08:14 +0200)]
Allow addblob commands to create output.

Currently all addblob commands remain silent even on fatal errors
because para_client either reads the command output, or sends its
stdin, but never both.

This patch overcomes this shortcoming. It makes para_client create
two buffer trees instead of one. The client states CL_SENT_COMMAND
and CL_RECEIVING are replaced by a single CL_EXECUTING state.

Blob data is now sent as a sideband packet.  The change breaks
compatibility with earlier 0.4.x versions again, but that's OK as
this is 0.5.0 material anyway.

9 years agoclient: Remove client_recv_buffer().
Andre Noll [Tue, 24 Jul 2012 06:11:24 +0000 (08:11 +0200)]
client: Remove client_recv_buffer().

After the cleanup of the previous patch, only a single caller of
this function remains. It calls client_recv_buffer() when the client
state is CL_CONNECTED, in which case the function is just a wrapper
for read_nonblock(). So we may as well call read_nonblock() directly
and get rid of client_recv_buffer().

9 years agoclient: Remove sb-compatibility code.
Andre Noll [Tue, 24 Jul 2012 04:20:05 +0000 (06:20 +0200)]
client: Remove sb-compatibility code.

Now that non-client sideband connection attempts are rejected up-front,
we may get rid of all the non-sideband code.

9 years agoReject non-sideband connections.
Andre Noll [Mon, 23 Jul 2012 17:07:07 +0000 (19:07 +0200)]
Reject non-sideband connections.

This makes the client abort the connection if the server does not
support sideband. Conversely, the server closes the socket if the
client did not request a sideband connection.

This breaks compatibility with earlier versions of para_server and
para_client but allows to clean up the code considerably.

9 years agoblob: Avoid zero sized memcpy().
Andre Noll [Sun, 10 Mar 2013 14:53:05 +0000 (15:53 +0100)]
blob: Avoid zero sized memcpy().

Calling memcpy() with a size argument of zero is a noop on Linux,
so this should be OK. However, memcpy(3) does not say anything about
this case, so let's be conservative here and call it only if there is
anything to copy.

9 years agoFix typo in documentation of stdin_command().
Andre Noll [Sun, 10 Mar 2013 14:47:31 +0000 (15:47 +0100)]
Fix typo in documentation of stdin_command().

The argument is called cc rather than scc.

9 years agoblob: Simplify fd2buf().
Andre Noll [Tue, 24 Jul 2012 06:26:19 +0000 (08:26 +0200)]
blob: Simplify fd2buf().

The max size of a blob for a stdin command has always been
fixed. No need to pass this value around.

9 years agostring.c: Fix typo in documentation of skip_cells().
Andre Noll [Wed, 27 Mar 2013 14:47:39 +0000 (14:47 +0000)]
string.c: Fix typo in documentation of skip_cells().

9 years agoMerge branch 't/mood_fix'
Andre Noll [Tue, 26 Mar 2013 00:07:08 +0000 (00:07 +0000)]
Merge branch 't/mood_fix'

9 years agoChange copyright year to 2013.
Andre Noll [Sun, 24 Mar 2013 18:00:05 +0000 (18:00 +0000)]
Change copyright year to 2013.

Better late than never.

9 years agoafs.c: Fix some spelling mistakes in comments.
Andre Noll [Tue, 1 Jan 2013 16:30:58 +0000 (16:30 +0000)]
afs.c: Fix some spelling mistakes in comments.

9 years agoImprove documentation of readv_nonblock().
Andre Noll [Mon, 18 Mar 2013 19:22:31 +0000 (20:22 +0100)]
Improve documentation of readv_nonblock().

Define the meaning of "sz".

9 years agobtr: Handle zero-sized buffers gracefully.
Andre Noll [Sun, 23 Dec 2012 22:58:17 +0000 (23:58 +0100)]
btr: Handle zero-sized buffers gracefully.

There is no need to abort on the attempt to add a zero sized buffer.
Let's be gentle and make this condition a noop rather than a fatal

9 years agoFix mood reload.
Andre Noll [Sun, 27 Jan 2013 18:12:57 +0000 (19:12 +0100)]
Fix mood reload.

There was some confusion about how to determine whether the dummy mode
is currently active. At some places we tested if current_mood is NULL,
at others if current_mood->name is NULL. In fact neither check works:

* if a playlist is open, current_mood is NULL (but the dummy
mood is not loaded),

* loading the dummy mood currently sets current_mood->name to

This patch makes the latter variant the official one and fixes up
the code accordingly.

This also fixes the critical log message

Jan 27 18:57:29 (5) (13487) afs_event: table moods, event 9: key not found in rbtree

which occured if the dummy mood was active while an event caused the
mood to be reloaded.

9 years agoafs: Add assertion to afs_cb_result_handler().
Andre Noll [Tue, 1 Jan 2013 23:20:04 +0000 (23:20 +0000)]
afs: Add assertion to afs_cb_result_handler().

If cc is NULL we always have a bug, so it's OK to dereference this
pointer unconditionally. However, if the command handler crashes
due to cc being NULL, it is not obvious what has happened, so make
this explicit.

9 years agoclient: Don't print the same error message twice.
Andre Noll [Mon, 23 Jul 2012 17:03:48 +0000 (19:03 +0200)]
client: Don't print the same error message twice.

Currently, if the client task exits, the corresponding error
message is printed both by client_post_select() and by main()
of client.c.

This patch makes main() print a generic "command failed" error
message instead.

9 years agotrivial: Fix typo in client.h.
Andre Noll [Mon, 23 Jul 2012 19:51:03 +0000 (21:51 +0200)]
trivial: Fix typo in client.h.

9 years agoSwitch to HTF-8 for web pages.
Andre Noll [Sun, 10 Feb 2013 10:22:04 +0000 (11:22 +0100)]
Switch to HTF-8 for web pages.

This sets the charset in the html header section to UTF-8 and
converts the CREDITS file from ISO-8859-1 to UTF-8.

9 years agosignal: Restore errno on exit from signal handler.
Andre Noll [Sat, 9 Feb 2013 18:29:14 +0000 (19:29 +0100)]
signal: Restore errno on exit from signal handler.

This probably is not necessary since generic_signal_handler() calls
exit(3) if the write to the signal pipe fails. However, nobody is
going to stop write(2) from setting errno also on success, so let's
play safe and always restore its value on exit.

9 years agoSpeed up dep target.
Andre Noll [Mon, 31 Dec 2012 00:10:50 +0000 (00:10 +0000)]
Speed up dep target.

By default "make" removes intermediate files during the build. However,
some of the files generated by gengetopt are needed again later for
a different target.

This patch declares these generated files as "precious", so they
will no longer be removed. On one system the build time went down
from 30s to 25s due to this one-liner.

9 years Fix two typos in comment.
Andre Noll [Sun, 30 Dec 2012 14:08:37 +0000 (14:08 +0000)] Fix two typos in comment.

9 years agogui: Try to link against libncursesw.
Andre Noll [Sun, 3 Jun 2012 21:22:13 +0000 (23:22 +0200)]
gui: Try to link against libncursesw.

This variant of the curses library supports wide characters so we
should link against it if it is available. If it is not, we may still
fall back to libcurses instead.

9 years agoUTF-8 support for para_gui.
Andre Noll [Sun, 3 Jun 2012 12:08:55 +0000 (14:08 +0200)]
UTF-8 support for para_gui.

This adds two public helper functions to string.c which operate on
multibyte strings if the character encoding used in the selected
locale is UTF-8.

The first new helper, strwidth(), computes the width of the UTF-8
string while skip_cells() determines the number of bytes the given
multibyte string must be advanced in order to skip the given number
of cells.

para_gui is changed to use the new functions to properly display
UTF-8 encoded data in its top and bottom windows.

9 years agomp3_afh: Switch to UTF-8 encoding.
Andre Noll [Sun, 3 Jun 2012 20:00:31 +0000 (22:00 +0200)]
mp3_afh: Switch to UTF-8 encoding.

The interface of libid3tag allows to get the tag contents in various
formats. Currently, we always call the latin1 variants of these
library functions.

However, as UTF-8 encoding is more widespread these days and almost
all distributions, including the two year old Ubuntu lucid, have
switched to UTF-8, UTF-8 is probably a better choice today.

This patch changes mp3_afh.c to use the UTF-8 variants instead.

9 years agogui: Don't compute string length unnecessarily.
Andre Noll [Sun, 3 Jun 2012 17:25:06 +0000 (19:25 +0200)]
gui: Don't compute string length unnecessarily.

We already know the length because it was computed earlier and stored
in the ring buffer structure, so use this "cached" value instead where

9 years agoGet rid of unused HAVE_NCURSES define.
Andre Noll [Sun, 3 Jun 2012 20:58:13 +0000 (22:58 +0200)]
Get rid of unused HAVE_NCURSES define.

If no suitable curses library was found, para_gui will not be built. So
we don't need this define in config.h.

9 years agoFix --with-curses configure option.
Andre Noll [Sun, 3 Jun 2012 20:42:42 +0000 (22:42 +0200)]
Fix --with-curses configure option.

We only honored the provided -L<dir> for the tests in configure but
not when linking para_gui. This patch creates an output variable,
gui_ldflags, which is used in the Makefile for linking para_gui.

9 years agonew codename, reset version to git
Andre Noll [Thu, 20 Dec 2012 12:42:19 +0000 (13:42 +0100)]
new codename, reset version to git

9 years agoparaslash 0.4.12 v0.4.12
Andre Noll [Thu, 20 Dec 2012 12:27:14 +0000 (13:27 +0100)]
paraslash 0.4.12

9 years agoFix 'install' target.
Andre Noll [Thu, 20 Dec 2012 12:16:17 +0000 (13:16 +0100)]
Fix 'install' target.

This broke in commit 7024574d, where the AC_SUBST() was moved above
the AC_PROG_INSTALL on which it depends.  This resulted in an empty
$install_sh variable, breaking 'make install'.

Fix this bug by moving the AC_SUBST() below AC_PROG_INSTALL.

9 years agoNEWS update.
Andre Noll [Wed, 19 Dec 2012 19:56:45 +0000 (20:56 +0100)]
NEWS update.

9 years agoFix compilation MacOS.
Andre Noll [Mon, 17 Dec 2012 15:49:48 +0000 (16:49 +0100)]
Fix compilation MacOS.

The resolution of the conflict in commit 83ab4b5d introduced the
following error:

osx_write.c:329:9: error: use of undeclared label 'remove_btrn'
                        goto remove_btrn;
Fix is trivial.