paraslash.git
12 years agofd.c: Introduce para_chdir().
Andre Noll [Mon, 1 Oct 2007 21:30:33 +0000 (23:30 +0200)]
fd.c: Introduce para_chdir().

Also, fix a bug in para_open() which would return -1 instead of
a proper error code.

12 years agoImplement add -a (add all audio files).
Andre Noll [Mon, 1 Oct 2007 20:23:39 +0000 (22:23 +0200)]
Implement add -a (add all audio files).

12 years agoImplement mailbox output format for ls.
Andre Noll [Sun, 30 Sep 2007 23:24:54 +0000 (01:24 +0200)]
Implement mailbox output format for ls.

Alos, fix a bug in com_lsblob_callback() which caused incorrect
detection of the given options.

12 years agomood.c: Introduce DEFINE_MOOD_METHOD and DEFINE_MOOD_METHOD_WITH_CLEANUP.
Andre Noll [Sat, 29 Sep 2007 13:32:12 +0000 (15:32 +0200)]
mood.c: Introduce DEFINE_MOOD_METHOD and DEFINE_MOOD_METHOD_WITH_CLEANUP.

This simplifies the definition of the mood_methods array.

12 years agoattribute.c: Fix com_rmatt().
Andre Noll [Sat, 29 Sep 2007 13:31:35 +0000 (15:31 +0200)]
attribute.c: Fix com_rmatt().

We have to get the bit number _before_ we remove the row.

12 years agocom_ls: Don't use FNM_PATHNAME.
Andre Noll [Sat, 29 Sep 2007 13:30:06 +0000 (15:30 +0200)]
com_ls: Don't use FNM_PATHNAME.

It's just annoying.

12 years agoafs.cmd: Fix typo in setatt help.
Andre Noll [Sat, 29 Sep 2007 13:29:26 +0000 (15:29 +0200)]
afs.cmd: Fix typo in setatt help.

12 years agoattribute.c: Clear attribute bits already at remove time.
Andre Noll [Sat, 29 Sep 2007 12:00:14 +0000 (14:00 +0200)]
attribute.c: Clear attribute bits already at remove time.

If an attribute gets removed, the old code deferred clearing the
corresponding attribute bit in the afsi of all audio files until
that bit got reclaimed by add_att.  This is problematic because of
the new no_attribute_set mood method.

So clear the bit already in the rmatt callback.

12 years agomood.c: Add no_attributes_set mood method.
Andre Noll [Sat, 29 Sep 2007 11:39:34 +0000 (13:39 +0200)]
mood.c: Add no_attributes_set mood method.

Also fix a bug in mm_played_rarely_parser(): If no arg was
specified in the mood definition, a NULL pointer is passed to that
function, so it must not blindly dereference that pointer.

12 years agoSpeed up mood loading.
Andre Noll [Sat, 29 Sep 2007 11:13:50 +0000 (13:13 +0200)]
Speed up mood loading.

The old code passed a pointer to the row of the audio file table to the
mood scoring functions. The scoring functions had to obtain the afsi,
afhi, path from that row pointer. Thus, at mood load time, the afsi,
afhi, path was extracted N times for each audio file if there are N
mood lines that used this info.

This patch changes the mood scoring functions so that they take
three pointers to afsi, afhi, path instead of the row pointer.
add_item_score(), the single caller of the mood scoring functions,
provides these pointers, i.e. they get extracted from the row pointer
only once per audio file.

This is still not optimal as most scoring functions use only one of
the three pointers. But let's not over-engineer the thing.

12 years agomood.c: Switch to fnmatch() in mood method name_like.
Andre Noll [Sat, 29 Sep 2007 10:22:52 +0000 (12:22 +0200)]
mood.c: Switch to fnmatch() in mood method name_like.

Also, change doxygen documentation to the new style.

12 years agograb_client.c: Change doxygen comments to the new style.
Andre Noll [Fri, 28 Sep 2007 22:07:29 +0000 (00:07 +0200)]
grab_client.c: Change doxygen comments to the new style.

12 years agoEven more typo fixes.
Andre Noll [Fri, 28 Sep 2007 21:54:59 +0000 (23:54 +0200)]
Even more typo fixes.

12 years agoStill more typo fixes.
Andre Noll [Fri, 28 Sep 2007 21:46:36 +0000 (23:46 +0200)]
Still more typo fixes.

12 years agoFEATURES, INSTALL: Fix some more typos.
Andre Noll [Fri, 28 Sep 2007 21:46:24 +0000 (23:46 +0200)]
FEATURES, INSTALL: Fix some more typos.

12 years agoREADME,INSTALL: Fix some spelling errors.
Andre Noll [Fri, 28 Sep 2007 21:31:21 +0000 (23:31 +0200)]
README,INSTALL: Fix some spelling errors.

12 years agoMake com_lsblob() and com_lsatt() more similar to each other.
Andre Noll [Fri, 28 Sep 2007 19:54:23 +0000 (21:54 +0200)]
Make com_lsblob() and com_lsatt() more similar to each other.

12 years agoafs.cmd: Update help output.
Andre Noll [Fri, 28 Sep 2007 19:53:01 +0000 (21:53 +0200)]
afs.cmd: Update help output.

12 years agoImplement pattern matching for com_lsatt().
Andre Noll [Fri, 28 Sep 2007 17:55:17 +0000 (19:55 +0200)]
Implement pattern matching for com_lsatt().

12 years agoattribute.c: Implement pattern matching for com_rmatt().
Andre Noll [Fri, 28 Sep 2007 17:14:43 +0000 (19:14 +0200)]
attribute.c: Implement pattern matching for com_rmatt().

A straight forward task with the infrastructure already in place.

12 years agoImplement pattern matching for com_touch().
Andre Noll [Thu, 27 Sep 2007 15:47:46 +0000 (17:47 +0200)]
Implement pattern matching for com_touch().

Also, add -p and -v options and fix converting the last played
time which is a 64 bit intger, so strtol() will fail do it on 32
bit machines after 2039 ;)

To fix this, introduce para_atoi64() which calls strtoll() which
is 64 bit even on 32 bit machines and define para_atoi32() which
calls para_atoi64() and checks the boundaries.

12 years agocom_afs_rm(): Implement pattern matching and add -v, -p, -f flags.
Andre Noll [Thu, 27 Sep 2007 13:22:39 +0000 (15:22 +0200)]
com_afs_rm(): Implement pattern matching and add -v, -p, -f flags.

The -r flag is still to be implemented though..

12 years agoGerneralize for_each_matching_blob().
Andre Noll [Thu, 27 Sep 2007 10:25:05 +0000 (12:25 +0200)]
Gerneralize for_each_matching_blob().

It's not only useful for blobs. For instance the rm and the touch
commands might also want to use something similar. So move it to
afs.c and call it for_each_matching_row().

12 years agosha1.h: Typo.
Andre Noll [Thu, 27 Sep 2007 07:29:51 +0000 (09:29 +0200)]
sha1.h: Typo.

12 years agoattribute.c: Add doxygen file comment.
Andre Noll [Thu, 27 Sep 2007 07:29:33 +0000 (09:29 +0200)]
attribute.c: Add doxygen file comment.

12 years agoMove enum ls_sorting_method from afs.h to aft.c and add documentation.
Andre Noll [Wed, 26 Sep 2007 15:13:55 +0000 (17:13 +0200)]
Move enum ls_sorting_method from afs.h to aft.c and add documentation.

12 years agoAdd documentation of enum blob_table_columns.
Andre Noll [Wed, 26 Sep 2007 14:51:29 +0000 (16:51 +0200)]
Add documentation of enum blob_table_columns.

12 years agoFix table init.
Andre Noll [Wed, 26 Sep 2007 14:37:00 +0000 (16:37 +0200)]
Fix table init.

The previous patch introduced two instances of a bug which weren't noticed by
the compiler because attribute_table and score_table were declared as void *
pointers. Change that to struct osl_table *, and add the missing '&' operator.

void * pointers a evil.

12 years agoGet rid of the "table" member in struct table_info.
Andre Noll [Wed, 26 Sep 2007 14:31:00 +0000 (16:31 +0200)]
Get rid of the "table" member in struct table_info.

afs.c has no busyness in dealing with the table, so do not
expose it to afs.c.

12 years agoaddblob: Overwrite existing blobs.
Andre Noll [Wed, 26 Sep 2007 09:29:07 +0000 (11:29 +0200)]
addblob: Overwrite existing blobs.

Previously, an attempt to add a blob with a name of an already
existing blob failed (siltenly). Just replace the existing blob
with the new contents instead.

12 years agoafs ls -lv: Also print the tag info.
Andre Noll [Tue, 25 Sep 2007 19:37:31 +0000 (21:37 +0200)]
afs ls -lv: Also print the tag info.

12 years agocom_check(): Implement mood checking.
Andre Noll [Tue, 25 Sep 2007 12:57:09 +0000 (14:57 +0200)]
com_check(): Implement mood checking.

12 years agomake get_playlist_data() generic.
Andre Noll [Tue, 25 Sep 2007 12:16:14 +0000 (14:16 +0200)]
make get_playlist_data() generic.

Other blob types might use an analogous function as well, so introduce
blob_get_name_and_def_by_row() in blob.c, and use some preprocessor
magic to define such a function for each blob type.

Change all users of get_playlist_data() to use the new
pl_blob_get_name_and_def_by_row() and remove get_playlist_data().

12 years agomood.c: Rename mood_loop() to load_mood_loop_func().
Andre Noll [Tue, 25 Sep 2007 11:02:26 +0000 (13:02 +0200)]
mood.c: Rename mood_loop() to load_mood_loop_func().

And add a comment that describes why this function returns negative on success,
and positive on errors.

12 years agoUpdate Doxyfile to doxygen-1.5.3.
Andre Noll [Tue, 25 Sep 2007 10:51:38 +0000 (12:51 +0200)]
Update Doxyfile to doxygen-1.5.3.

Automatic update, done with doxygen -u.

12 years agoafs: Move some ls-related stuff from afs.h to aft.c.
Andre Noll [Tue, 25 Sep 2007 09:53:58 +0000 (11:53 +0200)]
afs: Move some ls-related stuff from afs.h to aft.c.

Also, add GPL header and documentation of struct afs_info to afs.h.

12 years agoMore mood cleanups.
Andre Noll [Tue, 25 Sep 2007 09:39:23 +0000 (11:39 +0200)]
More mood cleanups.

- Avoid use of global current_mood pointer where possible.
- Change name of non-static functions that use the current mood pointer:
mood_open() -> change_current_mood()
mood_close() -> close_current_mood()
mood_reload() -> reload_current_mood()

12 years agocompute_mood_score(): Add additional mood * parameter.
Andre Noll [Tue, 25 Sep 2007 08:59:56 +0000 (10:59 +0200)]
compute_mood_score(): Add additional mood * parameter.

Thid reduces the use of the global current_mood pointer.

12 years agocompute_mood_score(): Rename "row" parameter to "aft_row".
Andre Noll [Tue, 25 Sep 2007 08:53:52 +0000 (10:53 +0200)]
compute_mood_score(): Rename "row" parameter to "aft_row".

12 years agomood.c: Use current_mood as data pointer for parse_mood_line().
Andre Noll [Tue, 25 Sep 2007 08:47:38 +0000 (10:47 +0200)]
mood.c: Use current_mood as data pointer for parse_mood_line().

12 years agomood.c: Add GPL header.
Andre Noll [Tue, 25 Sep 2007 08:46:00 +0000 (10:46 +0200)]
mood.c: Add GPL header.

12 years agomood.c: Change type of rows from "void *" to "struct osl_row *".
Andre Noll [Tue, 25 Sep 2007 08:41:01 +0000 (10:41 +0200)]
mood.c: Change type of rows from "void *" to "struct osl_row *".

12 years agoscore.c: Remove an unused function declaration.
Andre Noll [Tue, 25 Sep 2007 08:40:23 +0000 (10:40 +0200)]
score.c: Remove an unused function declaration.

12 years agoafs.cmd: Add documentation of the remaining commands.
Andre Noll [Mon, 24 Sep 2007 19:26:17 +0000 (21:26 +0200)]
afs.cmd: Add documentation of the remaining commands.

And improve the formating of command options.

12 years agoblob.c: Implement pattern matching.
Andre Noll [Mon, 24 Sep 2007 16:10:36 +0000 (18:10 +0200)]
blob.c: Implement pattern matching.

Most of the blob functions now take a pattern list as arguments,
and the function does the job for all blobs that match any given
pattern in the list.

The only exceptions are addblob and mvblob where a pattern list
does not make sense.

12 years agoMake rbtree_loop() and rbtree_loop_reverse() safe against removal of an entry.
Andre Noll [Mon, 24 Sep 2007 16:08:13 +0000 (18:08 +0200)]
Make rbtree_loop() and rbtree_loop_reverse() safe against removal of an entry.

Also, fix the documentation of osl_rbtree_loop() which claimed that an
osl_rbtree_loop_func takes two void pointers which is not true any more.

12 years agoaft.c: Add GPL header.
Andre Noll [Mon, 24 Sep 2007 06:54:16 +0000 (08:54 +0200)]
aft.c: Add GPL header.

12 years agoafs.c: Avoid noisy log message.
Andre Noll [Sun, 23 Sep 2007 20:38:54 +0000 (22:38 +0200)]
afs.c: Avoid noisy log message.

para_server regularly sends SIGUSR1 to all of its children. afs
just ignores that signal, so only print a log message if a signal
different from SIGUSR1 was caught.

12 years agoafs.cmd: Add documentation of all blob commands.
Andre Noll [Sun, 23 Sep 2007 20:20:54 +0000 (22:20 +0200)]
afs.cmd: Add documentation of all blob commands.

12 years agocommand_util.sh: Fix man output for templates.
Andre Noll [Sun, 23 Sep 2007 20:20:24 +0000 (22:20 +0200)]
command_util.sh: Fix man output for templates.

12 years agoafs.c: Fix documentation of stdin_command().
Andre Noll [Sun, 23 Sep 2007 18:42:31 +0000 (20:42 +0200)]
afs.c: Fix documentation of stdin_command().

It doesn't read from stdin but from the given fd.

12 years agostdin.h, stdout.h: Trivial documentation cleanup.
Andre Noll [Sun, 23 Sep 2007 18:35:26 +0000 (20:35 +0200)]
stdin.h, stdout.h: Trivial documentation cleanup.

12 years agostdout.[ch]: Make two functions static.
Andre Noll [Sun, 23 Sep 2007 18:29:56 +0000 (20:29 +0200)]
stdout.[ch]: Make two functions static.

12 years agostdin.[ch]: Make two functions static.
Andre Noll [Sun, 23 Sep 2007 18:28:25 +0000 (20:28 +0200)]
stdin.[ch]: Make two functions static.

12 years agostdin.c: Fix a typo in documentation.
Andre Noll [Sun, 23 Sep 2007 18:25:54 +0000 (20:25 +0200)]
stdin.c: Fix a typo in documentation.

12 years agoImplement check for invalid playlist entries.
Andre Noll [Sun, 23 Sep 2007 17:34:17 +0000 (19:34 +0200)]
Implement check for invalid playlist entries.

Also some minor improvements for the audio file table checks.

12 years agoplaylist.c: Cleanups.
Andre Noll [Sun, 23 Sep 2007 15:56:39 +0000 (17:56 +0200)]
playlist.c: Cleanups.

Avoid using the global playlist variable where possible. Change the name of the
global static playlist struct to current_playlist.

12 years agoImplement check command.
Andre Noll [Sun, 23 Sep 2007 15:17:45 +0000 (17:17 +0200)]
Implement check command.

Currently it only checks the audio file table. Checking moods
and playlists will be implemented in a subsequent patch.

12 years agoAdd convert_0.2-0.3.sh.
Andre Noll [Sat, 22 Sep 2007 15:45:09 +0000 (17:45 +0200)]
Add convert_0.2-0.3.sh.

12 years agoafs.cmd: Add documentation of addatt, touch.
Andre Noll [Sat, 22 Sep 2007 15:43:50 +0000 (17:43 +0200)]
afs.cmd: Add documentation of addatt, touch.

12 years agonet.c: Fix a typo and improve send_bin_buffer() docu.
Andre Noll [Sat, 22 Sep 2007 12:48:45 +0000 (14:48 +0200)]
net.c: Fix a typo and improve send_bin_buffer() docu.

12 years agoafs.h: Change the prototype of stdin_command() to refelct reality.
Andre Noll [Sat, 22 Sep 2007 12:46:07 +0000 (14:46 +0200)]
afs.h: Change the prototype of stdin_command() to refelct reality.

12 years agoFix some bugs in blob handling.
Andre Noll [Sat, 22 Sep 2007 12:45:21 +0000 (14:45 +0200)]
Fix some bugs in blob handling.

- make fd2buf() decrypt the received data.
- stdin_command() has to read from the socket fd rather than from stdin.
  Moreover, it must send the AWAITING_DATA_MSG to the client.
- com_catblob() really needs to use send_bin_buffer() rather than send_buffer().
- com_addblob() has to pass the socket fd to stdin_command().

12 years agoFix com_lsblob().
Andre Noll [Sat, 22 Sep 2007 11:34:12 +0000 (13:34 +0200)]
Fix com_lsblob().

In case no output was produced, don't access output data and don't free it.

12 years agoFix off-by-one in com_rmatt().
Andre Noll [Sat, 22 Sep 2007 08:18:33 +0000 (10:18 +0200)]
Fix off-by-one in com_rmatt().

12 years agofsck.c: Fix a double free bug.
Andre Noll [Fri, 21 Sep 2007 09:19:38 +0000 (11:19 +0200)]
fsck.c: Fix a double free bug.

12 years agoMerge commit 'remotes/meins/v0.3' into v0.3
Andre Noll [Fri, 21 Sep 2007 09:01:13 +0000 (11:01 +0200)]
Merge commit 'remotes/meins/v0.3' into v0.3

12 years agoMake para_fsck work without specifying tables.
Andre Noll [Thu, 20 Sep 2007 21:44:31 +0000 (23:44 +0200)]
Make para_fsck work without specifying tables.

Also, move some fd related functions from osl.c to fd.c and
introduce para_opendir().

12 years agoRemove unused -E_LSTAT.
Andre Noll [Wed, 19 Sep 2007 21:12:52 +0000 (23:12 +0200)]
Remove unused -E_LSTAT.

12 years agoosl.c for_each_file_in_dir(): Move struct stat to inner loop.
Andre Noll [Wed, 19 Sep 2007 21:09:41 +0000 (23:09 +0200)]
osl.c for_each_file_in_dir(): Move struct stat to inner loop.

12 years agoGengetoptify para_fsck.
Andre Noll [Wed, 19 Sep 2007 20:41:15 +0000 (22:41 +0200)]
Gengetoptify para_fsck.

Basic fsck works, but some options are not yet implemented,
and dump is busted.

12 years agoerror.h: Add remaining error messages.
Andre Noll [Wed, 19 Sep 2007 17:14:10 +0000 (19:14 +0200)]
error.h: Add remaining error messages.

12 years agoaft.c: Fix a nasty memory corruption bug in afs_ls on 64 bit archs.
Andre Noll [Wed, 19 Sep 2007 17:07:36 +0000 (19:07 +0200)]
aft.c: Fix a nasty memory corruption bug in afs_ls on 64 bit archs.

That was pretty hard to spot but obvious once found.

12 years agoAdd para_fsck.
Andre Noll [Wed, 19 Sep 2007 06:21:24 +0000 (08:21 +0200)]
Add para_fsck.

12 years agoAdd small version of the earthshaking new logo.
Andre Noll [Tue, 18 Sep 2007 07:33:46 +0000 (09:33 +0200)]
Add small version of the earthshaking new logo.

12 years agoThe earthshaking new logo.
Andre Noll [Mon, 17 Sep 2007 18:24:46 +0000 (20:24 +0200)]
The earthshaking new logo.

12 years agoRevert "string.c: Use $HOME to get the home directory."
Andre Noll [Mon, 17 Sep 2007 17:08:58 +0000 (19:08 +0200)]
Revert "string.c: Use $HOME to get the home directory."

This reverts commit 379a2724984d903b7be8981a85b6cc82cab6ea90.

It doesn't play well with the -u option of para_server.

12 years agoserver/afs: Close an unused file descriptor.
Andre Noll [Sat, 15 Sep 2007 22:36:13 +0000 (00:36 +0200)]
server/afs: Close an unused file descriptor.

And mark file descriptors used for select() as non-blocking.

12 years agoSome documentation fixes.
Andre Noll [Sat, 15 Sep 2007 21:33:52 +0000 (23:33 +0200)]
Some documentation fixes.

MAke doxygen happy again and add documentation for com_setatt().

12 years agoosl.c: Rename verify_basename() to verify_name().
Andre Noll [Sat, 15 Sep 2007 21:08:23 +0000 (23:08 +0200)]
osl.c: Rename verify_basename() to verify_name().

It's actually used for verifying table names and column names.

12 years agoosl: Rename struct row.id to row.num.
Andre Noll [Sat, 15 Sep 2007 21:05:29 +0000 (23:05 +0200)]
osl: Rename struct row.id to row.num.

12 years agoaft.c: Kill global variable "now".
Andre Noll [Sat, 15 Sep 2007 20:58:16 +0000 (22:58 +0200)]
aft.c: Kill global variable "now".

12 years agoReplace void *row by struct osl_row *row.
Andre Noll [Sat, 15 Sep 2007 20:22:33 +0000 (22:22 +0200)]
Replace void *row by struct osl_row *row.

Also, make some functions in aft.c static.

12 years agoattribute.c: Major cleanup and fixes.
Andre Noll [Sat, 15 Sep 2007 20:14:31 +0000 (22:14 +0200)]
attribute.c: Major cleanup and fixes.

- Implement callback for the broken lsatt command.
- Add documentation and GPL header.
- Fix a nasty bug in com_setatt_callback().

12 years agoAdd more error descriptions.
Andre Noll [Sat, 15 Sep 2007 20:11:36 +0000 (22:11 +0200)]
Add more error descriptions.

12 years agoafs.cmd: Add documentation for lsatt.
Andre Noll [Sat, 15 Sep 2007 20:10:08 +0000 (22:10 +0200)]
afs.cmd: Add documentation for lsatt.

12 years agocommand.c: Fix a bug in get_cmd_ptr().
Andre Noll [Sat, 15 Sep 2007 20:09:31 +0000 (22:09 +0200)]
command.c: Fix a bug in get_cmd_ptr().

Caused handler to segfault if an invalid command was given.

12 years agoreplace para_connect() by PARA_CONNECT.
Andre Noll [Sat, 15 Sep 2007 17:42:29 +0000 (19:42 +0200)]
replace para_connect() by PARA_CONNECT.

PARA_CONNECT is a macro which works for all three socket address types
used in paraslash (sockaddr_in, sockaddr, sockaddr_un) and which does
not need a length parameter.

Change all instances of connect() and para_connect() to use PARA_CONNECT().

12 years agotime.c: Add GPL header and improve documentation.
Andre Noll [Sat, 15 Sep 2007 16:51:57 +0000 (18:51 +0200)]
time.c: Add GPL header and improve documentation.

12 years agoInvalidate table pointers on shutdown.
Andre Noll [Sat, 15 Sep 2007 16:32:32 +0000 (18:32 +0200)]
Invalidate table pointers on shutdown.

This caused a segfault when com_init() was invoked twice because
osl was trying to close an already closed table.

Also, add a bunch of error descriptions.

12 years agoRename osl index entry stuff.
Andre Noll [Sat, 15 Sep 2007 14:01:20 +0000 (16:01 +0200)]
Rename osl index entry stuff.

struct osl_table: index_entry_size -> row_index_size
get_index_entry_start -> get_row_index
get_index_entry -> get_cell_index
update_index_entry -> update_cell_index

12 years agologlevel adjustments.
Andre Noll [Sat, 15 Sep 2007 13:27:48 +0000 (15:27 +0200)]
loglevel adjustments.

12 years agoerror.h: Add error message for E_NO_MATCH.
Andre Noll [Sat, 15 Sep 2007 13:26:42 +0000 (15:26 +0200)]
error.h: Add error message for E_NO_MATCH.

12 years agoosl.c: Fix a bug in osl_update_object().
Andre Noll [Sat, 15 Sep 2007 13:12:59 +0000 (15:12 +0200)]
osl.c: Fix a bug in osl_update_object().

In case a mapped column is being updated, we have to unmap the
thing before appending to the data file.

12 years agocom_add(): Add missing return statement.
Andre Noll [Sat, 15 Sep 2007 08:41:48 +0000 (10:41 +0200)]
com_add(): Add missing return statement.

Duplicates were added twice in force mode.

12 years agoFix the privious assertion().
Andre Noll [Sat, 15 Sep 2007 07:50:14 +0000 (09:50 +0200)]
Fix the privious assertion().

It's OK to ask for the name of an audio format id < 0, as id -1 is used for
"currently no audio file is open". So allow this case, and fix the upper bound
which was off by one while we're at it.

12 years agoaudio_format_name(): Add an assert().
Andre Noll [Sat, 15 Sep 2007 07:39:18 +0000 (09:39 +0200)]
audio_format_name(): Add an assert().

The paraslash code should never request the name of an audio format
with invalid id. Introduce the ARRAY_SIZE macro to get the proper
upper bound for the number of supported audio formats.

12 years agoogg_afh.c: Store the bitrate in KHz rather than in Hz.
Andre Noll [Sat, 15 Sep 2007 07:29:18 +0000 (09:29 +0200)]
ogg_afh.c: Store the bitrate in KHz rather than in Hz.

The other audio format handlers also do it that way.

12 years agocommand.c: Fix om_help().
Andre Noll [Sat, 15 Sep 2007 07:16:05 +0000 (09:16 +0200)]
command.c: Fix om_help().

It segfaulted due to a missing return statement.

12 years agocommand.c: Increase maximal command length.
Andre Noll [Sat, 15 Sep 2007 07:15:09 +0000 (09:15 +0200)]
command.c: Increase maximal command length.

4096 is really short if you want to pass lots of filenames.