paraslash.git
12 years agoclient.c: Add status info.
Andre Noll [Tue, 1 Apr 2008 20:42:17 +0000 (22:42 +0200)]
client.c: Add status info.

12 years agoclient.c: Fix error value of supervisor task.
Andre Noll [Tue, 1 Apr 2008 20:42:00 +0000 (22:42 +0200)]
client.c: Fix error value of supervisor task.

12 years agoFix a bug in stdout.c.
Andre Noll [Tue, 1 Apr 2008 20:41:05 +0000 (22:41 +0200)]
Fix a bug in stdout.c.

12 years agoMake unregister_task() static.
Andre Noll [Tue, 1 Apr 2008 20:18:31 +0000 (22:18 +0200)]
Make unregister_task() static.

It has no more users outside sched.c.

12 years agoUpdate documentation for stdin.c and stdout.c.
Andre Noll [Tue, 1 Apr 2008 20:17:11 +0000 (22:17 +0200)]
Update documentation for stdin.c and stdout.c.

It contained some outdated comments.

12 years agostdin: Don't set sit->loaded.
Andre Noll [Tue, 1 Apr 2008 20:16:23 +0000 (22:16 +0200)]
stdin: Don't set sit->loaded.

It's pointless because the only users of stdin allocate a
static struct for the stdin task.

12 years agoFix two typos in stdin.c.
Andre Noll [Tue, 1 Apr 2008 20:09:41 +0000 (22:09 +0200)]
Fix two typos in stdin.c.

12 years agoKill unused wng_unregister().
Andre Noll [Tue, 1 Apr 2008 20:07:56 +0000 (22:07 +0200)]
Kill unused wng_unregister().

12 years agowng_open(): Defer registering the wng task.
Andre Noll [Tue, 1 Apr 2008 20:05:46 +0000 (22:05 +0200)]
wng_open(): Defer registering the wng task.

This way we do not have to unregister it on errors.

12 years agoaudiod: Rewrite status task logic.
Andre Noll [Tue, 1 Apr 2008 20:01:28 +0000 (22:01 +0200)]
audiod: Rewrite status task logic.

As the status task does not use any file descriptors, it's
OK to do everything in one function. So kill status_post_select()
and move the code to status_pre_select().

12 years agounregister_task(): Print what caused the task to shutdown.
Andre Noll [Tue, 1 Apr 2008 19:59:24 +0000 (21:59 +0200)]
unregister_task(): Print what caused the task to shutdown.

12 years agounregister_task(): Set error status to E_TASK_UNREGISTERED
Andre Noll [Tue, 1 Apr 2008 19:57:33 +0000 (21:57 +0200)]
unregister_task(): Set error status to E_TASK_UNREGISTERED

This way the users know when it's safe to free the memory
containing the task struct.

12 years agokill_task(): Only set task error status.
Andre Noll [Tue, 1 Apr 2008 19:55:26 +0000 (21:55 +0200)]
kill_task(): Only set task error status.

It's not safe to call unregister_task() at this point as
this function might be called from pre_select() or post_select().
Just set the task's error value to -E_TASK_KILLED. The task
will then be unregistered on the next iteration of the
scheduler loop.

12 years agoMerge commit 'remotes/fml/master'
Andre Noll [Tue, 1 Apr 2008 17:01:40 +0000 (19:01 +0200)]
Merge commit 'remotes/fml/master'

12 years agoafs.c: Make open_next_audio_file() static.
Andre Noll [Tue, 1 Apr 2008 09:29:11 +0000 (11:29 +0200)]
afs.c: Make open_next_audio_file() static.

12 years agoafs.c: Get rid of unregister_tasks().
Andre Noll [Tue, 1 Apr 2008 09:28:52 +0000 (11:28 +0200)]
afs.c: Get rid of unregister_tasks().

Call shed_shutdown() instead. Also make read errors from the
afs - server pipe fatal.

12 years agoaudiod: Don't unregister tasks, just set the error value.
Andre Noll [Mon, 31 Mar 2008 23:07:03 +0000 (01:07 +0200)]
audiod: Don't unregister tasks, just set the error value.

This is a first step to get rid of unregister_task().

12 years agofilter: Switch from linked lists to arrays.
Andre Noll [Mon, 31 Mar 2008 22:23:58 +0000 (00:23 +0200)]
filter: Switch from linked lists to arrays.

The number of filters is known and never changes, so it's easier
to use arrays.

12 years agosched: Only call pre/post select hooks if tasks are not in error state.
Andre Noll [Mon, 31 Mar 2008 20:35:06 +0000 (22:35 +0200)]
sched: Only call pre/post select hooks if tasks are not in error state.

12 years agoFix afs shutdown.
Andre Noll [Mon, 31 Mar 2008 17:08:34 +0000 (19:08 +0200)]
Fix afs shutdown.

In case para_server dies, the afs process must unregister all
tasks in order to shut down cleanly.

12 years agoDocumentation updates and cleanups.
Andre Noll [Mon, 31 Mar 2008 12:02:15 +0000 (14:02 +0200)]
Documentation updates and cleanups.

12 years agosched.c: Cosmetic cleanups.
Andre Noll [Mon, 31 Mar 2008 11:56:15 +0000 (13:56 +0200)]
sched.c: Cosmetic cleanups.

12 years agoafs: Shutdown the scheduler if a fatal signal was caught.
Andre Noll [Mon, 31 Mar 2008 11:52:51 +0000 (13:52 +0200)]
afs: Shutdown the scheduler if a fatal signal was caught.

This fixes the problem that the afs database was not marked clean
and thus had to be checked if para_server was interupted by a
signal.

12 years agoExport sched_shutdown().
Andre Noll [Mon, 31 Mar 2008 11:51:02 +0000 (13:51 +0200)]
Export sched_shutdown().

12 years agosched.c: Add checks for empty lists.
Andre Noll [Mon, 31 Mar 2008 11:50:43 +0000 (13:50 +0200)]
sched.c: Add checks for empty lists.

This allows to call shed_shutdown() from the pre/post select hooks
of the tasks.

12 years agoaudiod.c: Fix stat task restarting.
Andre Noll [Mon, 31 Mar 2008 11:15:37 +0000 (13:15 +0200)]
audiod.c: Fix stat task restarting.

12 years agoungegister_task(): Set task error value to -E_TASK_KILLED.
Andre Noll [Mon, 31 Mar 2008 11:11:46 +0000 (13:11 +0200)]
ungegister_task(): Set task error value to -E_TASK_KILLED.

This way, one can be sure that a negative value in t->error means
this task will not be scheduled again.

12 years agoSimplify the scheduling code.
Andre Noll [Sun, 30 Mar 2008 20:56:16 +0000 (22:56 +0200)]
Simplify the scheduling code.

- Get rid of sched->select_ret. Tasks shouldn't care about the
return value of the select call.

- Kill task->private_data. Use container_of() instead.

- Remove task->event_handler. It is never necessary and only
makes the code more convoluted. The scheduler unregisters
tasks as soon as either the pre_select or the post_select
functions return an error.

- Rename task->ret to task->error and get rid of a couple
of error fields in other structs that usually only contained
a copy of the task's error value.

This conversion likely introduces many bugs that have to be
shaken out in subsequent patches. Hopefully it will result in
less error-prone code in the long run.

12 years agoAdd documentation for the loglevel argument of para_server.
Andre Noll [Sun, 30 Mar 2008 14:21:02 +0000 (16:21 +0200)]
Add documentation for the loglevel argument of para_server.

12 years agoIncrease aggressiveness of the compress filter.
Andre Noll [Sun, 30 Mar 2008 14:20:24 +0000 (16:20 +0200)]
Increase aggressiveness of the compress filter.

12 years agoFix lsatt command.
Andre Noll [Sat, 29 Mar 2008 11:42:54 +0000 (12:42 +0100)]
Fix lsatt command.

12 years agoFix afs signal handling.
Andre Noll [Tue, 25 Mar 2008 07:47:34 +0000 (08:47 +0100)]
Fix afs signal handling.

afs must not abort on SIGPIPE as the client may close the
connection at any time. This bug was there forever but showed
up only now because the recent callback changes made the afs
process write to the command handler socket multiple times.

Also ignore SIGUSR1 instead of catching and ignoring it.

12 years agoUpdate doxygen documentation.
Andre Noll [Tue, 25 Mar 2008 00:19:21 +0000 (01:19 +0100)]
Update doxygen documentation.

12 years agoComplete the afs callback conversion.
Andre Noll [Mon, 24 Mar 2008 23:18:01 +0000 (00:18 +0100)]
Complete the afs callback conversion.

This makes it possible for the callbacks to pass a partial
result buffer through the command handler <-> callback socket.
This removes a serious limitation of previous paraslash-0.3.x
versions: As callbacks could not send data directly to the
command handler they had to store the full command output in
a buffer. This buffer was sent to the command handler after the
callback returns.

The problem with this approach is that it caused the callbacks
to  allocate large amounts of memory. If that amount exceeded what
can be stored in a shared memory area (32MB on Linux), the command
even failed.

The fix consists of adding a max_size field and a max_size_handler
function pointer to the para_buffer structure. Whenever para_printf()
would need to allocate more memory than specified by max_size, it
calls the max_size_handler which is supposed to send out the data.
para_printf then prints the requested data into the old but now
empty buffer.

Almost all users set the max_size_handler to pass_buffer_as_shm(),
a helper function implemented in afs.c that copies the buffer to
a shared memory area and sends its identifier through the socket.

12 years agoIntroduce pass_object_as_shm().
Andre Noll [Mon, 24 Mar 2008 15:04:21 +0000 (16:04 +0100)]
Introduce pass_object_as_shm().

This singles out the code for passing data from the callback
to the command handler. The plan is to change the callbacks
so that they call this function whenever the result buffer
is too large to fit into a shared memory area.

12 years agomake send_callback_request() and friends take a result handler.
Andre Noll [Mon, 24 Mar 2008 14:20:28 +0000 (15:20 +0100)]
make send_callback_request() and friends take a result handler.

This is a first step to overcome a design flaw in the afs
callback code: The output of the commands is currently
stored in an osl object that is copied to a shared memory
area whose shmid is passed back to the command handler
via the local socket. This method limits the size of the
command output to the maximal size that can be stored in
a shared memory area which is not enough to hold large
outputs like that of ls -c.

This patch allows the command handlers to pass a result handler
function instead of an osl object. This result handler is
called for each shared memory area that gets sent through the
local socket.

Further patches will change the callbacks so that they pass
multiple result buffers instead of returning a single buffer.
This has the additional advantage that partial command output
produced by the callback can be sent even before the callback
returns. This parital output is seen immediately by the command
handler.

12 years agoFix use of uninitialized afhi->header_len.
Andre Noll [Wed, 19 Mar 2008 20:51:46 +0000 (21:51 +0100)]
Fix use of uninitialized afhi->header_len.

In aft's add_one_audio_file() we set the header len and
the header offset to zero so that the get_file_info()
functions of the audio format handlers that do not use
headers don't need to zero these fields.

However, this is not the right place to do that as para_afh
also calls get_file_info() via compute_afhi() but missed to
clear these fields which leads to a segmentation fault.

Fix this bug by moving the zeroing to compute_afhi().

12 years agoFix compilation of para_fade in certain cases.
Andre Noll [Mon, 17 Mar 2008 09:49:41 +0000 (10:49 +0100)]
Fix compilation of para_fade in certain cases.

We really need to do the _cmdline_objs and _errlist_objs dance
in configure.ac.

Also, fix the configure warning message in case linux/soundcard.h
was found but alsa wasn't, and remove the object list of para_fsck
from Makefile.in.

12 years agoMerge commit 'remotes/meins/master'
Andre Noll [Mon, 17 Mar 2008 08:43:33 +0000 (09:43 +0100)]
Merge commit 'remotes/meins/master'

12 years agofsck.c: Fix typo.
Andre Noll [Mon, 17 Mar 2008 08:41:08 +0000 (09:41 +0100)]
fsck.c: Fix typo.

Spotted and fixed by Gerrit Renker.

12 years agosignal.c: Cosmetics.
Andre Noll [Mon, 17 Mar 2008 06:40:48 +0000 (07:40 +0100)]
signal.c: Cosmetics.

12 years agoKill unused error code SIGNAL_READ.
Andre Noll [Mon, 17 Mar 2008 06:36:40 +0000 (07:36 +0100)]
Kill unused error code SIGNAL_READ.

12 years agoFix para_next_signal().
Andre Noll [Mon, 17 Mar 2008 06:34:29 +0000 (07:34 +0100)]
Fix para_next_signal().

The function returned zero in case of errors..

12 years agoLet the daemon option depend on the logfile option.
Andre Noll [Sun, 16 Mar 2008 13:16:17 +0000 (14:16 +0100)]
Let the daemon option depend on the logfile option.

This allows to remove the check in server.c.

12 years agoMore detailed and much nicer para_server man page.
Andre Noll [Sun, 16 Mar 2008 13:12:11 +0000 (14:12 +0100)]
More detailed and much nicer para_server man page.

12 years agoafh.c: Use write_all() instead of write().
Andre Noll [Sat, 15 Mar 2008 18:12:32 +0000 (19:12 +0100)]
afh.c: Use write_all() instead of write().

12 years agoMove write_all() from net.c to fd.c.
Andre Noll [Sat, 15 Mar 2008 18:09:53 +0000 (19:09 +0100)]
Move write_all() from net.c to fd.c.

This way it can be used also for programs that don't need
networking.

12 years agonet.c: Rename sendall() to write_all().
Andre Noll [Sat, 15 Mar 2008 18:06:22 +0000 (19:06 +0100)]
net.c: Rename sendall() to write_all().

It actually uses write(), not send().

12 years agoImplement streaming mode for para_afh.
Andre Noll [Sat, 15 Mar 2008 18:03:18 +0000 (19:03 +0100)]
Implement streaming mode for para_afh.

12 years agoMove the get_chunk and the get_header functions from vss.c to afh.c.
Andre Noll [Sat, 15 Mar 2008 18:02:27 +0000 (19:02 +0100)]
Move the get_chunk and the get_header functions from vss.c to afh.c.

Also move compute_chunk_time() to time.c.

12 years agoAdd missing files for para_afh.
Andre Noll [Fri, 14 Mar 2008 20:29:24 +0000 (21:29 +0100)]
Add missing files for para_afh.

It's too easy to miss with git..

12 years agoMerge commit 'remotes/meins/master'
Andre Noll [Fri, 14 Mar 2008 09:01:47 +0000 (10:01 +0100)]
Merge commit 'remotes/meins/master'

12 years agoAdd para_afh to web pages.
Andre Noll [Fri, 14 Mar 2008 08:33:37 +0000 (09:33 +0100)]
Add para_afh to web pages.

12 years agoGet rid of E_BAD_AUDIO_FILE_SUFFIX.
Andre Noll [Thu, 13 Mar 2008 23:16:54 +0000 (00:16 +0100)]
Get rid of E_BAD_AUDIO_FILE_SUFFIX.

It's value was never used.

12 years agoImplement para_afh: The stand-alone audio file handler.
Andre Noll [Thu, 13 Mar 2008 23:11:12 +0000 (00:11 +0100)]
Implement para_afh: The stand-alone audio file handler.

12 years agoaft.c: Move definition of "buf" down a bit.
Andre Noll [Thu, 13 Mar 2008 23:07:20 +0000 (00:07 +0100)]
aft.c: Move definition of "buf" down a bit.

12 years agoosl.c: Simplify comment.
Andre Noll [Thu, 13 Mar 2008 21:33:03 +0000 (22:33 +0100)]
osl.c: Simplify comment.

12 years agoafs.c: Cosmetic comment cleanup.
Andre Noll [Thu, 13 Mar 2008 21:32:14 +0000 (22:32 +0100)]
afs.c: Cosmetic comment cleanup.

12 years agoconfigure.ac: para_audiod is optional.
Andre Noll [Thu, 13 Mar 2008 21:08:33 +0000 (22:08 +0100)]
configure.ac: para_audiod is optional.

So add it only to all_executables if at least one audio
format is supported.

12 years agoFix documentation of select command.
Andre Noll [Thu, 13 Mar 2008 15:49:58 +0000 (16:49 +0100)]
Fix documentation of select command.

As pointed out by Gerrit Renker, the help text still used the old
syntax that changed in

f010019b9e89b814699bd6a94edaa8cde9cbd45c

12 years agoAdd new ls option: -lc to print out the chunk table.
Andre Noll [Wed, 12 Mar 2008 21:57:24 +0000 (22:57 +0100)]
Add new ls option: -lc to print out the chunk table.

12 years agonew codename, reset version to git
Andre Noll [Sat, 23 Feb 2008 19:27:46 +0000 (20:27 +0100)]
new codename, reset version to git

12 years agothe paraslash-0.3.1 release tarball
Andre Noll [Sat, 23 Feb 2008 19:22:08 +0000 (20:22 +0100)]
the paraslash-0.3.1 release tarball

12 years agoparaslash 0.3.1 v0.3.1
Andre Noll [Sat, 23 Feb 2008 19:19:05 +0000 (20:19 +0100)]
paraslash 0.3.1

12 years agopara.h: Change copyright year to 2008.
Andre Noll [Sat, 23 Feb 2008 19:18:39 +0000 (20:18 +0100)]
para.h: Change copyright year to 2008.

12 years agoFEATURES: Fix a typo and use uniform capitalization for list items.
Andre Noll [Mon, 18 Feb 2008 00:42:16 +0000 (01:42 +0100)]
FEATURES: Fix a typo and use uniform capitalization for list items.

12 years agoNEWS update.
Andre Noll [Mon, 18 Feb 2008 00:28:26 +0000 (01:28 +0100)]
NEWS update.

12 years agostring.c: Fix a typo.
Andre Noll [Mon, 18 Feb 2008 00:28:03 +0000 (01:28 +0100)]
string.c: Fix a typo.

12 years agoserver.c: Add missing newline in log message.
Andre Noll [Sun, 17 Feb 2008 21:13:13 +0000 (22:13 +0100)]
server.c: Add missing newline in log message.

12 years agoKill superfluous "%s" in log messages.
Andre Noll [Sun, 17 Feb 2008 21:12:39 +0000 (22:12 +0100)]
Kill superfluous "%s" in log messages.

12 years agoosl_core: Fix some typos in documentation.
Andre Noll [Sun, 17 Feb 2008 21:01:46 +0000 (22:01 +0100)]
osl_core: Fix some typos in documentation.

12 years agoserver.c: Clarify fatal log message.
Andre Noll [Sun, 17 Feb 2008 20:55:19 +0000 (21:55 +0100)]
server.c: Clarify fatal log message.

And kill the superfluous "%s" parameter.

12 years agodaemon.c: Minor logging impreovments.
Andre Noll [Sun, 17 Feb 2008 20:54:02 +0000 (21:54 +0100)]
daemon.c: Minor logging impreovments.

12 years agoBe more careful in daemon_init().
Andre Noll [Sun, 17 Feb 2008 20:53:21 +0000 (21:53 +0100)]
Be more careful in daemon_init().

setsid(), chdir() and dup2() all may fail. So check the
return value.

12 years agoaudiod.c: Don't log to /dev/null.
Andre Noll [Sun, 17 Feb 2008 20:52:21 +0000 (21:52 +0100)]
audiod.c: Don't log to /dev/null.

There's no point in computing the log message if we are
going to write it to /dev/null.

12 years agoAdd documentation of struct sender status.
Andre Noll [Sun, 17 Feb 2008 13:14:10 +0000 (14:14 +0100)]
Add documentation of struct sender status.

12 years agocom_touch(): Print a message if no audio files matched.
Andre Noll [Sat, 16 Feb 2008 19:25:48 +0000 (20:25 +0100)]
com_touch(): Print a message if no audio files matched.

12 years agoDoxify send_common.c.
Andre Noll [Sat, 16 Feb 2008 19:25:10 +0000 (20:25 +0100)]
Doxify send_common.c.

12 years agoSender code consolidation, on/off commands for the dccp sender.
Andre Noll [Sat, 16 Feb 2008 14:33:50 +0000 (15:33 +0100)]
Sender code consolidation, on/off commands for the dccp sender.

This patch moves a bunch of code from the http sender to
send_common.c to make it available also for the dccp sender.

To this aim a new structure sender_status is introduced which
holds the configuration and the current status of the http/dccp
sender. Most of the new functions in send_common.c take a pointer
to such a structure.

This allows to implement the off/on/allow/deny/info commands
as a one-liner for both the dccp and the http sender.

The new server config option dccp_max_clients allows to restrict the
number of simultaneous connections to the dccp sender.

12 years agoacl.c: Trivial whitespace cleanups.
Andre Noll [Wed, 13 Feb 2008 18:36:08 +0000 (19:36 +0100)]
acl.c: Trivial whitespace cleanups.

12 years agouser_list: Fix doxygen \param.
Andre Noll [Mon, 11 Feb 2008 19:33:50 +0000 (20:33 +0100)]
user_list: Fix doxygen \param.

12 years agoinit_random_seed(): Use para_open() to open /dev/urandom.
Andre Noll [Mon, 11 Feb 2008 19:33:20 +0000 (20:33 +0100)]
init_random_seed(): Use para_open() to open /dev/urandom.

Clean up this function while at it.

12 years agoDoxyfile: Remove HAVE_MYSQL define.
Andre Noll [Mon, 11 Feb 2008 19:32:17 +0000 (20:32 +0100)]
Doxyfile: Remove HAVE_MYSQL define.

12 years agoRemove duplicate error code.
Andre Noll [Mon, 11 Feb 2008 19:31:52 +0000 (20:31 +0100)]
Remove duplicate error code.

We had AFS_SHORT_READ and SHORT_AFS_READ.

12 years agoRemove para_mkstemp().
Andre Noll [Sun, 10 Feb 2008 13:30:30 +0000 (14:30 +0100)]
Remove para_mkstemp().

It's unused.

12 years agoNEWS update.
Andre Noll [Sun, 10 Feb 2008 13:20:36 +0000 (14:20 +0100)]
NEWS update.

12 years agoSpeed up audiod_pre_select.
Andre Noll [Sun, 10 Feb 2008 13:20:09 +0000 (14:20 +0100)]
Speed up audiod_pre_select.

Catch the common case early in the function to minimize the
number of checks for that case.

12 years agocompress.c: Get rid of min_gain.
Andre Noll [Sun, 10 Feb 2008 13:19:02 +0000 (14:19 +0100)]
compress.c: Get rid of min_gain.

Always use no amplification, i.e. 1 << pcd->conf->inertia_arg as
the minimal gain.

12 years agostring.c: Documentation cleanups.
Andre Noll [Sun, 10 Feb 2008 13:17:25 +0000 (14:17 +0100)]
string.c: Documentation cleanups.

12 years agoGet rid of E_MKSTEMP and E_FCHMOD.
Andre Noll [Sun, 10 Feb 2008 13:16:42 +0000 (14:16 +0100)]
Get rid of E_MKSTEMP and E_FCHMOD.

Use the system errno instead.

12 years agoSpeed up open_current_receiver().
Andre Noll [Sun, 10 Feb 2008 11:49:29 +0000 (12:49 +0100)]
Speed up open_current_receiver().

To my surprise, this function showed up in the profiling info.
This is due to the fact that the old code was parsing the
FORMAT status item in audiod_pre_select() which gets called
on each iteration of the sheduler. However, this status item
gets only modified on audio file change.

So parse the status item string only once, when we receive it,
and store the current audio format number in the new field of
struct status_task.

12 years agocompress_filter.ggo: Decrease block size from 16 to 15.
Andre Noll [Sat, 9 Feb 2008 19:33:36 +0000 (20:33 +0100)]
compress_filter.ggo: Decrease block size from 16 to 15.

This means twice as many volume adjustments.

12 years agocompress.c: Simplify volume adjusting code.
Andre Noll [Sat, 9 Feb 2008 19:32:36 +0000 (20:32 +0100)]
compress.c: Simplify volume adjusting code.

There's no need to distinguish the cases sample > 0 and
sample < 0. Work with its absolute value instead and get
rid of some similar code in the hot path.

Also print a log message in case clipping occurs.

12 years agocompress.c: Cosmetics.
Andre Noll [Sat, 9 Feb 2008 18:53:28 +0000 (19:53 +0100)]
compress.c: Cosmetics.

12 years agouser_list.c: Minor documentation impreovements.
Andre Noll [Sat, 9 Feb 2008 18:42:05 +0000 (19:42 +0100)]
user_list.c: Minor documentation impreovements.

12 years agopopulate_user_list(): Do not abort if the rsa key of a user is unavailable.
Andre Noll [Sat, 9 Feb 2008 18:34:53 +0000 (19:34 +0100)]
populate_user_list(): Do not abort if the rsa key of a user is unavailable.

Skip this line of the user list file instead.

12 years agouser_list.c: Simplify populate_user_list().
Andre Noll [Sat, 9 Feb 2008 18:22:13 +0000 (19:22 +0100)]
user_list.c: Simplify populate_user_list().

12 years agouser_list.c: Fix documentation of populate_user_list().
Andre Noll [Sat, 9 Feb 2008 18:07:02 +0000 (19:07 +0100)]
user_list.c: Fix documentation of populate_user_list().

12 years agoafs.c: Fix fd number in log output.
Andre Noll [Sat, 9 Feb 2008 17:57:47 +0000 (18:57 +0100)]
afs.c: Fix fd number in log output.

12 years agoKill unused error code WRITE_OK.
Andre Noll [Sat, 9 Feb 2008 17:57:14 +0000 (18:57 +0100)]
Kill unused error code WRITE_OK.