From 49412fa9ecfa07dfcb6e7a087d70de9fc88838a7 Mon Sep 17 00:00:00 2001 From: Andre Noll Date: Sun, 15 Jul 2012 23:57:53 +0200 Subject: [PATCH] fade: Handle non-positive fade time gracefully. Currently, we don't do anything if the fade_time parameter is less than or equal to zero. Just setting the destination volume seems to be more natural in this case. --- fade.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fade.c b/fade.c index 2954fa32..68e1b5f5 100644 --- a/fade.c +++ b/fade.c @@ -52,7 +52,7 @@ static int fade(struct mixer *m, struct mixer_handle *h, int new_vol, int fade_t unsigned long long tmp, tmp2; /* Careful with that axe, Eugene! */ if (fade_time <= 0) - return 1; + return m->set(h, new_vol); secs = fade_time; PARA_NOTICE_LOG("fading to %d in %d seconds\n", new_vol, secs); ret = m->get(h); -- 2.39.2